From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marlon <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [RFC][PATCH] Reset ZLE hooks when changing prompt themes (was Re: [RFC][PATCH] `newuser` prompt theme)
Date: Thu, 15 Apr 2021 21:34:56 +0000 [thread overview]
Message-ID: <20210415213456.GE6669@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <E643A9C4-AFCD-481E-B2B1-3F305DBFFBB8@gmail.com>
Marlon wrote on Thu, Apr 15, 2021 at 21:54:48 +0300:
> Patch attached, but not yet including Daniel’s suggested change below (since I still have questions about it). It includes an update to the docs, but note that I am not able to build those myself. I would much appreciate it f someone else could do that to test whether I did it correctly.
>
> On 14 Apr 2021, at 15:05, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >> +++ b/Functions/Prompts/promptinit
> >> @@ -178,8 +177,13 @@ Use prompt -h <theme> for help on specific themes.'
> >>
> >> # Reset some commonly altered bits to the default
> >> local hook
> >> - for hook in chpwd precmd preexec periodic zshaddhistory zshexit; do
> >> - add-zsh-hook -D "${hook}" "prompt_*_${hook}"
> >> + for hook in chpwd precmd preexec periodic zshaddhistory zshexit \
> >> + zsh_directory_name; do
> >> + add-zsh-hook -D "$hook" "prompt_*_$hook"
> >> + done
> >> + for hook in isearch-exit isearch-update line-pre-redraw line-init \
> >> + line-finish history-line-set keymap-select; do
> >> + add-zle-hook-widget -D "$hook" "prompt_*_$hook"
> >
> > All these should be documented, like prompt_${foo}_preview is.
> >
> > Recommend to name these prompt_${foo}_bar-{isearch-exit,isearch-update,…,keymap-select}
> > for some fixed value of «bar» to avoid namespace issues (i.e., name
> > collisions between existing prompts and future hooks).
>
> Wouldn’t that be a breaking change in the API, though?
No, it wouldn't, because those are add-zle-hook-widget hooks and the
current API only deals with add-zsh-hook hooks.
We could even recommend that add-zsh-hook hooks be named
prompt_${foo}_baz_{chpwd,…} for some fixed value of baz. We don't even
have to change the code to support this (because the asterisk will match
«${foo}_baz» just fine); we just need to document the recommendation and
deprecate the previous recommended naming pattern.
> I mean, there are already 3rd party prompt themes that use the current prompt_${foo}_{isearch-exit,isearch-update,…,keymap-select} naming scheme.
And you're arguing that avoiding breaking code of third parties that
relied on a patch that (presumably) hadn't even been posted to
-workers@, never mind merged to master and released in a stable release,
trumps preventing namespace collisions for future users?
> Also, isn’t the prefix prompt_${foo}_ already a namespace of sorts? Why change this?
What if the foo theme declares a function called prompt_foo_lorem (or
even prompt_foo_ipsum_lorem) that _isn't_ an «add-*-hook lorem» hook
function, and later we start to to auto-register functions matching the
name pattern?
Or if we were to make «add-zsh-hook bar lorem» and «add-zle-hook-widget
bar ipsum» both valid, for a single value of bar, and a prompt theme
wanted to install both hooks _and_ name the functions «lorem» and «ipsum»
conventionally?
Or if someone wanted to quickly grep for add-zle-hook-widget callbacks?
> From b60bfd135ae2631a3b28aaf81074594d0ec1f967 Mon Sep 17 00:00:00 2001
> From: Marlon Richert <marlon.richert@gmail.com>
> Date: Thu, 15 Apr 2021 21:50:36 +0300
> Subject: [PATCH] Reset ZLE hooks when changing prompt themes
>
Your mail didn't trigger workers/48587 (that's good). I wonder why.
Probably because your MUA quoted-printable-escaped the first byte of the
From_ line.
> +++ b/Doc/Zsh/contrib.yo
> @@ -2032,10 +2032,10 @@ setopts (tt(promptbang), etc.) are turned on, all other prompt-related
> options are turned off. The tt(prompt_opts) array preserves setopts even
> beyond the scope of tt(localoptions), should your function need that.
> )
> -item(Modify precmd and preexec)(
> -Use of tt(add-zsh-hook) is recommended. The tt(precmd) and tt(preexec)
> -hooks are automatically adjusted if the prompt theme changes or is
> -disabled.
> +item(Modify hooks)(
> +Use of tt(add-zsh-hook) and tt(add-zle-hook-widget) is recommended. All hooks
> +that follow the naming pattern tt(prompt_<theme>_<hook>) are automatically
This should be tt(prompt_)var(theme)tt(_)var(hook).
> +removed when the prompt theme changes or is disabled.
Add a pointer to the relevant section? Something like
.
ifzman(… Manipulating Hook Functions … above)ifnzman(noderef(Manipulating Hook Functions))
.
plus appropriate markup in the first branch.
> +++ Functions/Prompts/promptinit
> @@ -14,6 +14,8 @@ prompt_themes=()
> promptinit () {
> emulate -L zsh
> setopt extendedglob
> + autoload -Uz add-zsh-hook add-zle-hook-widget
> +
> local ppath='' name theme
> local -a match mbegin mend
>
> @@ -32,9 +34,6 @@ promptinit () {
> fi
> done
>
> - # To manipulate precmd and preexec hooks...
> - autoload -Uz add-zsh-hook
> -
> # Variables common to all prompt styles
> prompt_newline=$'\n%{\r%}'
> }
> @@ -178,8 +177,13 @@ Use prompt -h <theme> for help on specific themes.'
>
> # Reset some commonly altered bits to the default
> local hook
> - for hook in chpwd precmd preexec periodic zshaddhistory zshexit; do
> - add-zsh-hook -D "${hook}" "prompt_*_${hook}"
> + for hook in chpwd precmd preexec periodic zshaddhistory zshexit \
> + zsh_directory_name; do
> + add-zsh-hook -D "$hook" "prompt_*_$hook"
> + done
> + for hook in isearch-exit isearch-update line-pre-redraw line-init \
> + line-finish history-line-set keymap-select; do
> + add-zle-hook-widget -D "$hook" "prompt_*_$hook"
> done
> typeset -ga zle_highlight=( ${zle_highlight:#default:*} )
> (( ${#zle_highlight} )) || unset zle_highlight
Hmm. I'm not at all sure that this is sufficient. There's a bunch of
reference to precmd and preexec in promptinit; it's possible that some
of these should also handle chpwd,periodic,zshaddhistory,zshexit
(a preëxisting issue) and the add-zle-hook-widget hook classes (an issue
this patch might be introducing).
Cheers,
Daniel
next prev parent reply other threads:[~2021-04-15 21:36 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 19:41 [RFC][PATCH] `newuser` prompt theme Marlon
2021-04-13 20:31 ` Roman Perepelitsa
2021-04-13 20:44 ` Bart Schaefer
2021-04-14 5:09 ` Marlon Richert
2021-04-14 5:17 ` Bart Schaefer
2021-04-14 5:45 ` Marlon
2021-04-14 12:05 ` Daniel Shahaf
2021-04-14 13:17 ` Marlon
2021-04-14 14:09 ` Daniel Shahaf
2021-04-15 1:07 ` Bart Schaefer
2021-04-15 3:50 ` Marlon Richert
2021-04-15 20:27 ` Daniel Shahaf
2021-04-15 23:42 ` Daniel Shahaf
2021-04-15 11:11 ` Mikael Magnusson
2021-04-15 16:44 ` vcs_info's global variables (was: Re: [RFC][PATCH] `newuser` prompt theme) Daniel Shahaf
2021-04-16 16:04 ` [RFC][PATCH] `newuser` prompt theme Marlon
2021-04-16 17:13 ` Daniel Shahaf
2021-04-16 19:19 ` Marlon Richert
2021-04-16 19:30 ` Daniel Shahaf
2021-04-19 16:46 ` Marlon Richert
2021-05-02 17:18 ` Lawrence Velázquez
2021-05-03 2:38 ` Bart Schaefer
2021-05-03 4:11 ` Lawrence Velázquez
2021-05-03 11:38 ` [PATCH] Add customizable `vcs` prompt theme (was Re: [RFC][PATCH] `newuser` prompt theme) Marlon Richert
2021-05-09 18:04 ` Lawrence Velázquez
2021-05-31 1:01 ` Lawrence Velázquez
2021-06-09 12:58 ` Marlon Richert
2021-06-09 13:22 ` Roman Perepelitsa
2021-06-09 18:06 ` Marlon Richert
2021-06-10 9:30 ` Roman Perepelitsa
2021-06-10 13:47 ` Marlon Richert
2021-06-10 14:01 ` Marlon Richert
2021-06-10 17:45 ` Roman Perepelitsa
2021-06-20 22:13 ` Marlon Richert
2021-06-23 17:26 ` Roman Perepelitsa
2022-08-08 10:12 ` Marlon Richert
2022-08-08 10:17 ` Roman Perepelitsa
2021-04-14 14:09 ` sysexits.h codes? (was: " Daniel Shahaf
2021-04-30 19:40 ` Marlon Richert
2021-04-30 21:16 ` Daniel Shahaf
2021-04-30 21:34 ` Bart Schaefer
2021-05-01 15:09 ` Daniel Shahaf
2021-04-30 21:40 ` Bart Schaefer
2021-05-01 13:39 ` Marlon Richert
2021-05-01 14:43 ` Daniel Shahaf
2021-05-03 11:36 ` Marlon Richert
2021-05-03 16:04 ` Daniel Shahaf
2021-05-04 11:13 ` Marlon Richert
2021-05-21 11:38 ` Marlon Richert
2021-04-14 15:30 ` [RFC][PATCH] `newuser` prompt theme Arseny Maslennikov
2021-04-14 18:52 ` Daniel Shahaf
2021-04-14 14:00 ` precmd hooks and $? Bart Schaefer
2021-04-14 15:18 ` docs patches for precmd hooks and $?, and vcs_info Daniel Shahaf
2021-04-15 2:35 ` Bart Schaefer
2021-04-15 16:17 ` Archives render attachments as first-class messages (was: docs patches for precmd hooks and $?, and vcs_info) Daniel Shahaf
2021-04-15 18:54 ` [RFC][PATCH] Reset ZLE hooks when changing prompt themes (was Re: [RFC][PATCH] `newuser` prompt theme) Marlon
2021-04-15 21:34 ` Daniel Shahaf [this message]
2021-04-16 22:34 ` Marlon Richert
2021-04-25 16:08 ` Lawrence Velázquez
2021-05-02 17:03 ` Lawrence Velázquez
2021-05-02 17:59 ` Bart Schaefer
2021-05-05 6:10 ` Marlon Richert
2021-05-16 15:27 ` Lawrence Velázquez
2021-05-16 19:31 ` Marlon Richert
2021-05-17 4:19 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415213456.GE6669@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).