From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16099 invoked from network); 16 Apr 2021 17:13:41 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 16 Apr 2021 17:13:41 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618593221; b=TA84w0W7AjzDAF1h88iN7TZlAcCP+SKPB7GZcPuOs7S5+6EOL+Hxgsya9DnJYoTPKTeW+s9v9c XRFrXBY5p8jfguFhGQWp03P3fnrGeA7EoMlUqjRXY9AD512FutWFdncVgoPwx/Ctx0MGbgcWKq qqq6FrUvmmbSnlUUvQlhJxQjHWmokP/Qmnn21mT8u/jI8nKK2S+Ezu9debycVUkiIwT392SS3M 8VN9aVScyKoOOnWNQFzbFYJY+4lSGGYgN0B13/weYSxYFe/AiOkdbu0vcyCx7M83MB73wpqVpq 3PoWnm2Ha7BM825a2prCgArtE4+vtDcHixUPo/leMvcwNA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618593221; bh=vWGmAvQjBNUYihzcHa9enp+8BsUzmeLUErGen3hZ7m4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=SbsLha1z8Ijy8CipI5FiQOWb0TilZ5uw8b7UvbApZbpZarb5lsfdwq3qxen553nK9+xRHsBXg3 7OEL2s1zX2EyBaVztWjCMSuQwuvxULLDyyn1bLcJtAnoXgZ9PMIQ3hKZ410PddJ5r0bAKxwjZB /XICx/eXoC75xul8ZK7jnEkNAEaD0V+wAjLn+SL2leovv2vAVxILWubeltmdRIblBoAlJnpzQG u5vUrqSkuglVC1DVdCI0QKobtfWgNIQuBP+hZ1fiNi2x2pJk9FM05EbnBXGltP+BR6VNHG62+b I9flR1sYDMdyFAdDtYUdXTrt80XQjoeP9eoP3kBig5Zwnw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=VCePjTk3KHOM3pr0xRsQ073GH0uvU19I746G/U2J+ss=; b=zE+UOM2SAadGZ2gcLtaH2pFZbx u69nv90JlaO9cU4vu/AzfEZCRQaDEyZmj7totSjfFYxEJ7yJS7QcnuvQ2euaMOCwdB0BWNpdDDS3t ISO8jFz35EG+v5i8gB/tSaT/hA7HkU9mqCBIUDHi2tkZXQNToDiq8RnuVy5Ohpm+xA2y5ryyMfk2q kcOjYQ2aoqrvXxuvlkpK9hBl2xJ+kcS5Q4Kd6Q2vlrM830o6KiTc537iBsNbCmoYuVxZxAMYFfCkL VH+yboX5xKYz6jQMEpsdMHFB6kDbtdI2FHMHOFYytjaaDYveXAsusRNNYf9/dax6IhMrQ+yr1Rk6Q SjLSdeSQ==; Received: from authenticated user by zero.zsh.org with local id 1lXS2G-000AWB-Hr; Fri, 16 Apr 2021 17:13:40 +0000 Authentication-Results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44675) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lXS21-000AFt-HZ; Fri, 16 Apr 2021 17:13:26 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9C6955C00B0; Fri, 16 Apr 2021 13:13:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 16 Apr 2021 13:13:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=VCePjTk3KHOM3pr0xRsQ073GH0uvU19I746G/U2J +ss=; b=uB29f3RNl9VkelmMy4N6XTW/vYhcij+yaC2JVWOyVHa80P+c9tYQQ/0u 0o1ZLa/q12vLaUb2MDq1vDdo4ZoASbTXAWLxP0ly+mcYO77wB9EM7tVLtKq21nWo pkGgNSggXC5IvQKr9WiTyDwM1kkBCg07YAR/T6VzJUar95UrbIsQOqmrx6EiK9oL UeHVg0g/8KNSVwr7FBacTyfscVIxSGJQCMfNHZMiWzTwKkQnh8iaJCyjtjoQulMv JgFAaIsSNuMLhm1x5oBuN6TmXBUUx11uDJS2s/l9uy4uIdz5gt3UuXjooh6OfSmI SGqc+ZX1BwMoaHK3R9ctvmplHGD5Pw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VCePjTk3KHOM3pr0xRsQ073GH0uvU19I746G/U2J+ ss=; b=Lq5hYoiOIwDfMJXfBGQP6xPPvN0v9+rd5rAb011Wl/RGMnEyUTneDgBuc 9L87Rzsw92ChixQZer0typX8KDmf66H0VAyFu+O/v3sTWa7HqnrHZyC8Z9dPEzfT e8dmnmQ/KgH7z9IiKW+HBy4l0CB6nbKyoRQH77ns51DsEsZCvyQvJqJ5CSKhlFVk GUk+lCMwHTF156rbaL/b+hXdNWqfDBtsbyjoQB7wPhq1D/Y/JZx0hAFdysiDhU2H cBTg8d0NuV2ELnvQgZectpihCWCdRqgkW5zC6/P4VkJ43sPFoXAYS6lT1vJoApF+ dp7hozV140TyloSVDaHA34ZYXmXWA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelhedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjggfse htkedttddtreejnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggr nhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpefgkefgfeejgf dvvdfguddtleelkedvfeetiedtudfhveevveduhfdvveeffedvueenucfkphepuddtledr ieeirdeifedrvdeftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-63-230.red.bezeqint.net [109.66.63.230]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F7661080057; Fri, 16 Apr 2021 13:13:24 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4FMN8K5S4Rz2T2; Fri, 16 Apr 2021 17:13:21 +0000 (UTC) Date: Fri, 16 Apr 2021 17:13:21 +0000 From: Daniel Shahaf To: Marlon Cc: Zsh hackers list Subject: Re: [RFC][PATCH] `newuser` prompt theme Message-ID: <20210416171321.GC4535@tarpaulin.shahaf.local2> References: <7E71FA83-356E-448B-9726-02DF3FF5BD14@gmail.com> <873D08A9-F321-474A-8440-CCE7DCCBA529@gmail.com> <20210414120551.GA3882@tarpaulin.shahaf.local2> <6CEA4F3E-9A64-44E1-9121-FA9D5E053AB5@gmail.com> <20210414140909.GG3882@tarpaulin.shahaf.local2> <29E16F69-B09E-44BF-9009-1CF53053D4FC@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <29E16F69-B09E-44BF-9009-1CF53053D4FC@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48600 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Marlon wrote on Fri, Apr 16, 2021 at 19:04:06 +0300: > Question for Daniel: If you’re going to add sysexits(3) to PRINT_EXIT_VALUE anyway (workers/48564), should I just get rid of prompt_vcs_precmd()? Or do you think it still adds value? IMO keep that function. We can always simplify that function if and when sysexits(3) PRINT_EXIT_VALUE support is added. You seem to have sent the patch three times, nested. Which one should be reviewed? > From 172e2a886fcb499fd1f0712836721366dc66cb74 Mon Sep 17 00:00:00 2001 > From: Marlon Richert > Date: Thu, 15 Apr 2021 23:28:56 +0300 > Subject: [PATCH] Add customizable `vcs` prompt theme > > --- > 0001-Add-customizable-vcs-prompt-theme.patch | 499 +++++++++++++++++++ > Functions/Prompts/prompt_vcs_setup | 227 +++++++++ > > +++ b/0001-Add-customizable-vcs-prompt-theme.patch > @@ -0,0 +1,499 @@ > +From 1d557059a1ae35be86f17832526198abde8d949d Mon Sep 17 00:00:00 2001 > +From: Marlon Richert > +Date: Thu, 15 Apr 2021 23:28:56 +0300 > +Subject: [PATCH] Add customizable `vcs` prompt theme > + > +--- > + 0001-Add-customizable-vcs-prompt-theme.txt | 245 +++++++++++++++++++++ > + Functions/Prompts/prompt_vcs_setup | 227 +++++++++++++++++++ > + > +diff --git a/0001-Add-customizable-vcs-prompt-theme.txt b/0001-Add-customizable-vcs-prompt-theme.txt > +new file mode 100644 > +index 000000000..980f4a317 > +--- /dev/null > ++++ b/0001-Add-customizable-vcs-prompt-theme.txt > +@@ -0,0 +1,245 @@ > ++From 1d34a81c3b09228deaf9de599e42611ec4fe21dd Mon Sep 17 00:00:00 2001 > ++From: Marlon Richert > ++Date: Thu, 15 Apr 2021 23:28:56 +0300 > ++Subject: [PATCH] Add customizable `vcs` prompt theme > ++ > +++++ b/Functions/Prompts/prompt_vcs_setup > ++@@ -0,0 +1,226 @@ > ++++ b/Functions/Prompts/prompt_vcs_setup > +@@ -0,0 +1,227 @@ > +++ b/Functions/Prompts/prompt_vcs_setup > @@ -0,0 +1,227 @@