From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: zmathfunc: min, max, sum throw error if result equals 0
Date: Fri, 16 Apr 2021 18:26:04 +0000 [thread overview]
Message-ID: <20210416182604.GB15670@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7ZFbOJc16r6JX4Lr6uPdVRji_=RmY3WZVBK9GtXzxjPmA@mail.gmail.com>
Bart Schaefer wrote on Sun, Mar 07, 2021 at 18:25:00 -0800:
> On Sun, Mar 7, 2021 at 1:57 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > Bart Schaefer wrote on Sun, 07 Mar 2021 21:39 +00:00:
> > > zsh_math_func_min() {
> > > local result=$(( $1 ))
> >
> > Doesn't this still do multiple string-to-number conversions?
>
> I don't think so ... the $(( ... )) should turn $1 into a single
> number assigned to result. What are you thinking about?
When «$foo» appears inside «$((…))», it's expanded as a string that's
then parsed as math. The result of «$((…))» is then assigned to the
$result, which is eventually used as «(( result ))», where — because
${(t)result} is non-integer scalar — there will be another
string-to-integer conversion.
Sorry for the delay on this.
Daniel
next prev parent reply other threads:[~2021-04-16 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 16:37 Nikolaus Thiel
2021-03-07 17:17 ` Daniel Shahaf
2021-03-07 21:39 ` Bart Schaefer
2021-03-07 21:56 ` Daniel Shahaf
2021-03-08 2:25 ` Bart Schaefer
2021-04-16 18:26 ` Daniel Shahaf [this message]
2021-04-16 18:47 ` Bart Schaefer
2021-04-16 19:50 ` Daniel Shahaf
2021-04-16 20:05 ` Bart Schaefer
2021-04-16 20:08 ` Daniel Shahaf
2021-04-16 18:21 ` Daniel Shahaf
2021-05-16 14:54 ` Lawrence Velázquez
2021-05-18 2:02 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416182604.GB15670@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).