From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: dana <dana@dana.is>
Cc: Zsh hackers list <zsh-workers@zsh.org>, franciscodezuviria@gmail.com
Subject: Re: [BUG] getopts OPTIND
Date: Tue, 20 Apr 2021 21:31:04 +0000 [thread overview]
Message-ID: <20210420213104.GB1035@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <1EB88C27-FA4E-4B1F-AEBD-15C2FFC21F95@dana.is>
dana wrote on Sun, Apr 18, 2021 at 00:16:52 -0500:
> On 14 Apr 2021, at 08:08, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > Some more cases to test:
> > .
> > t 0
> > t 1 foo
> > t 1 -- foo
> > t 1 -b
> > .
> > where -b doesn't take an argument.
>
> `t 0` doesn't test anything, the loop is just skipped.
Yeah, but OPTIND still gets printed, so it does test *something*.
> `t 1 -b` tests the same thing as `t 1 -w`, but i guess it's confusing
> that i picked -a -w -e -r as the options; i've changed them to -a -b
> -c -d. I've also added the two foo ones you suggested, as well as just
> `t 1`. (All three behaved the same as other shells already)
*nod*
> +upon exit. (The tt(POSIX_BUILTINS) option disables this, and also changes
> +the way the value is calculated to match other shells). tt(OPTARG)
s/)./.)/
Cheers,
Daniel
> +++ b/Test/B10getopts.ztst
> @@ -96,3 +96,32 @@
> done
> 0:missing option-argument (quiet mode)
> >:,x
> +
> + # This function is written so it can be easily referenced against other shells
> + t() {
> + local o i=0 n=$1
> + shift
> + while [ $i -lt $n ]; do
> + i=$(( i + 1 ))
> + getopts a: o "$@" 2> /dev/null
> + done
> + printf '<%d>' "$OPTIND"
> + }
> + # Try all these the native way, then the POSIX_BUILTINS way
> + for 1 in no_posix_builtins posix_builtins; do (
> + setopt $1
> + print -rn - "$1: "
> + t 1
> + t 1 foo
> + t 1 -- foo
> + t 1 -a
> + t 1 -b
> + t 2 -a -b
> + t 4 -a -b -c -d -a
> + t 5 -a -b -c -a -b -c
> + t 5 -a -b -c -d -ax -a
> + print
> + ); done
> +0:OPTIND calculation with and without POSIX_BUILTINS (workers/42248)
> +>no_posix_builtins: <1><1><2><1><1><3><5><7><6>
> +>posix_builtins: <1><1><2><2><2><3><6><7><7>
>
>
next prev parent reply other threads:[~2021-04-20 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:22 Francisco de Zuviría Allende
2018-01-09 22:48 ` dana
2018-01-09 22:57 ` Bart Schaefer
2018-01-09 23:58 ` dana
2018-01-10 1:32 ` Francisco de Zuviría Allende
2018-01-10 9:05 ` Peter Stephenson
2021-04-13 23:28 ` dana
2021-04-14 13:04 ` [BUG] getopts OPTIND - yash's behaviour Daniel Shahaf
2021-04-14 13:08 ` [BUG] getopts OPTIND Daniel Shahaf
2021-04-18 5:16 ` dana
2021-04-20 21:31 ` Daniel Shahaf [this message]
2021-05-03 23:38 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420213104.GB1035@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=dana@dana.is \
--cc=franciscodezuviria@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).