From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 17129 invoked from network); 21 Apr 2021 20:02:19 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 21 Apr 2021 20:02:19 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1619035339; b=B55+J+DSM4y0XEAd+qOULy/OGV7pWlEgqeabzNZMAI2nnN63uN3C6aBEByZ7IM/u4JDl9X/a0t LMqu6IvgItB31sbSczefOwIQNSyeS3BgSR0WSVnq2A77wgFJStYDbpzILkNxKfttbiLGPGUt5z Sd+yq3bjYFx9WdfKPaviQSxCF7FleKWKwP1wCEy4t7YxFCLiefZUEwl649/11u3d6Bi956Dyx3 24qJctJmZSzAKrBh3CXbvxd0o1shwDEYK1FPRI7TdYtcgkXDHOFUFOqEuTH4OsgHjiwPlbY9d4 d2hVm5lksyqEIgzhOWnEQZKsiUfOTA/OOukSeZa2lcr+JQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1619035339; bh=oPtz53ElV+PSB1oX3LMUocaNYUtSmDf6z21/2Au1fy8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=w85n3SozOlx+wLw7MSblom+2pmhomoKOLQ0x/U3NQAmhvRKw/UPhRNeCaYACiuQBojaxE4bkBZ 7fD0c73dxg7ccbFCUJGIkZt+UckCx8mMFCMZfTTiILYXPeIZnbIv8tQFMnFqI1e2ouh0jnYtAl zo8D+RQX96PmfLu+XiIzKo04wD3vv3YTg7RqEmIRHHfmJGnCYhtfKigi0BZvJzo0e/bMMGwEDa LWjM7ltHbWsVhH8slb3LsfOoPNlQpzeIijrjPSE9fhi8fWfgUlErOND4BpWkxg/7T6NKKDC5w6 yZ7yPXB/tLGkQNsnjGhQIjDfCB731v1cYUSLt/+QtAZ5YA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=EYdelBqZg5c767HSIl34w8nf4Xz24AtwNH1MwEXg7AA=; b=LWhwpbs7xeZkwk+/gGODIeTA7P Z7flW9dN6QSgiCApi+0cVknoZvEGkij+yP0lygDWFb2H1CBIW9jUiBILFyDdDPvQMFc14S8R0n1UN jdqxbNgO+nEkiHRUkAqRzWAPq5jRc6aVZlXbYbZpHeWSLX8Vaj7OetSUUCGPkGjYtrLYp3q8SUuae 8xr76qaphbnWvs9ZBVR4UODeL9x/jHGPW9cS6WLi4THghNtfwfGMC/Q0PpW3EBwlqkYdSQQp0YOJZ AO8DWWIUaQWDqxJPOTutaAEf4Oa8IYrw74lkrDztKORNJPt4n+iyTaIPllAnp52WYdV+qiIVAAqS7 LXQcm5zw==; Received: from authenticated user by zero.zsh.org with local id 1lZJ3A-000P1Q-72; Wed, 21 Apr 2021 20:02:16 +0000 Authentication-Results: zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39361) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lZJ2t-000Ont-7e; Wed, 21 Apr 2021 20:02:00 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D189F5C00ED; Wed, 21 Apr 2021 16:01:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 21 Apr 2021 16:01:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=EYdelBqZg5c767HSIl34w8nf4Xz24AtwNH1MwEXg 7AA=; b=No6nzzJkK2AbxhH3Z4GlA51YFYfY3jOE/mkp3j/AZcpdACXU4uj6P5uI oKwKdRBTWC+qlGoxdrvT8fXZ2n2DbsmB8UniHEp82Euc98zRnuyjA98wI2GKnfAv y1vfxRVjeDYCjpWMlvSkRvWaHq9b0JrW07lMWgXZQaqd4Ijo+PwEJ4lN8YuIy3CX V4KMWR8WkJBRoDgTiIcxRgZZ5WUHx8jIvo9PjsVyClAPcTC99R5RIFXcLDmUv3+w eEQxOQMg3xbqG7UuWKbhaiSdY5HqyDPSbvAZIRjZNJFsHtvo4gn2YrhiXc4c1v2e 5LjgmcVdpOxcTgxYRsmuAk/EiPuKKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=EYdelBqZg5c767HSIl34w8nf4Xz24AtwNH1MwEXg7 AA=; b=tb+Q4QgECN2kfIt5pYiA+L1a77QrJpUUe9V9/qLP8UKNqUBu9P96aCeV0 TzlYFhuLF+8qrBNsQru47onGHH+VJ9OiPmd9x748BE0yTblWKOqrhVJh2fUEj5Yt cji//251XZF0M+aR+Kft1DHm5HU1SThCtdKckXsLf2VZWyxAZbrzicvzE4Ag6Kjc +nza2KBSggelOMnNTbCtdew4esJ6iKJO4MpGGoCC9a/vwX1jPCJLEO0oS6ymZtzs H2kMgSyGVp6pI82oxk4erOOnODmud4zYr8Q+Z4MgE2kWd6QiU4H9EWgfEKK5yzPV YEw468T90igRzaDjrfUZ/TayILmbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjfgesthektddttderjeenucfhrhhomhepffgr nhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg eqnecuggftrfgrthhtvghrnhephffghefghfdujedvfeehgfefiefftdehteegjeeigedv fefhkeeftdeufefhhfejnecuffhomhgrihhnpehgihhtqdhstghmrdgtohhmnecukfhppe dutdelrdeiiedrieefrddvfedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-63-230.red.bezeqint.net [109.66.63.230]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BC3C240057; Wed, 21 Apr 2021 16:01:57 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4FQWfW6x0dz1Y1; Wed, 21 Apr 2021 20:01:55 +0000 (UTC) Date: Wed, 21 Apr 2021 20:01:55 +0000 From: Daniel Shahaf To: Marlon Richert Cc: Zsh hackers list Subject: Re: [PATCH] Add -L to add-(zsh|zle)-hook[-widget] completion Message-ID: <20210421200155.GC21343@tarpaulin.shahaf.local2> References: <5D55AAA6-C100-4FBA-A1D5-3DCD7D965DC3@gmail.com> <20210420213601.GC1035@tarpaulin.shahaf.local2> <880D5B7E-6ABE-4325-BFAB-C3593612608B@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <880D5B7E-6ABE-4325-BFAB-C3593612608B@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48643 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Marlon Richert wrote on Wed, Apr 21, 2021 at 08:59:22 +0300: > On 21 Apr 2021, at 00:36, Daniel Shahaf wrote: > > > >> From 8b0221296db36c4d55d1b99577886f72afd76d3b Mon Sep 17 00:00:00 2001 > >> From: Marlon Richert > >> Date: Mon, 19 Apr 2021 20:24:36 +0300 > >> Subject: [PATCH] Add -L to add-(zsh|zle)-hook[-widget] completion > > > > The patch has already been merged, but still: > > > > Symbols names should be able to be grepped for, so please don't hide > > them behind glob patterns. > > Ah, you mean in the commit message? Fair enough. I was just trying to > keep the first line of the commit message to 50 characters or less, in > line with [Git’s > recommendations](https://book.git-scm.com/docs/git-commit#_discussion). We don't follow the 50-character convention too closely: % git log origin --pretty='%s <%aN>' | grep -v Shahaf | cut -d\< -f1 | cut -c51- | head -1000 > >(wc -l) > >(grep . | wc -l) > /dev/null 1000 503 % > But point taken; I will spell it out next time, if not in the first > line, then at least in an additional line. > Yeah, mentioning it in expanded form once is generally enough to make them greppable. Abbreviating further mentions is a separate question. It may be helpful in some cases, but not in every case. One should know when not to use a given hammer. Symbol names should also be mentioned greppably in ChangeLog, and abbreviating them in the first line may conflict with that, since the first line and the ChangeLog message are often similar. (My git-am(1) wrapper scripts use the first line as the ChangeLog message verbatim.) > In any case, Oliver did add the exact function names to Changelog: Indeed. If that hadn't been the case, I'd have edited ChangeLog to retroactively expand the acronym. Daniel (who's reminded of Heinlein's _Tunnel in the Sky_)