zsh-workers
 help / color / mirror / code / Atom feed
From: <zeurkous@volny.cz>
To: "Bart Schaefer" <schaefer@brasslantern.com>
Cc: <zsh-workers@zsh.org>
Subject: RE: revised patch: zshmisc(1) clarify non-successful exit statuses
Date: Fri, 23 Apr 2021 23:03:58 +0200	[thread overview]
Message-ID: <20210423230358.344B9302@volny.cz> (raw)
In-Reply-To: <CAH+w=7awHtbKTdeGpbcoqYjJKrPx8d3Rk-3h5==ssCydY-kSqg@mail.gmail.com>

"Bart Schaefer" <schaefer@brasslantern.com> wrote:
> On Fri, Apr 23, 2021 at 5:19 AM <zeurkous@volny.cz> wrote:
>>
>> vindex(path, use of)
>> Otherwise, the shell searches each element of tt($path) for a
>> -directory containing an executable file by that name. If the
>> -search is unsuccessful, the shell prints an error message and returns
>> -a nonzero exit status.
>> +directory containing an executable file by that name.
>
> I would leave this paragraph unchanged. It's not necessary to delete
> the reference to "a nonzero exit status" in order to later explain
> what the nonzero values are.

Heh, me reason was the exact opposite: it didn't seem necessary to
duplicate it.

>> +If execution fails: an error message is printed, and one of the
>> +following values is returned.
>
> I would move this along with the sitem list to the very end, to follow
> the paragraph about the command_not_found handler.
>
> Then change "If execution fails:" to "When there is no handler and
> execution fails,".

That opens up a question: what happens when execution fails inside the
handler?

>> +startsitem()
>> +sitem(127)
>> +The search was unsuccessful. The error message is
>> +`tt(command not found:) var(cmd)'.
>
> As Daniel mentioned, this should be
>
> sitem(127)(Your new text
> goes here)

Yeah, that's been noted :)

        --zeurkous.

-- 
Friggin' Machines!


  reply	other threads:[~2021-04-23 21:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 12:15 zeurkous
2021-04-13 15:52 ` Daniel Shahaf
2021-04-13 18:03   ` zeurkous
2021-04-14 11:03     ` Daniel Shahaf
2021-04-14 11:40       ` zeurkous
2021-04-23 12:18         ` revised " zeurkous
2021-04-23 16:07           ` Daniel Shahaf
2021-04-23 16:15             ` Daniel Shahaf
2021-04-23 20:25             ` zeurkous
2021-04-23 20:14           ` Lawrence Velázquez
2021-04-23 20:29             ` zeurkous
2021-04-23 20:39               ` Lawrence Velázquez
2021-04-23 20:57                 ` zeurkous
2021-04-23 20:51           ` Bart Schaefer
2021-04-23 21:03             ` zeurkous [this message]
2021-04-23 21:12               ` Bart Schaefer
2021-04-23 21:18                 ` zeurkous
2021-04-23 22:31                   ` Bart Schaefer
2021-04-26 16:25             ` zeurkous
2021-04-29 14:20               ` Daniel Shahaf
2021-05-09 19:04                 ` Lawrence Velázquez
2021-05-31  1:09                   ` Lawrence Velázquez
2021-05-31  4:09                     ` Bart Schaefer
2021-05-31  4:37                       ` Lawrence Velázquez
2021-06-30 17:51                     ` zeurkous
2021-06-30 22:12                       ` Lawrence Velázquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423230358.344B9302@volny.cz \
    --to=zeurkous@volny.cz \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).