From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22432 invoked from network); 18 May 2021 00:37:40 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 18 May 2021 00:37:40 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1621298260; b=eV3wn7J+P4XGu7ElIKwtUYyL82SLuPW6KJ6LWzmyYYxA15oPjqtoi+v2qgf6hHAL8BuKATwEM4 nMWT8GNooQ0q5+bM7PV8gIEO8XEwOgf3IZknRzaE4yvpF6Jkg489+ZwK3cr7oDYjIhgjYnMPX+ nv2hMzX59TtsNQVaWdaCqWQW8RxsTLgyz8MIxiXo9hfzmu4JkA9rUsBiR44CgRiuBYw3OQ4f7h zUAxcIMLHT5ynHWvhGrqBlCfTrpF4whEBz57Pb85bGsvKDH07p+64Au+Y7NlQ/u4vVGxaUoh3J KVAQ1iC2+jeCnn3/UDxnrPGhs9hu7uNlzYL90BvPYIFbxg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1621298260; bh=Pnzffx5+JPads3prVLdZaBkcBJIlQJpaxeK1mXYcUGI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=YMWteySSjD/Ce1PUa0WGU9JYGweoPF24eS7Gr9F3VW8D0FgroY1QYOd46GRkVO8KXlXTL7OA6A Bo1AcRtqgjr4RPHxe+KRJ0eZkwIeX15lqZvIMjAkXV9RqB1Agi8KL4Tqc+tpXhKdYblyBd/m+c 1dM8O0IBMrumnLBMnc1YkaFYkrUCELYpJ0drzhRxb9Dil5nDKRQJtbhtBYLXE9+lB4q+19GDct bHi6b5C+yC0t99Ah3OwTApN9P+kwOJViqNF+fTMO024tvof5tg99Jb1HrRke2UamjSuJaa0zLD O3u34Q/XH3M4ovzEpeOW0hinksdaauqDpw07idbxxYTGQA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=RtTYUj43hn9nU7pcJ6PwJGwffJTKrEZIr/FS+2IjXUw=; b=yuSJ2EVNSv2aZXr87BzUqzinUT LDCr1eTQlWzxivz4WOwEQo1kWscf23OBGj8f5c74cu674oTEEtkSpmiurhDi4Qg5wvB3c/ixFJ7T2 66VuO1IyKYcJtNEtOZm0MxiawDSrKbfDDhdcWizOKJvxPVg2gGDjWqe3AasD4H2iK8CaeO6rveduG BHinH/fEeuVztGSO1cjLDAIgAX5/QcUP6oAsY4dZw0m2NH5M03bURB7beQGORiAjQz+I29vIT3g5l LaOwW5oaEsdu/6eSUMeSga/C7aEjSQ4GfwCosdJTYOJ9QQKmAwKk3zWNR9mPinVQNImrCP3BSSO7v b29DYXFQ==; Received: from authenticated user by zero.zsh.org with local id 1linjw-000Dm7-D7; Tue, 18 May 2021 00:37:40 +0000 Authentication-Results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39157) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lindi-000CnV-5U; Tue, 18 May 2021 00:31:15 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0D9F35C00F4; Mon, 17 May 2021 20:31:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 17 May 2021 20:31:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:subject:message-id:references :mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=RtTYUj43hn9nU7pcJ6PwJGwffJTKrEZIr/FS+2Ij XUw=; b=RUNwYbJ2wXp8uDeNGrFTKmGj4Gk8Qu3dA6KHN0Bsa9EfsYsVflI9AQ3Q lWrjkgHZt5VwfIBq4eLPIVZDcBujNtP5DTnsZ6rVpzhX5MEyJGreJ1TCucsJZUyg vKqjBZMRmNLFKCr2HEJawGFT1lhJEXF5LzKAoRxwoZ7qBdwKmlF5cAHuyvRKGRX7 9w1lbbongh40z4oklaKCKqwOAbL2zSEvtgt5PZnliO4mEJnk6Zlgm6ZXTDrazDyH HmnelFO10YWLoKQG0zjQHN/QqEoxXXVlTFEkmQ53PxKPa0izhX2k7wPF26VoHKP8 sxsmGNTr/Fq1/fAo5bVQ+rvtef7V9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RtTYUj43hn9nU7pcJ6PwJGwffJTKrEZIr/FS+2IjX Uw=; b=N0khDPJ4crp461bfK4+UD8/23FBAuM6osN1+ln24l/vBWy3HgYrkfmDjX rx3Nl1qqiJdy/2g7Swfz/l+Kjaq8FZ0uxngmvdsxKzS5vi1wlNiwhLq/BUcC+T/K pQ4kKpetEB+02Ve+fTBLWeQsxpZ5y6QcBIU2hLRPlwHf6BQBX118RDenEG0TiExC OpRmrv2PJjqUu1VGbVfvVpfhPBmB/l/Q+rjC0p0ZIutB4JlzSZDdVsH+7md210Zp UVVS45iHX7CKcqGLcl6YFhuwcmGL0y8N7A5nFRmEiR9GnwlprY2t9s/3hh1hK++s S7Ms9jkoTmepVNhosLmaTUPhTJOcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeiiedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfelhedtffeuhf egueelfeffjeegtddtleehvddvueeihfevgfdvgffhvedvkeetnecukfhppeejledrudek fedrheehrdduieeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-183-55-166.red.bezeqint.net [79.183.55.166]) by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 17 May 2021 20:31:12 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4FkcPB3qXvz3QX; Tue, 18 May 2021 00:31:10 +0000 (UTC) Date: Tue, 18 May 2021 00:31:10 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: I've caught up on pending commits; how about you? Message-ID: <20210518003110.GA26555@tarpaulin.shahaf.local2> References: <88f30242-af89-433c-b763-4a15b72a498b@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48870 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Bart Schaefer wrote on Sat, May 15, 2021 at 17:40:28 -0700: > On Sat, May 15, 2021 at 4:22 PM Daniel Shahaf wrote: > > > > And there's the ctags patch that has been committed with some review > > points outstanding. A glance at _ctags in master shows that external > > command output is passed to _values' «spec» arguments unsanitized. > > I don't have access to the ctags variant that supports > --list-languages, but I presume you're referring to > > _values -s , languages $languages Yes. > The value of $languages comes from _ctags_languages which produces > only strings matching the sed pattern > [A-Za-z][A-Za-z0-9#_+]* > > What additional sanitation do you feel is needed? This was done in > response to your previous criticism of this point. None, sorry, this seems fine. I'd missed the sed, sorry. > As far as I can tell the only un-address review points are from > Oliver's workers/48296 Thanks. Daniel