zsh-workers
 help / color / mirror / Atom feed
* [PATCH] Fix [:IDENT:] vs posixidentifiers
@ 2020-12-17 15:08 Stephane Chazelas
  2021-02-07 15:50 ` Stephane Chazelas
  0 siblings, 1 reply; 17+ messages in thread
From: Stephane Chazelas @ 2020-12-17 15:08 UTC (permalink / raw)
  To: Zsh hackers list

$ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
no
$ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
yes

That should be the other way round.


From: Stephane Chazelas <stephane@chazelas.org>
Date: Thu, 17 Dec 2020 14:49:50 +0000
Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers

wcsitype(c, IIDENT) should return false for non-ASCII characters
when the POSIX_IDENTIFIERS option is on, not the other way round.
---
 Src/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Src/utils.c b/Src/utils.c
index 5151b89a8..2a8d677a7 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
     } else {
 	switch (itype) {
 	case IIDENT:
-	    if (!isset(POSIXIDENTIFIERS))
+	    if (isset(POSIXIDENTIFIERS))
 		return 0;
 	    return iswalnum(c);
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2020-12-17 15:08 [PATCH] Fix [:IDENT:] vs posixidentifiers Stephane Chazelas
@ 2021-02-07 15:50 ` Stephane Chazelas
  2021-02-07 20:24   ` Bart Schaefer
  2021-03-22 17:17   ` Stephane Chazelas
  0 siblings, 2 replies; 17+ messages in thread
From: Stephane Chazelas @ 2021-02-07 15:50 UTC (permalink / raw)
  To: Zsh hackers list

Ping. Anybody objecting to this?

2020-12-17 15:08:44 +0000, Stephane Chazelas:
> $ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
> no
> $ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
> yes
> 
> That should be the other way round.
> 
> 
> From: Stephane Chazelas <stephane@chazelas.org>
> Date: Thu, 17 Dec 2020 14:49:50 +0000
> Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers
> 
> wcsitype(c, IIDENT) should return false for non-ASCII characters
> when the POSIX_IDENTIFIERS option is on, not the other way round.
> ---
>  Src/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Src/utils.c b/Src/utils.c
> index 5151b89a8..2a8d677a7 100644
> --- a/Src/utils.c
> +++ b/Src/utils.c
> @@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
>      } else {
>  	switch (itype) {
>  	case IIDENT:
> -	    if (!isset(POSIXIDENTIFIERS))
> +	    if (isset(POSIXIDENTIFIERS))
>  		return 0;
>  	    return iswalnum(c);
>  
> -- 
> 2.29.2
> 


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-07 15:50 ` Stephane Chazelas
@ 2021-02-07 20:24   ` Bart Schaefer
  2021-02-08  5:53     ` Daniel Shahaf
  2021-03-22 17:17   ` Stephane Chazelas
  1 sibling, 1 reply; 17+ messages in thread
From: Bart Schaefer @ 2021-02-07 20:24 UTC (permalink / raw)
  To: Zsh hackers list

On Sun, Feb 7, 2021 at 7:50 AM Stephane Chazelas <stephane@chazelas.org> wrote:
>
> Ping. Anybody objecting to this?

Not I.  We're behind on merging several patches, I think.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-07 20:24   ` Bart Schaefer
@ 2021-02-08  5:53     ` Daniel Shahaf
  2021-02-08 20:51       ` Bart Schaefer
  0 siblings, 1 reply; 17+ messages in thread
From: Daniel Shahaf @ 2021-02-08  5:53 UTC (permalink / raw)
  To: zsh-workers

Bart Schaefer wrote on Sun, Feb 07, 2021 at 12:24:26 -0800:
> On Sun, Feb 7, 2021 at 7:50 AM Stephane Chazelas <stephane@chazelas.org> wrote:
> >
> > Ping. Anybody objecting to this?
> 
> Not I.  We're behind on merging several patches, I think.

Do we need a patch manager?

(See, for instance,
https://subversion.apache.org/docs/community-guide/roles#patch-manager;
tl;dr: someone who watches PATCH threads and pings them if they peter out
unresolved — neither accepted nor rejected.)


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-08  5:53     ` Daniel Shahaf
@ 2021-02-08 20:51       ` Bart Schaefer
  2021-02-09  9:11         ` Peter Stephenson
  0 siblings, 1 reply; 17+ messages in thread
From: Bart Schaefer @ 2021-02-08 20:51 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: zsh-workers

On Sun, Feb 7, 2021 at 9:54 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> tl;dr: someone who watches PATCH threads and pings them if they peter out
> unresolved — neither accepted nor rejected.)

That would be nice.  Peter/Oliver/I used to sort of tag-team that, but
we have all run out of time/attention for it.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-08 20:51       ` Bart Schaefer
@ 2021-02-09  9:11         ` Peter Stephenson
  0 siblings, 0 replies; 17+ messages in thread
From: Peter Stephenson @ 2021-02-09  9:11 UTC (permalink / raw)
  To: zsh-workers

> On 08 February 2021 at 20:51 Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sun, Feb 7, 2021 at 9:54 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > tl;dr: someone who watches PATCH threads and pings them if they peter out
> > unresolved — neither accepted nor rejected.)
> 
> That would be nice.  Peter/Oliver/I used to sort of tag-team that, but
> we have all run out of time/attention for it.

Yes, I think attention is mostly the thing in my case.  I do have the odd
5 minutes every now and then to apply and push patches if my brain has been
sufficiently lit up.

pws


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-07 15:50 ` Stephane Chazelas
  2021-02-07 20:24   ` Bart Schaefer
@ 2021-03-22 17:17   ` Stephane Chazelas
  2021-03-22 23:45     ` Lawrence Velázquez
  2021-03-23  5:34     ` [PATCH] Fix [:IDENT:] vs posixidentifiers dana
  1 sibling, 2 replies; 17+ messages in thread
From: Stephane Chazelas @ 2021-03-22 17:17 UTC (permalink / raw)
  To: Zsh hackers list

Ping again. Note that it's pretty straighforward, and I don't
expect anyone would object to it.

I also have a (much more involved and arguable) "limit" patch
from last year which might be on someone's review queue.

Maybe it would help to publish review queues on zsh.org (may as
flat list of workers/1234 lines for each reviewer), so patch
submitters can know whether or not the patch is being considered
but reviewer are overwhelmed or it simply fell through the cracks.

(in any case, I'm in no particular hurry for that (minor) bug to
be fixed).

Cheers,
Stephane

2021-02-07 15:50:13 +0000, Stephane Chazelas:
> Ping. Anybody objecting to this?
> 
> 2020-12-17 15:08:44 +0000, Stephane Chazelas:
> > $ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
> > no
> > $ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
> > yes
> > 
> > That should be the other way round.
> > 
> > 
> > From: Stephane Chazelas <stephane@chazelas.org>
> > Date: Thu, 17 Dec 2020 14:49:50 +0000
> > Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers
> > 
> > wcsitype(c, IIDENT) should return false for non-ASCII characters
> > when the POSIX_IDENTIFIERS option is on, not the other way round.
> > ---
> >  Src/utils.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Src/utils.c b/Src/utils.c
> > index 5151b89a8..2a8d677a7 100644
> > --- a/Src/utils.c
> > +++ b/Src/utils.c
> > @@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
> >      } else {
> >  	switch (itype) {
> >  	case IIDENT:
> > -	    if (!isset(POSIXIDENTIFIERS))
> > +	    if (isset(POSIXIDENTIFIERS))
> >  		return 0;
> >  	    return iswalnum(c);
> >  
> > -- 
> > 2.29.2
> > 
> 


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-03-22 17:17   ` Stephane Chazelas
@ 2021-03-22 23:45     ` Lawrence Velázquez
  2021-03-25  1:06       ` Daniel Shahaf
  2021-03-23  5:34     ` [PATCH] Fix [:IDENT:] vs posixidentifiers dana
  1 sibling, 1 reply; 17+ messages in thread
From: Lawrence Velázquez @ 2021-03-22 23:45 UTC (permalink / raw)
  To: Stephane Chazelas; +Cc: zsh-workers

Hi Stephane,

> On Mar 22, 2021, at 1:17 PM, Stephane Chazelas <stephane@chazelas.org> wrote:
> 
> Maybe it would help to publish review queues on zsh.org (may as
> flat list of workers/1234 lines for each reviewer), so patch
> submitters can know whether or not the patch is being considered
> but reviewer are overwhelmed or it simply fell through the cracks.

My apologies, as patch manager I should have brought this to the
list's attention, but I haven't worked back past mid-February yet.

vq

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-03-22 17:17   ` Stephane Chazelas
  2021-03-22 23:45     ` Lawrence Velázquez
@ 2021-03-23  5:34     ` dana
  1 sibling, 0 replies; 17+ messages in thread
From: dana @ 2021-03-23  5:34 UTC (permalink / raw)
  To: Stephane Chazelas; +Cc: Zsh hackers list

On 22 Mar 2021, at 12:17, Stephane Chazelas <stephane@chazelas.org> wrote:
> Ping again.

I've committed this. I also added a regression test and clarified the option's
effect on [:IDENT:] in the documentation. Sorry i've been so inattentive

dana



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-03-22 23:45     ` Lawrence Velázquez
@ 2021-03-25  1:06       ` Daniel Shahaf
  2021-03-28  1:48         ` Lawrence Velázquez
  0 siblings, 1 reply; 17+ messages in thread
From: Daniel Shahaf @ 2021-03-25  1:06 UTC (permalink / raw)
  To: Lawrence Velázquez; +Cc: Stephane Chazelas, zsh-workers

Lawrence Velázquez wrote on Mon, Mar 22, 2021 at 19:45:59 -0400:
> On Mar 22, 2021, at 1:17 PM, Stephane Chazelas <stephane@chazelas.org> wrote:
> > Maybe it would help to publish review queues on zsh.org (may as
> > flat list of workers/1234 lines for each reviewer), so patch
> > submitters can know whether or not the patch is being considered
> > but reviewer are overwhelmed or it simply fell through the cracks.

I'm not sure that'd help.  Once a task is listed on Alice's review
queue, Bob will be less likely to review it.  Also, other projects seem
to solve the same problem without such a mechanism.  I think it might be
more effective to document something like "If you don't get a response
after $N days, feel free to ping your patch" (for some concrete value of
$N).

> My apologies, as patch manager I should have brought this to the
> list's attention, but I haven't worked back past mid-February yet.

«~d '< 100d' ~b '^--- '» is my friend ☺

20Dec16,08:33 Roman Perepelitsa Re: [BUG]: zle-line-pre-redraw breaks vi-repeat-change
20Dec17,15:08 Stephane Chazelas [PATCH] Fix [:IDENT:] vs posixidentifiers
20Dec18,13:18 Mikael Magnusson  RFC PATCH: Sketch at :@ subscripting
20Dec23,23:47 Felipe Contreras  [PATCH] declarednull: felipec's approach
20Dec28,22:13 Felipe Contreras  [PATCH] declarednull: rename DECLARED to NULL
20Dec31,05:41 Felipe Contreras  [PATCH 1/3] src: fix build warnings
20Dec31,05:41 Felipe Contreras  [PATCH 2/3] autoconf: remove deprecated functions
20Dec31,05:41 Felipe Contreras  [PATCH 3/3] autoconf: prepare for 2.70
21Jan04,00:22 brian m. carlson  [PATCH v3 1/1] exec: run final pipeline command in a subshell in sh mode
21Jan12,22:42 Devin Hussey      [PATCH] Ignore EACCES when doing non-pure globbing
21Jan13,03:04 Devin Hussey      [PATCH] Allow globbing with unreadable parent directories
21Jan14,05:57 Bart Schaefer     NO_CASE_GLOB and unreadable directories (Episode VI: A New Hope)
21Jan14,06:04 Lawrence Velázque [PATCH] Fix some documentation typos
21Jan14,18:56 Bart Schaefer     Re: NO_CASE_GLOB and unreadable directories (Episode VI: A New Hope)
21Jan15,03:14 Peiyuan Song      [PATCH] Make zpty module work in the cygwin and msys2
21Jan15,04:29 Peiyuan Song      [PATCH v2] Make zpty module work in the cygwin and msys2
21Jan18,02:28 Peiyuan Song      [PATCH v3] Make zpty module work in the cygwin and msys2
21Jan18,05:43 Jun T             Re: [PATCH v3] Make zpty module work in the cygwin and msys2
21Jan19,08:44 Jun T             Re: [PATCH v3] Make zpty module work in the cygwin and msys2
21Jan25,00:15 Bart Schaefer     [PATCH] Tests for globbing below protected directories
21Jan25,08:16 Arseny Maslenniko [PATCH 1/2] promptinit: typo: RPOMPT -> RPROMPT
21Jan25,08:16 Arseny Maslenniko [PATCH 2/2] promptinit: Fix prompt cleanups
21Jan25,15:07 Peter Stephenson  Re: Bug report: Completion for dynamically named dirs fails when $SUFFIX is not empty
21Jan28,07:36 Jun T             [PATCH] _awk: support gawk ver. 5
21Jan28,09:40 Jacob Menke       Re: Possible issue with Completion/Unix/Type/_date_formats return value
21Jan28,10:42 Jun T             Re: Possible ZSH bug involving piping ls to less (MSYS2 & Cygwin)
21Jan29,19:35 Bart Schaefer     [PATCH] FAQ update for aliasing
21Jan31,21:12 Bart Schaefer     Re: print -C and terminators
21Feb01,16:13 Daniel Shahaf     Re: [PATCH] FAQ update for aliasing
21Feb02,22:17 Joshua Krusell    [PATCH] Improve error message from zparseopts -F
21Feb03,15:46 Joshua Krusell    [PATCH] Add leading '-' to zparseopts option parsing errors
21Feb05,05:53 Bart Schaefer     Re: NO_CASE_GLOB and unreadable directories (Episode VI: A New Hope)
21Feb05,23:01 Oliver Kiddle     PATCH: completions for nsenter and unshare
21Feb05,23:18 Oliver Kiddle     PATCH: complete BSD login classes and update for env
21Feb06,12:31 Daniel Shahaf     Re: NO_CASE_GLOB and unreadable directories (Episode VI: A New Hope)
21Feb07,00:45 Oliver Kiddle     PATCH: handle newer sort style in zstyle completion
21Feb07,01:08 Oliver Kiddle     PATCH: update option completion for newer FreeBSD
21Feb07,01:33 Oliver Kiddle     PATCH: update completions for openbsd 6.8
21Feb07,01:48 Oliver Kiddle     PATCH: update completions for procps 3.3.16
21Feb07,23:03 Oliver Kiddle     PATCH: update completions for DragonflyBSD
21Feb07,23:15 Oliver Kiddle     PATCH: update completions for NetBSD 9
21Feb10,19:07 Bart Schaefer     Re: Did something change about completion and xtrace ?

That's all mails in the last 100 days that have a line starting with
"--- " in the body of the message.  I'm not sure if that decodes
"Content-Transfer-Encoding: base64" before matching the regexp.
Timestamps are UTC.  I couldn't easily add X-Seq numbers to the output,
sorry.

Cheers,

Daniel


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-03-25  1:06       ` Daniel Shahaf
@ 2021-03-28  1:48         ` Lawrence Velázquez
  2021-03-29  6:30           ` Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers) Daniel Shahaf
  0 siblings, 1 reply; 17+ messages in thread
From: Lawrence Velázquez @ 2021-03-28  1:48 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: zsh-workers

On Wed, Mar 24, 2021, at 9:06 PM, Daniel Shahaf wrote:
> Lawrence Velázquez wrote on Mon, Mar 22, 2021 at 19:45:59 -0400:
> > My apologies, as patch manager I should have brought this to the
> > list's attention, but I haven't worked back past mid-February yet.
> 
> «~d '< 100d' ~b '^--- '» is my friend ☺
> 
> [...]
> 
> That's all mails in the last 100 days that have a line starting with
> "--- " in the body of the message.  I'm not sure if that decodes
> "Content-Transfer-Encoding: base64" before matching the regexp.
> Timestamps are UTC.  I couldn't easily add X-Seq numbers to the output,
> sorry.

Thanks! I worked back through December today and plan to do two or
three months' worth of backlog every weekend (after more recent
submissions, naturally).

vq


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers)
  2021-03-28  1:48         ` Lawrence Velázquez
@ 2021-03-29  6:30           ` Daniel Shahaf
  2021-03-29  6:35             ` Bart Schaefer
  0 siblings, 1 reply; 17+ messages in thread
From: Daniel Shahaf @ 2021-03-29  6:30 UTC (permalink / raw)
  To: Lawrence Velázquez; +Cc: zsh-workers

Lawrence Velázquez wrote on Sat, Mar 27, 2021 at 21:48:09 -0400:
> On Wed, Mar 24, 2021, at 9:06 PM, Daniel Shahaf wrote:
> > Lawrence Velázquez wrote on Mon, Mar 22, 2021 at 19:45:59 -0400:
> > > My apologies, as patch manager I should have brought this to the
> > > list's attention, but I haven't worked back past mid-February yet.
> > 
> > «~d '< 100d' ~b '^--- '» is my friend ☺
> > 
> > [...]
> > 
> > That's all mails in the last 100 days that have a line starting with
> > "--- " in the body of the message.  I'm not sure if that decodes
> > "Content-Transfer-Encoding: base64" before matching the regexp.
> > Timestamps are UTC.  I couldn't easily add X-Seq numbers to the output,
> > sorry.
> 
> Thanks! I worked back through December today and plan to do two or
> three months' worth of backlog every weekend (after more recent
> submissions, naturally).

Thanks a lot!  I didn't expect the new patch manager to go that far back
through the archives, but it's certainly useful and appreciated!

That does bring up the point of what to do with threads that peter out
without a review.  I suggest that they be added to Etc/BUGS.  WDYT?

Cheers,

Daniel


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers)
  2021-03-29  6:30           ` Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers) Daniel Shahaf
@ 2021-03-29  6:35             ` Bart Schaefer
  2021-03-29  7:26               ` Daniel Shahaf
  0 siblings, 1 reply; 17+ messages in thread
From: Bart Schaefer @ 2021-03-29  6:35 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: Lawrence Velázquez, Zsh hackers list

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On Sun, Mar 28, 2021, 11:30 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:

>
> That does bring up the point of what to do with threads that peter out
> without a review.  I suggest that they be added to Etc/BUGS.  WDYT?
>

Only if they actually are threads about bug fixes.  Proposed new features
or completion improvements, just as examples, don't belong in the BUGS file.

>

[-- Attachment #2: Type: text/html, Size: 891 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers)
  2021-03-29  6:35             ` Bart Schaefer
@ 2021-03-29  7:26               ` Daniel Shahaf
  2021-05-16 17:07                 ` Lawrence Velázquez
  0 siblings, 1 reply; 17+ messages in thread
From: Daniel Shahaf @ 2021-03-29  7:26 UTC (permalink / raw)
  To: Zsh hackers list; +Cc: Lawrence Velázquez

Bart Schaefer wrote on Sun, Mar 28, 2021 at 23:35:58 -0700:
> On Sun, Mar 28, 2021, 11:30 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> 
> >
> > That does bring up the point of what to do with threads that peter out
> > without a review.  I suggest that they be added to Etc/BUGS.  WDYT?
> >
> 
> Only if they actually are threads about bug fixes.  Proposed new features
> or completion improvements, just as examples, don't belong in the BUGS file.

Are you objecting just to the name of the file, or to recording them at
all?  I.e., would recording them in an Etc/PROPOSED-NEW-FEATURES-AND-COMPLETION-IMPROVEMENTS
file be better?

Personally, I think I'd prefer a single file here, to remove a decision
step from anyone updating or consuming these files, but I don't feel
strongly about this.

Cheers,

Daniel


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers)
  2021-03-29  7:26               ` Daniel Shahaf
@ 2021-05-16 17:07                 ` Lawrence Velázquez
  2021-05-16 18:24                   ` Bart Schaefer
  0 siblings, 1 reply; 17+ messages in thread
From: Lawrence Velázquez @ 2021-05-16 17:07 UTC (permalink / raw)
  To: zsh-workers

On Mon, Mar 29, 2021, at 3:26 AM, Daniel Shahaf wrote:
> Bart Schaefer wrote on Sun, Mar 28, 2021 at 23:35:58 -0700:
> > On Sun, Mar 28, 2021, 11:30 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 
> > >
> > > That does bring up the point of what to do with threads that peter out
> > > without a review.  I suggest that they be added to Etc/BUGS.  WDYT?
> > >
> > 
> > Only if they actually are threads about bug fixes.  Proposed new features
> > or completion improvements, just as examples, don't belong in the BUGS file.
> 
> Are you objecting just to the name of the file, or to recording them at
> all?  I.e., would recording them in an 
> Etc/PROPOSED-NEW-FEATURES-AND-COMPLETION-IMPROVEMENTS
> file be better?

Perhaps something like DISCUSSIONS?  OPEN-DISCUSSIONS?  SUBMISSIONS?
PROPOSALS?

(Reviving this because there are several discussions coming up on
their third reminders, so I'm thinking about submitting a patch to
list them in the repository somewhere.)

-- 
vq


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers)
  2021-05-16 17:07                 ` Lawrence Velázquez
@ 2021-05-16 18:24                   ` Bart Schaefer
  2021-05-18  0:38                     ` Daniel Shahaf
  0 siblings, 1 reply; 17+ messages in thread
From: Bart Schaefer @ 2021-05-16 18:24 UTC (permalink / raw)
  To: Lawrence Velázquez; +Cc: Zsh hackers list

On Sun, May 16, 2021 at 10:09 AM Lawrence Velázquez <larryv@zsh.org> wrote:
>
> (Reviving this because there are several discussions coming up on
> their third reminders, so I'm thinking about submitting a patch to
> list them in the repository somewhere.)

How about Etc/UNRESOLVED ?


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers)
  2021-05-16 18:24                   ` Bart Schaefer
@ 2021-05-18  0:38                     ` Daniel Shahaf
  0 siblings, 0 replies; 17+ messages in thread
From: Daniel Shahaf @ 2021-05-18  0:38 UTC (permalink / raw)
  To: zsh-workers

Bart Schaefer wrote on Sun, May 16, 2021 at 11:24:06 -0700:
> On Sun, May 16, 2021 at 10:09 AM Lawrence Velázquez <larryv@zsh.org> wrote:
> >
> > (Reviving this because there are several discussions coming up on
> > their third reminders, so I'm thinking about submitting a patch to
> > list them in the repository somewhere.)
> 
> How about Etc/UNRESOLVED ?

I'd be fine with letting whoever creates the file choose its name.

however, if we'd rather pick the bikeshed's colour collectively, then
perhaps Etc/PATCHES or Etc/SUBMISSIONS.


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-05-18  0:38 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 15:08 [PATCH] Fix [:IDENT:] vs posixidentifiers Stephane Chazelas
2021-02-07 15:50 ` Stephane Chazelas
2021-02-07 20:24   ` Bart Schaefer
2021-02-08  5:53     ` Daniel Shahaf
2021-02-08 20:51       ` Bart Schaefer
2021-02-09  9:11         ` Peter Stephenson
2021-03-22 17:17   ` Stephane Chazelas
2021-03-22 23:45     ` Lawrence Velázquez
2021-03-25  1:06       ` Daniel Shahaf
2021-03-28  1:48         ` Lawrence Velázquez
2021-03-29  6:30           ` Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers) Daniel Shahaf
2021-03-29  6:35             ` Bart Schaefer
2021-03-29  7:26               ` Daniel Shahaf
2021-05-16 17:07                 ` Lawrence Velázquez
2021-05-16 18:24                   ` Bart Schaefer
2021-05-18  0:38                     ` Daniel Shahaf
2021-03-23  5:34     ` [PATCH] Fix [:IDENT:] vs posixidentifiers dana

zsh-workers

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-workers

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-workers zsh-workers/ http://inbox.vuxu.org/zsh-workers \
		zsh-workers@zsh.org
	public-inbox-index zsh-workers

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git