From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh hackers list <zsh-workers@zsh.org>
Cc: "Lawrence Velázquez" <larryv@zsh.org>,
"Marlon Richert" <marlon.richert@gmail.com>
Subject: Re: [BUG] Weird _expand & _complete behavior for $parameters in "double quotes"
Date: Mon, 24 May 2021 20:19:58 +0000 [thread overview]
Message-ID: <20210524201958.GA5006@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7aYtQGMF-Vu5E6V57P-NkWgW7KkTzh30+g3ZuKzOCB4ow@mail.gmail.com>
Bart Schaefer wrote on Mon, May 24, 2021 at 13:13:04 -0700:
> On Sun, May 23, 2021 at 2:04 PM Lawrence Velázquez <larryv@zsh.org> wrote:
> >
> > On Tue, May 11, 2021, at 1:32 PM, Marlon Richert wrote:
> > > * 0001-_expand-_complete-parameters-in-double-quotes.txt
> >
> > Should this test case be committed?
>
> I would say "no". At best it would be an "xfail" test, but we don't
> yet know if the eventual non-error output will match what Marlon
> expected when he made up the test.
We could still do the following, though? Based on Marlon's patch, but
with expectations adjusted.
diff --git a/Test/Y01completion.ztst b/Test/Y01completion.ztst
index 882a0adc4..f507996f1 100644
--- a/Test/Y01completion.ztst
+++ b/Test/Y01completion.ztst
@@ -322,6 +322,14 @@ F:regression test workers/31611
>NO:{y}
>NO:{z}
+ comptesteval "typeset -a bar=({$'\\0'..$'\\C-?'})"
+ comptesteval 'typeset -A bat=( "$bar[@]" )'
+ comptesteval 'typeset bay="$bar"'
+ comptesteval 'unsetopt listambiguous'
+ comptest $': "$ba"\C-B\t\t' | fgrep line: | fgrep '\"\"\"'
+-Df: complete parameter in double quotes
+# When this test starts to pass, add proper expectations.
+
%clean
prev parent reply other threads:[~2021-05-24 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 10:24 Marlon Richert
2021-05-11 11:05 ` Bart Schaefer
2021-05-11 17:32 ` Marlon Richert
2021-05-11 19:40 ` Bart Schaefer
2021-05-12 6:43 ` Marlon Richert
2021-05-23 21:02 ` Lawrence Velázquez
2021-05-24 20:13 ` Bart Schaefer
2021-05-24 20:19 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524201958.GA5006@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=larryv@zsh.org \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).