From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11799 invoked from network); 29 May 2021 11:41:33 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 May 2021 11:41:33 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1622288493; b=0BuKVtMu3JqsUrfgaYkOn6p+HylCXltz8/Xt4URjkfg2np0x3u+CVi/4GyQQ1zuDqu7s2Nz9X/ G7zb2rHtow0x1NuaoE9CFC3uAdKWyM8d6RTTr85GSyc+dExUjO8YxAeUY8CvOJ4rHwS7tWFxny uvKl4sa36+EE5n0yAH2SKAhl30wuD2syCrzgt9dcYJn2u3/eHa4DcauPdvvVK4GH/fUu7gJpX5 CZ30+PS6+tyHkw1Qvlmg/kWF+ocMK37PUEPpoqB4h/S57DlQFt/ibGoYAmMmmxflIpWh7ni/Om /EinonFfI4jmTKUUbcsWU9SzZhuyj59xdMTJ5BW3X4Nh6Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout3-smtp.messagingengine.com) smtp.remote-ip=64.147.123.19; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1622288493; bh=QcgMP3GTEfZLv+IhiLZYube6szkrRxzMGsos+8dWcN8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=s7Z5rNeGHU6NcbJTC6x7YK8ijlIDr2FvsHV+uNuVby6I1nUbVbldRBWXrckKsljD1KFyMXy7Ed i4+UKjpC4ihGai95ppHq8EY2M3jugt7kc3PeQ0HIQE1qiIOyMk+fN7gKY7zvFXaRJPBv1vEtRO lM4WBxeXYFmZB0t3Mt2JjnJ1LhAMYWxSjCMT+br1MRxDpmCdtcnFm12rm06knEJzcnxmAUCDG6 KNTbcwDwNO3yKGlQIzL3y7gmpQMx6kHCHg6A10s6whyOP2PqmiF8N6Wp55vpu/dc3kgu6iZ5NM dmlmooJGOafLmtV4Ngf+SQIK76AoDgSyVhCZIAIdYJo4Ow==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=oENy+wHXBHoLPdbp/oJc5Ul3wWKaJH1hncrHuQoBJy8=; b=kYDyatqEDi7a15juMgu2RXq56d GFHZjVs7Y/ThpxVJPQDvQFngTnWj1esEmLoOouMZszfzY9nQzjot60smW0uJ1RuCYjH7rvEQhmIKv 1F1gByxLWZNWlLrC0+AVf5oSqS9IULNnySYGs7dB/haHvXOB9h/GJFsdYqF+jUG5T90q8lWji414f donO1G0ZlcTibzqmCHI76xaON0L4llSvJw2JWLZVbDN3KgC7+FRWxY+lOCHBaEomI8Ni9Ech249AR be88ZuS7lElY/tXyLyNohqgkXoAS5/YJSmPeiLMdfUQ7kFVavYSBO+r0xkn46gZGwR68Vn03zOaLa 0gPAGBYA==; Received: from authenticated user by zero.zsh.org with local id 1lmxLP-000Nxm-MD; Sat, 29 May 2021 11:41:31 +0000 Authentication-Results: zsh.org; iprev=pass (wout3-smtp.messagingengine.com) smtp.remote-ip=64.147.123.19; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:34307) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lmxL8-000Nhv-8b; Sat, 29 May 2021 11:41:15 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id ED6E3B05; Sat, 29 May 2021 07:41:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 29 May 2021 07:41:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=oENy+wHXBHoLPdbp/oJc5Ul3wWKaJH1hncrHuQoB Jy8=; b=TPS6bjmGHzjqML9Th0oSn4kLzIjLwoTui92dDxSUeg4v5vsCPukWTnN/ 1pthBGxFR+UJfQlc3ZTsqmfkUkRQ2ym2+eQIAoZGqqjLVkXgQDIjCtRBxtbJX3AU cGekj3lIk6vE9Y1tOM0b/uwd4xRxouSKdSVQTAN4EdjyY9T8jxo+XxpMQB6mO7ML n4W8LvLlQsgRnlJKNtuaiBlvluy6bumg1xeYQKxfCy6SAJuED+LWJDEwKon/ms6P DVknKe6QF7S/QoBRTsjh3T3l7erxt+Xt2qXHMgFDl5C6r20CT9HP0fiyx26xO9hA relBC1TeflCf7vxdiPIJYpU/QXmQRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=oENy+wHXBHoLPdbp/oJc5Ul3wWKaJH1hncrHuQoBJ y8=; b=Hb7Gu6GGFgMKhI0/yLWI+mJD5ghAcKYta+9s2vyIIOCwyrg/hBvxw0FTc b+dhVNxaJ1JUJOSWw4A9QCDySCwuXg/97/JOLk4ywtJs0ivFtQx1rubPndXFQZkL dQvNNsyMgnHo0STJQGipKUCi/T6IO4mAEGVe1Q0pdzQenv41ABhXTPjGUHbg5q4Y 7w/0D/GzPtlY50T7jELaXDuP/qbfxITyjZqZ49pOzF+rvBbSYS9QhQ+7au5oOO4I m4GaAadxfg0ElZ3+5/eheMX35wM0Z6FElQPQ4xBl6FH6Zx9rqXQ2x97zt09Si+Ni 0ptXoCHrhrKKeSzS6objalNatWg1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekledggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfelhedtffeuhf egueelfeffjeegtddtleehvddvueeihfevgfdvgffhvedvkeetnecukfhppeejledrudej ledruddrieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-179-1-69.red.bezeqint.net [79.179.1.69]) by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 May 2021 07:41:10 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4Fsfl81MqCz3MQ; Sat, 29 May 2021 11:41:08 +0000 (UTC) Date: Sat, 29 May 2021 11:41:08 +0000 From: Daniel Shahaf To: Akinori MUSHA Cc: zsh-workers@zsh.org Subject: Re: [PATCH] Set TMPSUFFIX=.zsh in edit-command-line Message-ID: <20210529114108.GA25290@tarpaulin.shahaf.local2> References: <92d2b09c-9559-7085-a521-29714e38f02c@iDaemons.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <92d2b09c-9559-7085-a521-29714e38f02c@iDaemons.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48949 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Akinori MUSHA wrote on Fri, May 28, 2021 at 22:35:08 +0900: > This patch makes the name of a temporary file to have a .zsh suffix so > that the invoked editor will know it's a zsh script. The .zsh suffix is > commonly recognized by editors like Emacs, Vim and VS Code. Thanks for the patch. Vim already sets the filetype correctly in this case, via the «au BufNewFile,BufRead zsh*,zlog* call s:StarSetf('zsh')» pattern match in $VIMRTUNETIME/filetype.vim. However, I suspect that pattern produces some false negatives too (e.g., it also matches in cases such as «vim =(ls)»), so I think this change would be an improvement even for Vim users. > It's so much easier to edit a command line in a proper editing mode than in > a plain text mode. Agreed. The patch looks good to me, but I haven't time to review or test it properly, so I'll defer to others on that. Thanks, Daniel