zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Remove redundancies from `git` completion
Date: Wed, 1 Sep 2021 13:56:46 +0000	[thread overview]
Message-ID: <20210901135646.GA27958@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com>

Marlon Richert wrote on Mon, Aug 30, 2021 at 14:17:17 +0300:
> In _git-show, remove calls to __git_commits and __git_tags.
>   Rationale: 'commits' and 'tags' are already added by __git_trees.
>   Adding them twice makes `zstyle ... tag-order` give unexpected
>   results.
> 

Complete example, please?

> In __git_recent_commits, remove the line that adds 'heads'.
>   Rationale: The completion for most subcommands already adds
>   'heads-local' and 'heads-remote'. Adding an additional 'heads' inside
>   __git_recent_commits results in heads being listed twice in two
>   separate groups.

Complete example, please?  Also, what about those subcommands that
*don't* already add heads-local and heads-remote?



  parent reply	other threads:[~2021-09-01 13:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 11:17 Marlon Richert
2021-08-30 11:41 ` Mikael Magnusson
2021-08-30 12:34   ` Marlon Richert
2021-08-30 12:42     ` Mikael Magnusson
2021-08-31  5:52       ` Marlon Richert
2021-09-01 14:03         ` Daniel Shahaf
2021-09-01 18:22           ` Bart Schaefer
2021-09-02  6:17             ` Marlon Richert
2021-09-02 20:51               ` Oliver Kiddle
2021-09-02 20:54                 ` Bart Schaefer
2021-09-02 21:17                   ` Oliver Kiddle
2021-09-01 13:56 ` Daniel Shahaf [this message]
2021-09-02  8:57   ` Marlon Richert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901135646.GA27958@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).