From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16947 invoked from network); 1 Sep 2021 13:57:19 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 Sep 2021 13:57:19 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1630504639; b=URyuaiF55VbPFnWVm1WYp9bkfUsZa3jSt/Ee3DXOX065sIfQhzKzq4LTlQagJwtmfyxy4Ilogk OD5u6bIYxvXW92TWr8Lge95JPMzQkvxFqIvPSXYwpMiDziPyNpGhsuBkQKLWLxeV8RERBJQ5pl 0bJzd3A3zDB1iZjPN4aOMNT0A3v1OomEv2VHG24uEplYlw6o6cowuAVBFrIznfkOa9EfkN3T5F PCEopuf2aKw9afIRqY8nGIAl1cRgxxu5Y3rHya4tGqOQLpV/4Dsmggho8aMCv33hKmbMk2+MO4 xtkbXV9h7jhObjowPfltcB4sIKTWcvVf3w7+2BpxfGWu3A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout4-smtp.messagingengine.com) smtp.remote-ip=64.147.123.20; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1630504639; bh=q4soOZUamJ8BIHduX1loL0vNOyIYeyQCsFL/lmtgilo=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=V8pIlSYYVfgAvGtKjsrWYtG25gycBz67jZe0KrD0o3qbF8EFgHw6Pa9RUzUhh7ePWI76vQc6z0 lG7podAw2gtK61Q4oL+cgMY9Mpd/Xk9dgosVMrxCz6q3hOZNSH0y1mwtAcEt3/5LlPm0R7Kcpr 1WynHw5aSowF7SuTyhEwTWhqV3HA+7R9L7ZXRaSHcHAgShEdbMCBShfbxxpXhuiHujrS1gkxE6 Eu2MUJpNXGnr745oSj1+YeCXCltgpzNk/uprXiOgNmEH3gkd39sfIB8MCtcOQntG0aexk2xUvW YJGpvVBiHgyxgNhDWOhWXHXtgFP6tYeIzjyanXPRGXKvnA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=ojnJVK+QttZTUl/88dMNnll/oz8UL7iJxWK4uinnkqs=; b=cm4WKnFClAxLmSBBSigHHurX3x eO9T8iY2F0Mz61jfYELKuyp8eR/cWRrtKgNCT+QnAY4LviuN7hzjE/xVpcK0NQSDcl6Uy8gSJQ+yT c+Oravzec8Fj1R0KuKcySQ6wNSHdL3UycFnF6Gkuy1kuEQu/UWCGLVyRebq/rSt+Ont86LDf7LMwg zNGJAj5HME0C3rUM5/g2Hgc7ma5A836e9M/ezwMMUDroVLCQwG890XZae+8GKR+AY4q4fb6E7HwmG PEKH7UidxfNUdGY4mCqGLJa8LsMYCtx6jG2jJDUqstJRf1JjzF3x7Qf6qBEcgNGdQDzpEJTShTDi8 YykK9YSQ==; Received: from authenticated user by zero.zsh.org with local id 1mLQjv-000HeU-9T; Wed, 01 Sep 2021 13:57:19 +0000 Authentication-Results: zsh.org; iprev=pass (wout4-smtp.messagingengine.com) smtp.remote-ip=64.147.123.20; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:37033) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1mLQjS-000HKH-BW; Wed, 01 Sep 2021 13:56:52 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 048E3320046F; Wed, 1 Sep 2021 09:56:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 01 Sep 2021 09:56:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=fm1; bh=ojn JVK+QttZTUl/88dMNnll/oz8UL7iJxWK4uinnkqs=; b=sXcjLa/NoXwDmDekWlU iDfG/1aMwkCWKItI6MrEPNVo+SrQYfeug0djq4G1+CMDj+JhD0w2POlU5jRkBjJl LB1OoUxqxtc7ACnKllmT9nhKxFdbZNEQrSbyucG0q9aXHa0lpskUkxxXTsGG76TD U7oWn1hDsAH1iKw8lUZ25kEW0jeyVRQnieh0bDE5yiLjfX3a/ri6YV+4O7uX9S66 a+87CYaCVz69zl7r71uzbF6J9qaN8UjRZULgvxpYipxw7u9Eyi6j6xUo9wF+4v6x E6Ox2pdersn41LGamnkit8ALo1bo/CN5BdtamKfV1cEA/MSRIbSdTCpaRMkKC6Gp 5ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ojnJVK +QttZTUl/88dMNnll/oz8UL7iJxWK4uinnkqs=; b=Ijg99NUA863SeSG6iFdc2n lxEfXL7zT95Q4TnPzDu2bOgpTu2y21lyd23ZH7mEGWvFceEAbNFD6njjUJ9CAQsc S+wiOAR5IuF4DRs+zw97dJUwg/cx6ZpTYbRAVIaDqYu0GYJTOOe0mL+cq2nuh01b 9jIDayDfg/ZMWeBzLZe9sySH1E97azCvAY0Q9zvUwcIlnn/AAWfKIZFzTV+XNko7 hmfAIWPei1kuhAPDJlFnnhMzEc1bKdx9C5q9f8qgQn8D0nyfz0do5Dw6cfdM3Alo lXkzo8s/NXuOz3UWzjeKhhayoMIhlQz8eytYbg901CPyxtx4d/sjU7K86zHKsIqg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvfedgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdttddttdervdenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhepueevkeefffeufeehfefhgefffedviedthedtgeeljeelvdei hfevjeefteegvdeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Sep 2021 09:56:47 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4H05Fp6by5z1Wn; Wed, 1 Sep 2021 13:56:46 +0000 (UTC) Date: Wed, 1 Sep 2021 13:56:46 +0000 From: Daniel Shahaf To: Marlon Richert Cc: Zsh hackers list Subject: Re: [PATCH] Remove redundancies from `git` completion Message-ID: <20210901135646.GA27958@tarpaulin.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 49347 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Marlon Richert wrote on Mon, Aug 30, 2021 at 14:17:17 +0300: > In _git-show, remove calls to __git_commits and __git_tags. > Rationale: 'commits' and 'tags' are already added by __git_trees. > Adding them twice makes `zstyle ... tag-order` give unexpected > results. > Complete example, please? > In __git_recent_commits, remove the line that adds 'heads'. > Rationale: The completion for most subcommands already adds > 'heads-local' and 'heads-remote'. Adding an additional 'heads' inside > __git_recent_commits results in heads being listed twice in two > separate groups. Complete example, please? Also, what about those subcommands that *don't* already add heads-local and heads-remote?