From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18442 invoked from network); 26 Nov 2021 08:10:39 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 26 Nov 2021 08:10:39 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1637914239; b=K5hjAsnxTRu/NyD+yIBCdMGMuso384Vcp+IM7iaXBHOWIP6FNMV37xXfuvu2cp7xNbSHCI4oEX V86KGjqilBsPjFxUtAr8HbgtRyQA8IDw0K5Gw/jhlaMbiQ4R8N8j9+qKMluuy/i2t0ouH5bE5y tLSfyvPuNiWf+c1CL/mElaFEkfsW8HPFW12tmR7iy5d6TZahsuIyF0bGRemluLLq3sJgFMxRe9 6E7NtEOaJ/KtNLlc8kOI3KTgoOjL/e4x0uFICUbNhfaSasK58lzuI6g+SnUUfdWs5io3/hlooG /jaE1zhuL6hD1iGjgJoVcQtW7up94bgfGcnaXH7cHATriw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout3-smtp.messagingengine.com) smtp.remote-ip=64.147.123.19; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1637914239; bh=0pPjr0KQMwBH1dmjx4lEcy9quy2/X1BJlLwxrLJIuyw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=JYRxG3ic+w0fsBWnOkWpoMnl7yVBZims1bqU02cJt5zz42FD7pIjQ8rv9PaLNeZa/zbo62luE9 h7E8mxcm7bEgdyuCUwCusCew7W4j3Z0gLq3mNKf+SFFNMoNHgq/uxsWNL248TBeX5vkFXXAYF6 +HilRN37DOx/M0/j2t/zr7gAtkd6uuVGr53YMcjHIp+MzDDRwwowx4N8H521L79Qe2pHutLAQu WzCdO0EuH14wFc6uhC+9NnUtQ2yLIT1JzLX12U3rVH1acHwIoSi5a1ODmzlTVRU9uYArxm9SCe 2pWn3d+bNVPHTwzqq6ogN6yG38mox+MPW533l3Q/MqusPA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=EP0siTP+HHtNi4ykmtqQpTCqUgjuT9FMYcP35U7/2dw=; b=kQ+AOYNTxa3HCwZl+9s8F3lDdP eII/KIZpxlWy6ToBAeagMBbWuXqboHcWh9EjRmNVdAIsuaAujDuvErcN36Epg+WUUN4ueZk21R5bX RlIk1ZQvl5WfNuhYsLes8TasXcQVCrEWehThXjLEUC8DMHjCRoXHUStW9wUAvq3U9KY9u05yDqO35 RfO+MhcIL9xzBYVznC3clghiFb5ys1SUShNRt6UUsTFC1hBJ3IkGXtYWJci2dUjz4DQQ7XPVXN8Q5 2miqZ+6zueUK98PxKT9bi8iMo7j0jNeWbepF+3/9TogDbrF5kYAPI0U2AiJj4BJrbjxkMa18rgeLw m9MoGz3w==; Received: from authenticated user by zero.zsh.org with local id 1mqWJb-000CHT-AK; Fri, 26 Nov 2021 08:10:39 +0000 Authentication-Results: zsh.org; iprev=pass (wout3-smtp.messagingengine.com) smtp.remote-ip=64.147.123.19; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:34799) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1mqWIW-000Bpv-1m; Fri, 26 Nov 2021 08:09:33 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5A991320102F; Fri, 26 Nov 2021 03:09:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 26 Nov 2021 03:09:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm2; bh=EP0siTP+HHtNi4ykmtqQpTCqUgjuT9FMYcP35U7/ 2dw=; b=MW7LH/kCFTX3nUpbb3wfyewK7QhacR5oSqmyah2r1LX91UQdU/rJa/fW h/EY0i/Ot2kq1zza5QJxczarYBmxaQ9A6eizX1PhZZbMJh1W5+jI5WSoH8HY9Fh3 CJlEyZPHo3b+C1Xg/85YMM6UqFiDPMhZEPKD40mXmYVjnOnDR8axX6T4NA4N1yH/ 7LYOv+MAVN56MKongTP6NO3V+vmY5baPougNbHUFBB60VNq6T7YyhfcCNl2C5+CC +OMMBfK0IQg/AjPYTsuNv10/F6p/ssO8kYR3BfYOiS6CZGMeHkL0QWDuGI4qpjp2 ieGeV+ojgVNPN+A3NhKzh90+10gJlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EP0siTP+HHtNi4ykmtqQpTCqUgjuT9FMYcP35U7/2 dw=; b=WSU8tfHTry6d6gsvzEwnc065OAUsQ+EtWs9ifLxhDroCNYnkPvmGnmnd3 ewanjjfjDKz/RC34zkpK18VVQNGJI86uyodXiep/gMcezeYnuExidmGXUEe6nqCw iVJkhgBBQhU9Dp9A5lYt+0oDxnKnGFUy3kllPPAklMVg6vHdwRB7lT/5tlv8MBem c9XkgItIYElhAmdr3vPWRycY19uXatYtUFK0Eg+nuz/kHr8Y0YtI3UO0o7ro+JB2 7s2ZRgK8VoASBfcFzWeeIMOV0fyc3XBDQeWhF8WGvwB7zm36ma74u0Mypeoif0Lv 5NJu0MeexvBQ0W5V9sGUm+P4Bz66g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedugdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkedttddtredunecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeevledugfdtteffheekledtiedvteevhedvjeegudduteev gfehffdtheejleffkeenucffohhmrghinhepghhnuhdrohhrghdpmhgvthgrtghprghnrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep ugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Nov 2021 03:09:29 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4J0nTM48hBz4yG; Fri, 26 Nov 2021 08:09:27 +0000 (UTC) Date: Fri, 26 Nov 2021 08:09:27 +0000 From: Daniel Shahaf To: Aleksandr Mezin Cc: zsh-workers@zsh.org Subject: RFC: Remove vcs_info backends cdv, svk, tla? (was: Re: [PATCH v5] vcs_info: choose backend by basedir) Message-ID: <20211126080927.GA15802@tarpaulin.shahaf.local2> References: <20210604061421.172899-1-mezin.alexander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210604061421.172899-1-mezin.alexander@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 49604 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Aleksandr Mezin wrote on Fri, Jun 04, 2021 at 12:14:21 +0600: > @@ -124,10 +129,59 @@ vcs_info () { > vcs_comm=() > VCS_INFO_get_cmd > - VCS_INFO_detect_${vcs} && (( found = 1 )) && break > + if VCS_INFO_detect_${vcs}; then > + # Most backends already set vcs_comm[basedir] to an absolute path > + # with symlinks resolved: > + # > + # * Backends using VCS_INFO_bydir_detect: > + # bzr, cdv, darcs, fossil, hg, mtn, p4, svn > + # > + # * cvs - custom logic, but uses :P too > + # > + # * git - $(git rev-parse --show-toplevel) resolves symlinks and > + # returns an absolute path > + # > + # * for tla (GNU Arch) I can't find any online documentation or > + # packages (seems to be dead) > + # There's https://savannah.gnu.org/projects/gnu-arch/. It says tla is "decommissioned" and hasn't had a release in 16 years. There's also , but it doesn't alter the bottom line. > + # * svk doesn't use :P modifier and returns the path as is from > + # the config file (as far as I understand) > + # Does anyone still use svk? It was a "distributed version control for Subversion" thing (https://metacpan.org/dist/SVK), but: - It hasn't had a release since 2010 - Its homepage redirects elsewhere - Its repository is 404 Not Found - I haven't seen any mention of it on svn's lists in years - The list of features at the top of its man page seems to be mostly features that git-svn and hgsubversion already take care of. "Working copy without .svn" _might_ be an exception, if they mean no text bases; but they could just mean "there's a single .${vcs} dir at the top directory, rather than foo/bar/.${vcs} inside every versioned foo/bar/ directory", in which case, that's not a selling point either nowadays. > Looking at the other backends, cdv hasn't had a release in 16 years, either. Every other backend seems to be active to one degree or another. > + # So I'm not sure whether to modify the backends or just resolve > + # the path here to be sure. VCS_INFO_get_data_* usually reads > + # vcs_comm[basedir] too. In particular, I'm not sure if it's safe to > + # resolve symlinks in vcs_comm[basedir] for svk. The cdv, svk, tla backends presumably have no remaining users; having them at all imposes extra costs on people making «vcs_info»-wide changes; and if we remove them, we can always recover them from history if they turn out to have users after all. So, shall we remove these three backends? Cheers, Daniel > + # Because most backends already do :P substitution, I expect all > + # the info needed to resolve the path to be cached in memory by the > + # OS (so it shouldn't cause performance issues). > + basedir_realpath="${vcs_comm[basedir]:P}"