From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16485 invoked from network); 1 Dec 2021 04:59:09 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 Dec 2021 04:59:09 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1638334749; b=hx7S4Jj0I2/eKZKdwXo5LvJZyxJ3bt1GsHiB9mJa896OL02hJGVDNqlzd1frHdBMa8f68VXz0b +hXrUHm7Dv4DxrT6AoR4htenO7DUvmedN2Mhtacow6sivbRhiir11udKNchfY5VaZGYdHNB2D0 6o8exB7NSLFl6E6GOKroInPUANViLbuiuRD5JS1J0tyR4kgA7MR0l6TNuVjhX9xIUvhXIKK/62 w+boAOx09Rd42Dv7lhprBpg/y/CLBFYyCWzXw9e9bww2JBTQPENTNXr42FgxFupH0TZSbqLi/g h/vzW3y8XRb6yZcHrVIB8elxWt54nNT1l6R9PjDgNcaNpg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1638334749; bh=EttqLrDWL90rOq969vkXNi5oZr+26dhOAWd5keNCkpg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=kwfrZBmaEAwwTJxGJl7h9RzvqEnB9ixvKApFNRnB5A3e70wYxuV/xUuxQK8ZJ3KS44HENOs4wl cg/bypK0uTLBLclzzqL/LT5q531ps3d/I4eNcz0MQ76KroSMFK0uyA7CIihZEOXHjpo32p0nfY GEfsMwtH3/wgYnoX9gxEbh3ZP6su8zalK1BI0WlER4GsC8IE+KAnq908D2SF0af+KSehqIojwt pAywni6OI5+eLF4DK244QC2j9ZfKb/+6J4s06ets/ctpdKu8NqM9VM3YgiHINQ7pu6pDRTQCgs piGpKuL5oG3VAJR8buuuxMntBJ78uZypAYmvx8ipYNZLdg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=/epCDnPPRV3xE9o4TT93Xoxl71OrYluBd134w1P3sto=; b=JWA1pYldGkXvgWaV5ZJNZveBPC E4qj+1I0Bubdi8XOhRtSra2N3m+Wmjk4u5rbEaMBvKN2IxCqzOhVtW9N2MS0J9GUcWlgQm/dlKAzR Nt7VMTC7InozrWG14y+FEquOJflvdR1peK0pWtVUaCbjvCPAaYBcEniSccbxHV7D277pyopBs6QGV rUJbG3LzknnTf3SXG2Li5XpgnZc/YZZZxu2r1EZORv+DJD/kcIGtr9RdCygNj8SdMnmQScQGRvpfF eAlGlsjqVxx0p5aEUjnurSG3QTHSGKPJcjkYss8JqexIWnX+cgaQyQOh+Uoi+0QGMVZrXts+197NL uUR9J9MA==; Received: from authenticated user by zero.zsh.org with local id 1msHi0-0005fe-Tj; Wed, 01 Dec 2021 04:59:08 +0000 Authentication-Results: zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out5-smtp.messagingengine.com ([66.111.4.29]:36551) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1msHhi-0005O4-Rp; Wed, 01 Dec 2021 04:58:51 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 250E95C01DA; Tue, 30 Nov 2021 23:58:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 30 Nov 2021 23:58:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm2; bh=/epCDnPPRV3xE9o4TT93Xoxl71OrYluBd134w1P3 sto=; b=f50PWgKi70i1dGr/PmH/rTlR/QBHydEwTwAV7Mmd8MfqtfiysyhFOTYp DkccDwtQXyPpOTdbJ87qm7y3ygdRcuZcLalGfB0n7fqQbNO7K0Cr8gVmhCvZlr1d 4QvkneoCwTqFnLakOdmZEnXie2XDO/9F5QF8kbbfx7IP9vdYZy1sm4JCb5eMohSL s1YOKGh9eQsd0py//adP8tjkfaDmUsqgVuG6Y30sgtzni0FXIhEOiTj4Te87p7Rt 1e4Cn3uKQkUUzE65/XzBRqgohD+z6vTfxlIaHcYzGRCbwVEH4Grjy4/1Et9qsXnB sg69xgrbvoihwDy+pUlSXyGhWdtk4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/epCDnPPRV3xE9o4TT93Xoxl71OrYluBd134w1P3s to=; b=mCufRKFbjUujoR3WF4p1onJZp43wCKvqgPDsP6/QLg+CcOF7lGHKhUz/O DO4lwxeTeLCuxMCAtueFPRljSTI+0zZJW0v02beRi3x9hMf/cDG7R33TbC2bTott 4k3yUgqx3YQM+8xi4A1VEU5Jbf1UKYddMTKPxAOp3hpZjHqYUJP8XguD2B1vGDjv Q7dsYfUUUoVALB59NYFr2ftDbTAdxT9DNnUGkC3Ka4iSLW1KUQCnBbTOAs43BdSc m3pz/U01GEFfQBx8YxqISbqUCJpdO3ws1f52k7LBg6aB+zoiAvHiFBQx0/AMGO3z F21JKYIsmrgQqJsUHbmmfh7EfOCrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddriedvgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjggfsehtke dttddtreejnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpefgkefgfeejgfdvvd fguddtleelkedvfeetiedtudfhveevveduhfdvveeffedvueenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrg hhrghfrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Nov 2021 23:58:49 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4J3n1200HDz55c; Wed, 1 Dec 2021 04:58:45 +0000 (UTC) Date: Wed, 1 Dec 2021 04:58:45 +0000 From: Daniel Shahaf To: Jun T Cc: zsh-workers@zsh.org Subject: Re: Cygwin/MSYS2: Trouble converting relative paths from / using :a or :A Message-ID: <20211201045845.GA26421@tarpaulin.shahaf.local2> References: <01fa01d7d7fa$33567960$9a036c20$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 49627 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Jun T wrote on Wed, Nov 17, 2021 at 18:39:12 +0900: > > > 2021/11/15 17:44、I wrote: > > > # When is it possible that the return value of zgetcwd() ends with '/' but is not > > # equal to just "/"? > > Now I think that the return value of zgetcwd() ('here') can end with '/' > only if strlen(here)==1, so we need not metafy 'here'. > Am I correct? > I don't know. > > + char *here = zgetcwd(); > > + if (here[strlen(here)-1] != '/') > > + *junkptr = zhtricat(metafy(here, -1, META_HEAPDUP), "/", *junkptr); > > + else > > + *junkptr = dyncat(here, *junkptr); > > The same code appears at lines 932 of hist.c, and line 4501 of subst.c. This isn't a new issue in your patch, but I'd like to ask it anyway: Can zgetcwd() return an empty string? If so, the expression in the condition will trigger undefined behaviour. Cheers, Daniel