From: Daniel Shahaf <d.s@daniel.shahaf.name> To: "Marc Cornellà" <hello@mcornella.com> Cc: zsh-workers@zsh.org Subject: Re: RPS* and RPROMPT* are no longer tied since zsh 5.0.6 Date: Wed, 1 Dec 2021 06:32:11 +0000 [thread overview] Message-ID: <20211201063211.GD26421@tarpaulin.shahaf.local2> (raw) In-Reply-To: <CACn48Nqckr7epujOdhK_3wT-jyCABPBk=mFJK=jEUVaGf0rQEg@mail.gmail.com> Marc Cornellà wrote on Wed, Nov 24, 2021 at 11:03:58 +0100: > doing some testing I've found that, when either RPS1 or RPROMPT are > unset (but not both), changes in one of them are not reflected in the > other. The same happens with RPS2 and RPROMPT2. > The same does not happen with PS* and PROMPT*. > > % zsh_test_versions 'RPS1=abcd; echo RPS1=$RPS1 RPROMPT=$RPROMPT' # > function in https://github.com/mcornella/dotfiles/blob/4bf802f6/functions#L78-L118 > 4.3.11: RPS1=abcd RPROMPT=abcd ⋮ > 5.0.5: RPS1=abcd RPROMPT=abcd > 5.0.6: RPS1=abcd RPROMPT= ⋮ > 5.8: RPS1=abcd RPROMPT= > master: RPS1=abcd RPROMPT= > Thanks. Bisects to 32337. (That post refers to another thread without identifying it. I think the referenced thread is 32158.) > I can work around that, but should this be considered a bug or is this intended? Looks like a bug to me. The two Param's share the param::u.data member, so once both are set changes to one are reflected in the other. However, they are both initialized with PM_UNSET. Presumably, setting either doesn't remove the PM_UNSET flag from the other, and then the presence of PM_UNSET causes the value not to be used, even though it's non-NULL. diff --git a/Test/D01prompt.ztst b/Test/D01prompt.ztst index 3fb27e620..6879e6fd1 100644 --- a/Test/D01prompt.ztst +++ b/Test/D01prompt.ztst @@ -257,3 +257,9 @@ ZTST_skip='Missing terminfo module or non-colour terminal' fi 0:Equivalence of terminal colour settings (background colour) + + (RPS1=foo; echo $RPS1 $RPROMPT) + (RPS2=bar; echo $RPS2 $RPROMPT2) +-fD:RPS1 and RPROMPT are aliases (regression from 5.0.6) (workers/49600) +>foo foo +>bar bar
prev parent reply other threads:[~2021-12-01 6:32 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-24 10:03 Marc Cornellà 2021-12-01 6:32 ` Daniel Shahaf [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211201063211.GD26421@tarpaulin.shahaf.local2 \ --to=d.s@daniel.shahaf.name \ --cc=hello@mcornella.com \ --cc=zsh-workers@zsh.org \ --subject='Re: RPS* and RPROMPT* are no longer tied since zsh 5.0.6' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).