From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8453 invoked from network); 8 Mar 2022 19:33:25 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 8 Mar 2022 19:33:25 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1646768005; b=nUEKsVcOa+gY3k3+BHpltJ6AIFjLG+QbdK5JNG9T4g2aqb7GWVm+/hesFnrMH/mJdVE+vqLwxw PE+1TswygI1pEHWwm8Z6clvrqIYihe+4dXDGHZeQ0H9aPgKknywTkQ+M0UweTAfYHxisc1xVMR G5legiU0bxnoDaoKvmFWea4VvJ8R1Fy+ycZTzUvCETXVGAAJKap98+20R0/d91hZ95ASx1ylIt K4mdxtWTNTTwjkxnr6r8fLyl/MNojpukca1DB1pcivh3GCaI84ThQO7ZTUlyoRquhnLxIJqxuR XnKa+VsNZMJXyKfJtesYw9oC9V2a6prIA8X9bAQEK9WYNw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lj1-f170.google.com) smtp.remote-ip=209.85.208.170; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1646768005; bh=kMD1JQdsGBL71nXhHBkwo5q/a1CLnLjp9VpSmmHT8zg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:Date:Subject:To:From:DKIM-Signature: DKIM-Signature; b=ZIC/e7rQy6RcbhSsOjYnu3FnNWgSFxliFfkyzTagX4itvFrfDw/LRnTakzLmeBxoXiVqRsF5UT Q0u0K3FdW+4sHNqulZZTAdWcUleoojZj9CyromzgrMxCYvdyeuFY4Rw5XwWocUf7p7IUzUBKdW S5tROXvpoIu/uMW2BlQqrWaduZzVxj+xNX1u49x1f4oTOlYwPnIo54J1T64zJe5jfl7dne+WXG 1MJgPFM27yDdqCHiF4gaAkHM6F0aotNv3kLcCyHwcl62k6QUAgaglxq8su3C3SQoG70RHbFzuE /u9IdbUPdYTpeVEoeDefKrjJBQbXdtnAhF2KMPAre3rjcA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:Date:Subject:To:From: Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=hKnjlhuGzFQHFYDW3/5k6Ei2VvwAi9cNeMBZdOM4kEM=; b=jFdHKXuxP/ZrKyJTnnwsubJMiv L5ShIre7W+1R6MyoYrVE1CKYmpIv9zlAfCH7cg+60LQMoQF5SqwL7nNF8OhEGQ+fQyUJFzR5I3S9g pQ+0FFMRfKHhmxqYM7zl+LrO/pd53PAbkbEnNHPq5Wk83UYA/ATV30RsVCwjxEI3mZEqVLufOflUA QxfFWiexPbtRgiqoVSZSLBDZ03xkM1ujpqsPC29cC6m0HNMccdZARw4kHztI4Xdc5hq65WWuk+xrW 4cGho6GpZiyStXdNcx+8/yfzC+dbeMiEmC+0i/m8IGCTjKCd20Y8mhlao3u0d/+P/R5MxErTRPrpp eE+509Kg==; Received: from authenticated user by zero.zsh.org with local id 1nRfaH-000NTw-2W; Tue, 08 Mar 2022 19:33:25 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lj1-f170.google.com) smtp.remote-ip=209.85.208.170; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lj1-f170.google.com ([209.85.208.170]:42678) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nRfZl-000N8S-23; Tue, 08 Mar 2022 19:32:53 +0000 Received: by mail-lj1-f170.google.com with SMTP id v28so22064ljv.9 for ; Tue, 08 Mar 2022 11:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=hKnjlhuGzFQHFYDW3/5k6Ei2VvwAi9cNeMBZdOM4kEM=; b=gmgC4uGreYEo+b/95XJ9UI7+x1rG9vMtWNj9/4QyxxlYiCCGIPywBt8rC/vPkHnYLD NIdXFhxxzdbB7FSA63D/UzCgE/oEbekyM6iLZE4bzwNE2Qc6gD9SIN62eAAlkTNqjuVQ 65xFcYQZL5uO7dokDskms04t3jQenB1huKyAkxE6PZgnHE91HRHpOVUzIMGjRoTo1EYL pxac3kLmIkIDhetxOIsNnanmBc1ML8kmfZOXyScyZXXVfzHX6Dss51rINLeuTCy8mv6n G9nX6CCczBSCfsL2d+BchLjRqfAdGSwQCAWG2rNy2lr6eBL0GiYO4duD8ivT5+Bz8wNJ jxOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=hKnjlhuGzFQHFYDW3/5k6Ei2VvwAi9cNeMBZdOM4kEM=; b=QHo+znCpvAM+0rFtWTKOJxzRES1fB6i/ORf3We7zPSTL+Jx/germzErUNvQ3VgtVhT DCHQG5FEXOkGssqDFHJBo7asVnMnDNAxQaZbXnrJqGgfTnD+ZGvXL2fBGGaXwQZ/cqaz IlOX+0thkQL+o0RNbGhkpmq4tS7He0Avd28Pz8xIi0KTJYch1h7rZ2N2PS9HtU43vrq5 vlcgFv0lRK6jE1WXeZaOqEFm5DB9SM2gXmo7N6Wz1VSJYIGeSJP1TKd6hUq1bppLxTe/ QTDryI69QP7LUgXSd0c+tml/Ho+nC7cD3NLo4dImjyBkP+dZ0PXV7rWoIF61GuBeC+wU VS+Q== X-Gm-Message-State: AOAM5333PuV58htlzTuAWCi3K9ikGQ5vC9gfn+TAYSdnR5ZokAjDJ2QK vBSt63fLnkX9vqzmkyMKh1hp4LCEPJw= X-Google-Smtp-Source: ABdhPJx3at6fYWQMwNDtUYD5F+DEzfdVneOdTLjUR66yAhUxMcl4brpWPSdi+0hJlG24cnTy8G3nVQ== X-Received: by 2002:a05:651c:1047:b0:247:f205:2911 with SMTP id x7-20020a05651c104700b00247f2052911mr2933102ljm.284.1646767972385; Tue, 08 Mar 2022 11:32:52 -0800 (PST) Received: from localhost.localdomain (h-212-85-88-110.A230.priv.bahnhof.se. [212.85.88.110]) by smtp.gmail.com with ESMTPSA id u17-20020a056512095100b0044381f00805sm3638530lft.139.2022.03.08.11.32.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Mar 2022 11:32:51 -0800 (PST) From: Mikael Magnusson To: zsh-workers@zsh.org Subject: PATCH: [RFC] crash with weird completer Date: Tue, 8 Mar 2022 20:32:46 +0100 Message-Id: <20220308193246.3204-1-mikachu@gmail.com> X-Mailer: git-send-email 2.15.1 X-Seq: 49814 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: minimal reproducer .zshrc: zstyle ':completion:*' completer _oldlist _complete setopt nolistambiguous autoload compinit; compinit compdef _foo foo;_foo() { compadd -Q -- stash@{{0,1}} } type "foo " and press tab twice, and it should crash. The patch prevents the crash but I have no further arguments that it's correct. Also without 'setopt nolistambiguous' we just get an additional { inserted for every tab press which also doesn't seem useful (not fixed by patch). (Apologies if I've sent this before, looking through local commits that could potentially be useful to send.) --- Src/Zle/compresult.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src/Zle/compresult.c b/Src/Zle/compresult.c index 8b5955819a..12585e3564 100644 --- a/Src/Zle/compresult.c +++ b/Src/Zle/compresult.c @@ -608,7 +608,7 @@ instmatch(Cmatch m, int *scs) r += l; ocs = zlemetacs; /* Re-insert the brace beginnings, if any. */ - if (brbeg) { + if (brbeg && m->brpl) { int pcs = zlemetacs; l = 0; -- 2.15.1