From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 10130 invoked from network); 13 Mar 2022 19:36:16 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Mar 2022 19:36:16 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1647200176; b=VJ0Si+Ib6ZUj0MsuLQj4RZvW7FIk8MsCYhuJxIeZRsF+DnTx0Qy9DcOkJxLzW7Cm4NOwuIYhTv huoDehVcoor5bdqaaMeDAVh4u2dtClOYgOWVgym/ny2NHwrTqWJ1AM5PEr0sm3apTKJmLVn8oe AtMNoj+p8PQGTEMXgtn4quy824ZHL9j8kV3S4UB+Y3vuGzOdoXq45bocXYpOo2l25gpaucqEgr 2KvFb4ywK9NnI/lxJ+kJTASpsoz6vW2hXzZHCqfqDNX9Kq446ZKKMNRGJf2WpUUzQOVrPNLANy ydb20Iwn6HU03C84+zosKwmEa3modo5nhiRitL2TZ6hVzw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (relay10.mail.gandi.net) smtp.remote-ip=217.70.178.230; dmarc=none header.from=chazelas.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1647200176; bh=0I8E7J9CMPeRDN7zBElRg8Y4UXLlYJnUC49JgKrMb/c=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature; b=lXZcf+HYPdU87v9D3pCP8TJE8fdjD/yFo3vN/w76U1WCsJJJl0x8Ccaxdqr8XUzD1wSkvnqyvA K48Wsan+HVjcSZ3ivPTCzSJ6AdAR1DjGXZ8XXWIk5lVmdWhxLehFLC+1d1Su3r+gYtthnH2LSW w3MxOpjj5d6QTGED9Y0Wb8fHoYzg4/LYP6y5JMe4ym1hSFJ76miNlWgoKTB3JGljfsKavo/dbN qE6nCNCFH7hhqYp4FQuMj5ahI4sUNTvJF0NmXD4aiaK1AWDG2h+/7mpjd6qe0WL3LNHIsXLlji OGcCllN/J+wh1x+cbcTHMp+J0BmGHnfm9peyFOxawrV7FA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=ciNjNHfDiqO7ieXowOnZsUz2K35FUBsAPc3fiA01dzo=; b=EuRKFlL+Nzvlpga1Oco6WlSeP1 eCKCjibh/HJfiJerQ1psGGNHUvWAkFNT0rahRnj44ZV18S6UzXar9hWpNgsVVEHT7uycA57lFDSvL SVJ73D64i3jB1yFWpzYhQnn3xiCInXbVoeqMFiSaXZ2k+9WZy6Q7HiPevAtqhCCAROsYZ8hF4BTLl me76rL5Yb72x6j1Dn4vRL5ewTnEpBr6jhm70qhGUKSLHG50uNMtPbPLdEQz8m0f7VdRdM22C+qtRZ Ws0yrDTEuX7ChjeSDxTzG9TS9xO8+Z+Dlmae0+/WVN4yX7lRiaVPiG8NjGmFm3Gd58F5gS5YK2Fi0 7Hki6c9A==; Received: from authenticated user by zero.zsh.org with local id 1nTU0m-000BX1-Fv; Sun, 13 Mar 2022 19:36:16 +0000 Authentication-Results: zsh.org; iprev=pass (relay10.mail.gandi.net) smtp.remote-ip=217.70.178.230; dmarc=none header.from=chazelas.org; arc=none Received: from relay10.mail.gandi.net ([217.70.178.230]:37953) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1nTU0U-000BBY-LD; Sun, 13 Mar 2022 19:35:59 +0000 Received: (Authenticated sender: stephane@chazelas.org) by mail.gandi.net (Postfix) with ESMTPSA id 25410240003; Sun, 13 Mar 2022 19:35:56 +0000 (UTC) Date: Sun, 13 Mar 2022 19:35:56 +0000 From: Stephane Chazelas To: Mikael Magnusson Cc: zsh-workers@zsh.org Subject: Re: PATCH: <<<: Document newline behavior and fix optimization Message-ID: <20220313193556.22svbwjus2ybfpva@chazelas.org> Mail-Followup-To: Mikael Magnusson , zsh-workers@zsh.org References: <20220308185832.27204-1-mikachu@gmail.com> <20220313185059.23ggfh5cchv5m7nw@chazelas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Seq: 49839 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: 2022-03-13 20:28:35 +0100, Mikael Magnusson: > On 3/13/22, Stephane Chazelas wrote: > > 2022-03-08 19:58:32 +0100, Mikael Magnusson: > >> The =(<< >> always did, make the behavior consistent, and document it. > > [...] > > > > The edit-command-line contrib widget may be relying on =(<< > not adding a newline character. > > The output from the editor is read with $() so I think it will cancel > out, either way. Just tested invoking it and pressing enter a bunch of > times, and was returned to an empty command line. [...] You're right sorry. I just came across the definition of that widget and saw that =(<<<...) in it which reminded me of this discussion. But I didn't look at it further. If anything, your change would improved it, as at the moment, it would likely launch a text editor on something that is not text as it wouldn't end in a newline. -- Stephane