help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] vcs_info hg mq: Extract patch subjects
Date: Fri, 1 Apr 2022 00:21:03 +0000	[thread overview]
Message-ID: <20220401002103.GI8765@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <7cb77ce1-77b3-439c-b85f-71faa3790a58@www.fastmail.com>

Lawrence Velázquez wrote on Thu, Mar 31, 2022 at 02:00:03 -0400:
> Hi Daniel,
> On Sat, Jan 29, 2022, at 11:15 AM, Daniel Shahaf wrote:
> > Use a NUL separator just in case someone's hg mq patch names include
> > literal spaces.  That means gen-applied-string hooks have to split their
> > arguments one way in the hg mq case and another way in every other case.
> > ---
> >  Doc/Zsh/contrib.yo                            | 18 +++++++++++-----
> >  .../VCS_Info/Backends/VCS_INFO_get_data_hg    | 21 +++++++++++++++++++
> >  README                                        |  7 +++++++
> >  3 files changed, 41 insertions(+), 5 deletions(-)
> Were you planning on pushing this?

I'm ambivalent, since it wasn't user-requested and makes the
gen-applied-string API inelegant (as explained in the log message).
Thanks for asking!  It has been on my todo list ever since it was
posted, so it's good to (UK)table it again.


(Life goal $((++N)): get C-style casts into the OED)
(Life goal $((++N)): get C++-style casts into the OED)

      reply	other threads:[~2022-04-01  0:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-29 16:15 [PATCH 1/3] vcs_info quilt: Pass the patches dir path to the gen-applied-string, gen-unapplied-string, and set-patch-format hooks Daniel Shahaf
2022-01-29 16:15 ` [PATCH 2/3] vcs_info hg mq: Don't include applied patches in the unapplied patches Daniel Shahaf
2022-01-29 16:15 ` [PATCH 3/3] vcs_info hg mq: Extract patch subjects Daniel Shahaf
2022-03-31  6:00   ` Lawrence Velázquez
2022-04-01  0:21     ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401002103.GI8765@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).