From: Axel Beckert <abe@deuxchevaux.org>
To: zsh-workers@zsh.org
Subject: [PATCH] Re: Test release: 5.8.1.2-test
Date: Tue, 12 Apr 2022 19:55:14 +0200 [thread overview]
Message-ID: <20220412175512.2p6yyi3t3awb6nkm@sym.noone.org> (raw)
In-Reply-To: <20220412090555.3biuqobxcbtfj4me@sym.noone.org>
[-- Attachment #1: Type: text/plain, Size: 3797 bytes --]
Hi,
On Tue, Apr 12, 2022 at 11:05:56AM +0200, Axel Beckert wrote:
> On Tue, Apr 12, 2022 at 03:30:28PM +0900, Jun T wrote:
> > diff --git a/Test/ztst.zsh b/Test/ztst.zsh
> > index 89fe69b5b..263573333 100755
> > --- a/Test/ztst.zsh
> > +++ b/Test/ztst.zsh
> > @@ -30,6 +30,7 @@ emulate -R zsh
> > [[ -n $LC_NUMERIC ]] && LC_NUMERIC=C
> > [[ -n $LC_MESSAGES ]] && LC_MESSAGES=C
> > [[ -n $LANG ]] && LANG=C
> > +export LANG
> >
> > # Don't propagate variables that are set by default in the shell.
> > typeset +x WORDCHARS
>
> Yay, this patch at least fixed the Gitlab runner builds! See
> https://salsa.debian.org/debian/zsh/-/pipelines/367955
>
> I will soon make another upload to the official build infrastructure
> on all architectures and will report back how it went.
Done now, looks good so far:
https://buildd.debian.org/status/package.php?p=zsh&suite=experimental
I though noticed one odd warning on STDERR when running the test suite
against the installed zsh-static binary in the log from
https://salsa.debian.org/debian/zsh/-/jobs/2665273:
872 **************************************
873 47 successful test scripts, 0 failures, 15 skipped
874 **************************************
875 run-testsuite-static FAIL stderr: (eval):7: permission denied: /file
^^^^^^^^^^^^^^^^^^^^^^^^
(run-testsuite-static is the script at
https://salsa.debian.org/debian/zsh/-/blob/debian/debian/tests/run-testsuite-static
— This script is meant to run the test suite against /bin/zsh-static,
i.e. to do as-installed-testing. We also skip all PCRE-related tests
as this doesn't seem to work with a really static zsh binary.)
The warning looks a lot as if in a _single_ case of e.g.
"$tst_dir/file" the variable $tst_dir is empty or undefined. And given
that "$tst_dir" only seems to appear in Test/V14system.ztst, it
probably must be in there somewhere. I can also reproduce this warning
with this command:
% zsh-static +Z -f Test/ztst.zsh Test/V14system.ztst
Test/V14system.ztst: starting.
(eval):7: permission denied: /file
Test/V14system.ztst: skipped (the zsh/system and zsh/zselect modules are not available)
And I think I found the issue:
3 %prep
4
5 if zmodload -s zsh/system && zmodload -s zsh/zselect; then
6 tst_dir=V14.tmp
7 mkdir -p -- $tst_dir
8 else
9 ZTST_unimplemented='the zsh/system and zsh/zselect modules are not available'
10 fi
11 : > $tst_dir/file # File on which to acquire flock.
So line 11 works fine of those modules are there. But if they aren't,
$tst_dir never gets set and this explains very well the odd error
message above.
The question is how to fix this properly. My suggestion would be to
move "tst_dir=V14.tmp" as well as "mkdir -p -- $tst_dir" out of the
conditional, something along these lines:
diff --git a/Test/V14system.ztst b/Test/V14system.ztst
index 100daab08..1e683b5b9 100644
--- a/Test/V14system.ztst
+++ b/Test/V14system.ztst
@@ -2,10 +2,9 @@
%prep
- if zmodload -s zsh/system && zmodload -s zsh/zselect; then
- tst_dir=V14.tmp
- mkdir -p -- $tst_dir
- else
+ tst_dir=V14.tmp
+ mkdir -p -- $tst_dir
+ if ! ( zmodload -s zsh/system && zmodload -s zsh/zselect ); then
ZTST_unimplemented='the zsh/system and zsh/zselect modules are not available'
fi
: > $tst_dir/file # File on which to acquire flock.
Kind regards, Axel
--
PGP: 2FF9CD59612616B5 /~\ Plain Text Ribbon Campaign, http://arc.pasp.de/
Mail: abe@deuxchevaux.org \ / Say No to HTML in E-Mail and Usenet
Mail+Jabber: abe@noone.org X
https://axel.beckert.ch/ / \ I love long mails: https://email.is-not-s.ms/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-12 17:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 20:07 dana
2022-04-09 20:18 ` Bart Schaefer
2022-04-10 20:07 ` Peter Stephenson
2022-04-12 9:16 ` Peter Stephenson
2022-04-10 20:21 ` Luna Jernberg
2022-04-11 0:32 ` Axel Beckert
2022-04-11 8:30 ` Axel Beckert
2022-04-11 19:54 ` Bart Schaefer
2022-04-12 2:39 ` Jun T
2022-04-12 3:58 ` Bart Schaefer
2022-04-12 6:30 ` Jun T
2022-04-12 7:17 ` Jun T
2022-04-12 9:05 ` Axel Beckert
2022-04-12 17:55 ` Axel Beckert [this message]
2022-04-12 18:40 ` [PATCH] " Axel Beckert
2022-04-13 1:17 ` [PATCH] " Jun T
2022-04-13 9:34 ` Axel Beckert
2022-04-11 10:44 ` Kamil Dudka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412175512.2p6yyi3t3awb6nkm@sym.noone.org \
--to=abe@deuxchevaux.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).