From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13887 invoked from network); 12 Apr 2022 17:55:36 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 12 Apr 2022 17:55:36 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1649786136; b=lIkUKCNNl0qUMe+5BrZ4TtUdsrB8K3SpIQi+b/GSqgK9o1taFswiNBSuBPgKviCIM1+L25YJob hnFuo8sDauj29jjCf52tJ8mAS8nIpEmvDzb5b0XlDcKefehwWAFYCT2PjQi3zoQoIOwwS+17lo Hui5sqdSZuxkBEJZSldqriCAHsyBHDgpOwOERjQQt9NIfKyrkZsx0yNIpQ/YlWwyrEfH+zxdaD BDeCjrbSYYKwoHabV6LRrA5sgCV/loBJI829IWss2FqHAJK0Mwyl1IrLgFKlnslhMALCaCPTaX 7KlGssxQQ7Sgb2IyQBkBDoCBIvio6aLErsEPNM+vmg+KKA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (sym.noone.org) smtp.remote-ip=178.63.92.236; dmarc=none header.from=deuxchevaux.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1649786136; bh=cxrGd3TXf3PG3HOYAmFzO6k65SkKqgh0XvZLy1FapzA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:DKIM-Signature; b=IrfRMS28S1TLaP08xwADhWi2C3Yj2GpMh2/kWyBD3y48anzEG7aYSsl5pZ/DO0Xlf0GfeoODp9 G5uRhVCcwnnlqm9YKvuD+ZXqdTe19swa3MyHETYbKAtnbaWNkqj9KmzmCgq/XdZR2HrWG9cPmN sLKhWgwyeNvSHcUJBY/rtznyphFXPWerK+C46Nmkrx01zonuSP8zd3q3LGV7YaHoABGk0UkNGb LF05gfNbtZCyz7gKGcdBSrxuLDEH19CQF3VJYvLr8kmjyT455R0f9pUHfOK8bFAj6X9n7GnjIY f5cKRNBH1bdb9Kfqyphs4BvT87O9O5od8JNLHJBLhFofeQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=AeoNnM1ZBVZCGzKI22mQ9kQeFRg7yidytBPm765aeyQ=; b=DsCKNQUhLYT09YGRA3RC0MpaAs Z3mAW0Txc8WaTfVZAm75pydDQONMxBTNKYSss7c5AH5VvnozP42E+tcRIX6j6xIqwx0v9kPRUlyCs K6dE7vKwJ4/Y4tN4vFfd3Dmuy0cwTyXhpnkV26kb8JenMW66UdmL4z1voIbUm1nsUYESGwUrwx88s BtfR45IL6XXPVe8hN6qK5tUKYcQU3Yf++GSs7XS9Lpg6cjj6dCkLDOYRuaKyaBBvNvnwg34LvDk+r XcAc0I+u8Z7r1+dLQBEXWXesLZjfdFe0xlNAzZsLI/QsA94BgmM761uJgpxrjnvsNGlwfL8fwyu7r 7ivHS8pA==; Received: from authenticated user by zero.zsh.org with local id 1neKjm-0001tu-Pb; Tue, 12 Apr 2022 17:55:34 +0000 Authentication-Results: zsh.org; iprev=pass (sym.noone.org) smtp.remote-ip=178.63.92.236; dmarc=none header.from=deuxchevaux.org; arc=none Received: from sym.noone.org ([178.63.92.236]:59320 helo=sym2.noone.org) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1neKjU-0001WA-PL; Tue, 12 Apr 2022 17:55:17 +0000 Received: by sym2.noone.org (Postfix, from userid 1000) id 4KdD031vb6zvjfn; Tue, 12 Apr 2022 19:55:15 +0200 (CEST) Date: Tue, 12 Apr 2022 19:55:14 +0200 From: Axel Beckert To: zsh-workers@zsh.org Subject: [PATCH] Re: Test release: 5.8.1.2-test Message-ID: <20220412175512.2p6yyi3t3awb6nkm@sym.noone.org> Mail-Followup-To: zsh-workers@zsh.org References: <92daf80d-aa83-497b-8ec5-a8543ea736da@www.fastmail.com> <20220411003256.3kiqz56kqyihtlch@sym.noone.org> <20220411083035.xnb4l2qby57i5axd@sym.noone.org> <1A406D89-E916-4D56-B063-10944F6A4A0B@kba.biglobe.ne.jp> <512131D7-079C-47AF-845A-7BFFAFE22DE9@kba.biglobe.ne.jp> <20220412090555.3biuqobxcbtfj4me@sym.noone.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ci3vtfjtjmuxy636" Content-Disposition: inline In-Reply-To: <20220412090555.3biuqobxcbtfj4me@sym.noone.org> X-Operating-System: Linux 4.9.0-18-amd64 X-Machine: sym2 x86_64 X-Editor: GNU Emacs 25.1.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAAAAAC3mUtaAAAABGdBTUEAALGPC/xhBQAAADh0RVh0U29mdHdhcmUAWFYgVmVyc2lvbiAzLjEwYSAgUmV2OiAxMi8yOS85NCAoUE5HIHBhdGNoIDEuMindFS5JAAACGElEQVQ4jXXQMU8UYRDG8f8shNjdDH4AbpfGDjAWlKiJiZ0ajL1aGCvsNCbGaCGG1koLaztaTYz6ATy+gOyehYmF3MxVxgg3FnDsHcTpJr/M+8w7Rf6nCsaVTTDqxbg9hoOXmw83H71+Eyfg4E1d7/Z2fG9rGkZbTQiu+K+3U/C+76lmkvAhJuDndnoAiftou4V84okAGclop4U/jYACZDTxrYWP0gkxVfAm/W//GLZpxIzwIN0Hn8dw0B+IWkZmQmRsj2HfhwokEklHfNCCiQCRgAR7YyhQVRVTCKCzP4Y5zBBE0t0zY3Q8oQaBqqAMlVEcgVQd9706zGirAFium8HXumlMIeMwqQCInju+2+uB6MRENupdpMt8pRlHZyuAW0F+Mb6XSIVqtxjD+iVmVqqystLEzFTGT92YqRaXpNT5eTVjeJhbALPnrTxLUZUKZsgxcNm64hAOYisT/xhF+oKTGU5RegtC3Rt6eEDi/QnIevdTx9Md2EMmYBRmCQR1026FCGQQJJExsRUqgkMGaWSbwYLnoO4T6VgpbQbdELPMBAHWWrhYrcxXnYgAsatPWygkFCBD4K62MAsOTqA6szYRPpsu6e6Y8mPiVrBMNuGIMrgwBUu4p2DgG1Ownu6hpuTv7hScefHAzAC/yRRw5U5pALMbJ4AUALvHSZhxgHPXTsHcdWD1GadAHr9avP+c0wCr7263Df8ASLwXWHWs+KIAAAAHdElNRQfYBQEBODPr Organization: DeuxChevaux.org -- The =?iso-8859-1?Q?Citr?= =?iso-8859-1?B?b+tu?= 2CV Database User-Agent: NeoMutt/20170113 (1.7.2) X-Seq: 50050 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --ci3vtfjtjmuxy636 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Apr 12, 2022 at 11:05:56AM +0200, Axel Beckert wrote: > On Tue, Apr 12, 2022 at 03:30:28PM +0900, Jun T wrote: > > diff --git a/Test/ztst.zsh b/Test/ztst.zsh > > index 89fe69b5b..263573333 100755 > > --- a/Test/ztst.zsh > > +++ b/Test/ztst.zsh > > @@ -30,6 +30,7 @@ emulate -R zsh > > [[ -n $LC_NUMERIC ]] && LC_NUMERIC=3DC > > [[ -n $LC_MESSAGES ]] && LC_MESSAGES=3DC > > [[ -n $LANG ]] && LANG=3DC > > +export LANG > > =20 > > # Don't propagate variables that are set by default in the shell. > > typeset +x WORDCHARS >=20 > Yay, this patch at least fixed the Gitlab runner builds! See > https://salsa.debian.org/debian/zsh/-/pipelines/367955 >=20 > I will soon make another upload to the official build infrastructure > on all architectures and will report back how it went. Done now, looks good so far: https://buildd.debian.org/status/package.php?p=3Dzsh&suite=3Dexperimental I though noticed one odd warning on STDERR when running the test suite against the installed zsh-static binary in the log from https://salsa.debian.org/debian/zsh/-/jobs/2665273: 872 ************************************** 873 47 successful test scripts, 0 failures, 15 skipped 874 ************************************** 875 run-testsuite-static FAIL stderr: (eval):7: permission denied: /file ^^^^^^^^^^^^^^^^^^^^^^^^ (run-testsuite-static is the script at https://salsa.debian.org/debian/zsh/-/blob/debian/debian/tests/run-testsuit= e-static =E2=80=94 This script is meant to run the test suite against /bin/zsh-stati= c, i.e. to do as-installed-testing. We also skip all PCRE-related tests as this doesn't seem to work with a really static zsh binary.) The warning looks a lot as if in a _single_ case of e.g. "$tst_dir/file" the variable $tst_dir is empty or undefined. And given that "$tst_dir" only seems to appear in Test/V14system.ztst, it probably must be in there somewhere. I can also reproduce this warning with this command: % zsh-static +Z -f Test/ztst.zsh Test/V14system.ztst Test/V14system.ztst: starting. (eval):7: permission denied: /file Test/V14system.ztst: skipped (the zsh/system and zsh/zselect modules are = not available) And I think I found the issue: 3 %prep 4 5 if zmodload -s zsh/system && zmodload -s zsh/zselect; then 6 tst_dir=3DV14.tmp 7 mkdir -p -- $tst_dir 8 else 9 ZTST_unimplemented=3D'the zsh/system and zsh/zselect modules ar= e not available' 10 fi 11 : > $tst_dir/file # File on which to acquire flock. So line 11 works fine of those modules are there. But if they aren't, $tst_dir never gets set and this explains very well the odd error message above. The question is how to fix this properly. My suggestion would be to move "tst_dir=3DV14.tmp" as well as "mkdir -p -- $tst_dir" out of the conditional, something along these lines: diff --git a/Test/V14system.ztst b/Test/V14system.ztst index 100daab08..1e683b5b9 100644 --- a/Test/V14system.ztst +++ b/Test/V14system.ztst @@ -2,10 +2,9 @@ =20 %prep =20 - if zmodload -s zsh/system && zmodload -s zsh/zselect; then - tst_dir=3DV14.tmp - mkdir -p -- $tst_dir - else + tst_dir=3DV14.tmp + mkdir -p -- $tst_dir + if ! ( zmodload -s zsh/system && zmodload -s zsh/zselect ); then ZTST_unimplemented=3D'the zsh/system and zsh/zselect modules are not a= vailable' fi : > $tst_dir/file # File on which to acquire flock. Kind regards, Axel --=20 PGP: 2FF9CD59612616B5 /~\ Plain Text Ribbon Campaign, http://arc.pasp= =2Ede/ Mail: abe@deuxchevaux.org \ / Say No to HTML in E-Mail and Usenet Mail+Jabber: abe@noone.org X https://axel.beckert.ch/ / \ I love long mails: https://email.is-not-s.m= s/ --ci3vtfjtjmuxy636 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEERoyJeTtCmBnp12Ema+Zjx1o1yXUFAmJVvPwACgkQa+Zjx1o1 yXV7yRAAlGFVI1CyWlpVi7eIAGsF4ua1A/W/q8u+McyXu7kM17Qv7OUIKrvsy2ne g5jkMs/LV9g2wtO3PVcbPFVfQlM21DP/ckJDdKFWbSHWFjBb88/rAqpurSYokA2u C0IGsQRgurcyLb5UmmWwpRv4zpK9Gm0Se4+9nsnlMAHdW+Je4F3M/fHjGY2Qn+p/ +3bw2XQ2HhRp4JFqBJENqrXa9kryRlVeA80JyG3bP9Gngn6Nj+2kASQkku2lY9S6 X0aCzMh1OIu0N77ub1l+bLfV1UAdS9fOdqWSzwA/5mCd/rzYtNSC2dgofQyRkN6u rbaXM9LETnY9gm9Zg9Po0aMHNsqManXND5TqUQAPja93CF+pErTaJ536nwSZkUo+ J7KwRPHEUnUcSa70J4h+58vv+Lw345uChFIdGtLdABlZByu2gsxX1/NTUpzLgda5 0kOJ0w1e6q9u7amsEmEV8pD3dMzP/3YYeDFdO84kyzjNc7nBIpzskanMrpyuvLo7 9l8P0gy7F12VsNYQMDMjmNw4xglU7qjYuYQGwx37kAcxav0V1wLszirNaNPbIwJm zVX0U8Pl/a/Y0wF6OOVcaJM1dDDoA7IjjzJM+wEnoM8OKsglmE99FeBZSwAKT2jD SWHOeaIAg+H0cXcJPYP+wmyfNo6ADLR82suv6bwSjVt/DL4bYyY= =s2X+ -----END PGP SIGNATURE----- --ci3vtfjtjmuxy636--