zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: A second test release before 5.9 final?
Date: Sun, 1 May 2022 17:38:58 +0000	[thread overview]
Message-ID: <20220501173858.GA31441@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7bby1GiKxTL9Y3M6Xuhe56EQdRHDsabbShfWNLkdkxhsg@mail.gmail.com>

Bart Schaefer wrote on Sun, May 01, 2022 at 09:50:14 -0700:
> On Sun, May 1, 2022 at 7:53 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > Bart Schaefer wrote on Sat, 30 Apr 2022 18:31 +00:00:
> > > I've gone ahead with pushing 50150, 50149, 50136, and 50134
> >
> > Looks like none of these have tests.  It would be great if someone could
> > contribute these — either you if you have time, or if you don't, just
> > say so and someone else can jump in.
> 
> I'd appreciate it if you wrote the zstat test for 50150.

Sure.

diff --git a/Test/D07multibyte.ztst b/Test/D07multibyte.ztst
index cbd802f23..3c2dc082b 100644
--- a/Test/D07multibyte.ztst
+++ b/Test/D07multibyte.ztst
@@ -627,3 +627,14 @@ F:support character sets outside the portable 7-bit range.
 0:locale gets restored when locale parameters go out of scope (regression test for 45772)
 >❯
 >❯
+
+  # Subshell for zmodload isolation
+  (
+    zmodload zsh/stat
+    touch 50150-é 50150-Ą
+    # Using +size solely in order to make it easier to write the expectations
+    zstat +size -nor -- 50150-*
+  )
+0:(workers/50150) zsh/stat with Unicode and metafication
+>50150-Ą 0
+>50150-é 0

> The tests for 50101, 50126, 50136, and 50149 should be
> straightforward, I'll work on those.

Thank you.

> I'm not sure how to write a test for 50134 because it requires
> starting an interactive shell, waiting several seconds, then sending
> it a SIGINT and discovering whether it exited immediately or N seconds
> later.

*nod*

Daniel


  reply	other threads:[~2022-05-01 17:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30 18:31 Bart Schaefer
2022-04-30 21:41 ` dana
2022-05-01 14:52 ` Daniel Shahaf
2022-05-01 16:50   ` Bart Schaefer
2022-05-01 17:38     ` Daniel Shahaf [this message]
2022-05-02  2:24       ` Jun T
2022-05-02  3:10         ` Bart Schaefer
2022-05-02  4:09           ` Jun T
2022-05-02 12:58           ` Daniel Shahaf
2022-05-01 17:49     ` Peter Stephenson
2022-05-01 18:09     ` [PATCH] Test for 50101 Bart Schaefer
2022-05-01 19:09     ` [PATCH] Tests for 50126, 50136, and 50149 Bart Schaefer
2022-05-02  4:59       ` Jun T
2022-05-02  5:15         ` Bart Schaefer
2022-05-02  5:46           ` Jun T
2022-05-02 13:14         ` Jun. T
2022-05-02 16:26           ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220501173858.GA31441@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).