From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18028 invoked from network); 31 Oct 2022 09:20:17 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 31 Oct 2022 09:20:17 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1667208017; b=SqnyUJFKccgrb/0Dnd9uabfkjCy0iD3bzE7tUl5/mYhupN37XtgLgYnWk3CysBnMh8htDr5zNO RCLVDgvO8nQmRDOhHdKhSeiio5PiKhPVvmUwlYcSo7YmtCM+u7/Ww4G8Qho/fDGPWVpxQEuftI 3gFCoa9nJeGjXXjML7BX3Oe3r+Gb1hJu9G+QAwdQaMu8XJbKCn5o0PnbjG6h3ervMSoNudnUFe QH176+KHDE478jnElX/0oRRra38AbGcT/5An0T7pcVZG8qPGZnAUf6H52DaiylT7or9/zArPnD 12Ecdh3eOiqfG5AFGd8lNa1tgtuMTDupyWycGNRBR6f4mQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout5-smtp.messagingengine.com) smtp.remote-ip=64.147.123.21; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1667208017; bh=cwpZK8rFGyqQ7A863Q2oyRckIktYzFND8KPQ+z25W5k=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=MtajSAqRygL6K/JrDCPuTyKKwJr7I0Dfjxs4zhLoM3vUkblgNMLNkWyxm99ynRdXE5H1qVl4W8 3PD5/LEknA1L2jU0DcdBLAG2hcM/m9J6TJlcCfD1Nz6AmWW7r5pXzvt4e7kKo2yleOOoard6qx sX1dHzbZaDFtsFS5KFDVP91IQC9trztCs+QijBF/n5OTLD09YgD2PtfCQ7g6qWPvJihXbpwjix diigxPerjFS6HiawD3qM/6s0JMly6FWvoHGh4BBeztJi+NdDTClMqMKQyb1mauDkxGAAMmCIEx lmRJDI71CryC3UrIdW7ZTUn2F3HFuqD9W8iH5/jXqVZ0KA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=ShcHUxToOCcs7AQI1sET3wKur+W4KX/9Qebu53RiBCY=; b=nI8bub/fBLDsvCTp7ynBtMEkvA p2kG680U2XQrgG2gsuI68ybpo2wGWZ0EaE9y7YTEgJrIT+zkgFzBcLqHRHVgrv7TyLnaeL/I8pzZl pZjNnmZFzEl1k8DYiepq5IPhqMjU3FOvdSLPx2DBSArdUdIFHAxE77aN8ify9YG3zYHOU/K0l3HoL bQiWq/i+k/SDWrgaQcbd5QxOSGfI9EJxYD+KYWenQQF9rSpecrVEgu6ZyFvDtYyGpSncBoEZVbRbO LzzXG25DLH/dhzt5FtKBlAp5qrZFMyBwA+/WWdgz6ugpzi7cRaUf60HZ8ZAS4pfNi873YihXTQHgZ VXI8MDNA==; Received: by zero.zsh.org with local id 1opQxt-000Ctq-E2; Mon, 31 Oct 2022 09:20:17 +0000 Authentication-Results: zsh.org; iprev=pass (wout5-smtp.messagingengine.com) smtp.remote-ip=64.147.123.21; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:44327) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1opQxH-000CWu-J8; Mon, 31 Oct 2022 09:19:41 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DEB1C3200943; Mon, 31 Oct 2022 05:19:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 31 Oct 2022 05:19:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1667207975; x=1667294375; bh=ShcHUxToOC cs7AQI1sET3wKur+W4KX/9Qebu53RiBCY=; b=OM1XQDUMf6DoFiGFhuKwdflyob Id5/3yeiG6iCui4XzwUEG38Z/x9wjZAuRy6NK5Ln9IqW6G+ZrKOtSEekKLLtfPzk d4brgAKNLOS9enC88RQE6fUl+vKwHBuNXRv5vyCM3LwnGOJfjTa2Z9LKkry4Pxb7 GA0IOPkGyHCizSUl9dDieQI4JtSHiFZh2dK+WOFDMZ+WxeYS9dgez9cd60JM5LDQ jQNJ5qHkjBIiu9B1XpDjp43ylhmLm32tjw6WuXRJ9vLcS+11vJMZ2DXnu+KsHFrC wTmk5EePTBXNZmGw5djpsMKgrNaDtUGt4RSigeJp5oxZGS3BcZ5gWINHc7Sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667207975; x= 1667294375; bh=ShcHUxToOCcs7AQI1sET3wKur+W4KX/9Qebu53RiBCY=; b=e qcW79v2YTJfywdGmYCviXYmqZGkPVHIVNb0FTjXGsZBSkffEsZEOFSJxGSRZacQB UUtzM7+J6gmfpjeZpF5zritSteNi7xSClXZMWpLdanb/kGUF3pNHDytpNpmLJhUS 7l74HqGqdEthYUfPB5jZySrw9TjAfxW/mGFE8CwOrd5L16wHrovENbsYFSOvtQ/o g03zhLxJcxcpz6IWkYMnVF7iVK/jWsKB9e6EGOclMZ3uYV0kTANHBy9Lwyli/0ZV F+VZDnzEFvkctCjtJvwt7Q0YvCjTUf3bUqLwK5ix4GNQyrcfofmaaIdsGD1k2wLi smN40kkDvk3KZNpTLTi5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtugfgjggfsehtkedttddtreejnecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeeiffeiteegtdeikeeffedutdeijeeuleetffejjeetjedv leetlefhfeefvdetjeenucffohhmrghinhepghhithhhuhgsrdgtohhmpdiishhhrdhnoh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhs segurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Feedback-ID: i425e4195:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Oct 2022 05:19:35 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4N16zn24K3z3BB; Mon, 31 Oct 2022 09:19:33 +0000 (UTC) Date: Mon, 31 Oct 2022 09:19:33 +0000 From: Daniel Shahaf To: Peter Grayson Cc: zsh-workers@zsh.org Subject: Re: [PATCH] Remove _stgit completion script Message-ID: <20221031091933.GE27622@tarpaulin.shahaf.local2> References: <20221025204319.1709205-1-pete@jpgrayson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221025204319.1709205-1-pete@jpgrayson.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 50853 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Peter Grayson wrote on Tue, Oct 25, 2022 at 16:43:21 -0400: > The StGit project ships its own zsh completion script which is more > complete and up-to-date than those shipped with zsh. > > https://github.com/stacked-git/stgit/blob/master/completion/stgit.zsh > + I see that completion script gets updated in lockstep with stg(1)'s argv parser. + Given the two projects' release schedules it seems safe to assume that by zsh's next release stg 2.0 will have been released as well, so most users won't end up in a situation where they have neither _stgit nor stgit.zsh. + No objections in a week. - _stgit and stgit.zsh are licenced differently. Being licenced under the same terms as zsh itself seems to be outweighed by not being regularly updated. So, I've pushed this. The last version is of course still available in our version control history. > Also, the _stgit completions that ship with zsh, which dynamically parse > StGit's help output, will be broken by the upcoming StGit 2.0 release > due to changes in the help output. > StGit is also used by vcs_info, here: https://github.com/zsh-users/zsh/blob/b76dcecfe3461aa9a9e29dffe2484f097611f9ff/Functions/VCS_Info/Backends/VCS_INFO_get_data_git#L187-L194 (There doesn't seem to be StGit-specific code elsewhere in the file or in the sibling file VCS_INFO_detect_git.) Any chance that someone who uses both StGit and zsh could review that? That code is supposed to populate $gitmisc (and thus the %m expando) with information about pushed and not-yet-pushed patches. To test that: [[[ autoload vcs_info precmd() { vcs_info } zstyle ':vcs_info:*' formats %m zstyle ':vcs_info:*' actionformats %m ]]] > Signed-off-by: Peter Grayson > --- > > N.B. I am the StGit maintainer and primary author of StGit's zsh > completion script. > Welcome :-) Cheers, Daniel > Completion/Unix/Command/_stgit | 52 ---------------------------------- > 1 file changed, 52 deletions(-) > delete mode 100644 Completion/Unix/Command/_stgit > > diff --git a/Completion/Unix/Command/_stgit b/Completion/Unix/Command/_stgit > deleted file mode 100644 > index e31af460a..000000000 > --- a/Completion/Unix/Command/_stgit > +++ /dev/null > @@ -1,52 +0,0 @@ > -#compdef stg ⋮ > -return ret