From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15655 invoked from network); 14 Nov 2022 13:21:34 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 14 Nov 2022 13:21:34 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1668432094; b=K2/lGiFwr6WhDBTxq2+RtFATmY/SIUODjC8Ph2G4pBm1E+ZfLhyvjTyjI/u4nUPQrhxtZBxiAy 9RM+p7+oE2sQ8MTR/QpuIkKCKHj/RzgkoPv2FFAok4hhnu2y+XYjdJW/Mb5FPseQ6dPWcX0SZO DjV2w7BxhgnZZrUnpwnmmVjpXuwIp/Kb7agsBUkjRtXi4LLUAEK3jLu3likk8C8kv/lXhcvjJ1 F34Y9y82Hy1caSW56PUps89cGoUstNjqzfQsvqCby04ZX6TNFpsl20EPnKiBQWmTG8K7rLnmAZ DasRnVKLKLw+afPtq+mQqHM8p7tZjjd+QgaH0qA5zy8MaA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1668432094; bh=r1lyjvoDP0t98XWRI2aiJd4xj7PFAPRb4G9Iz0g+vdU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=jMSG3tCh4hVA14KTqLCQHoLQDoT9XXHY8qu6Qo2RGH4NpdK/thmzGD6ukmgVegkY7OrE3RZr3O 4MKPiuiy200vGJpbldD2q7WQhXS25aLuOfTdyO3307teXrO6ZPTsU9Cfn7qWDit0h+FcGX0GGu qa7bufjT511HIwOPzS7cf0MVjsPUVXbDMTf4V3kLkEjkel/MsyI6rnds7cQIoc/o+aIcEJHmno G222vfLO1S91l3S++xCjtGfKCnXy8QEyqLMixroc4ldI03lBWhkAWZqazuiZlzfvnn/tei4aZf /6IKCPjYmbo5dVVqruMDArYb7IZzwfHcZpeYUpUrc6+32g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=EJqx6HZGOhkhw6+53hlidbdxRN+zESUK9ChEn6SgPLE=; b=nYRBfdvMobsa1kXmM5/2YWq9qB R7Ipps1q/8IMx5Vh2nqYSCD55QWEPjIas+C+TyLMpiAUyykZgWJp8Gigvb2s4VTtqbrtNUubZNFzd LkDYqAjyt8Dvi8QbKoi6RJQO4NqVbE5WVe7LS/fczE/5oiYRufpWTHZt9MqugfnXXbrR1w+qcd831 DItkfEQDc7nL7rujx3GOiE93+sloIDqp4IArAjNspV4HQY4rcRB9XU6upnnWN5pJ8Fg/blKWXlNsX WKftDq2gWj1LCETZDCBaJlFFqHT7jO8uEO4W2rMSDiF5s3yvLyrUDKskkSeVWz5I7ZBrC57iElRId lTpSWx/g==; Received: by zero.zsh.org with local id 1ouZP3-000Ni3-JZ; Mon, 14 Nov 2022 13:21:33 +0000 Authentication-Results: zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out5-smtp.messagingengine.com ([66.111.4.29]:50357) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1ouZOj-000NLx-HR; Mon, 14 Nov 2022 13:21:14 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CC0225C0039; Mon, 14 Nov 2022 08:21:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 14 Nov 2022 08:21:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1668432072; x=1668518472; bh=EJqx6HZGOh khw6+53hlidbdxRN+zESUK9ChEn6SgPLE=; b=WyXFeP6gLnccijI/cEQRzvMPPx yiQef3slPqVhOqa6qIYbxM+4VOBJWhvSW53Zf154PmjLH3IWeTvrcpgdFA/dNPXi hqVsZyABgDY50HrP+Ir7IbadLdQqv/9GYypQFRZJDxeJ8Lu3YRVfky1fRneViKUX iHHgDJVo1upAS1E0kKmxNefAP0+E/3Bf0UF37pbuiQbVCBRawYEnAYKVPqyp7Iii liExF6htg/Ftf5HAOMFVc81EIuvsVIvrjdgJllVLOGxTFTpOuPpgfffNAzcw98iG nye/M05e5CwSMwojhwR+A692I3qjdef/9AJr0dvuQF5lrSjFhGZFecTV6cpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668432072; x= 1668518472; bh=EJqx6HZGOhkhw6+53hlidbdxRN+zESUK9ChEn6SgPLE=; b=U SgLcyD1GyYCREWclPLHMAKDhmlaWSOcmwstLkVPjKsgmyWa5BpixGSH/Fk2JYTBw dJ9iqoTI59v0JJzQVf1qshS5yCptxq/e0cf0TcrWL7hCfVbVugz+mpy3svT7R9zP 1tCHmtV1CLm53o6zQ9FANGltXCvYm99jJ572FQEUDDHBBuTtdFpsF3yQSW+fddZb qcsAKM1tPrI8uo3kquaqBa8hiutal+/Uz2ZzEE0dk+PiZ3rzQdj+IjnVRuQSQXtW btrV/6b1PhZYDNkksMKmLKVCtt5PMWn2e1ImzI5NyTwCi37WWubxGSysD9KG5mbU 170y4JBRdPc8h0KocWBbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedvgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtugfgjggfsehtkedttddtredunecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeefhfeiuedthefgtedufeeviedtgedtjeekgfdvudfggfdt udehgefgjeduteefueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Feedback-ID: i425e4195:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 08:21:12 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4N9qh640V1z2Kc; Mon, 14 Nov 2022 13:21:10 +0000 (UTC) Date: Mon, 14 Nov 2022 13:21:10 +0000 From: Daniel Shahaf To: Mikael Magnusson Cc: Peter Grayson , zsh-workers@zsh.org Subject: Re: [PATCH] Remove StGit patch detection from vcs_info Message-ID: <20221114132110.GB31023@tarpaulin.shahaf.local2> References: <20221101030429.38029-1-pete@jpgrayson.net> <20221111114928.GF27622@tarpaulin.shahaf.local2> <603fd1b9-1b11-4729-99cb-19e1c4ef8b37@app.fastmail.com> <20221113043040.GG27622@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 50965 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Mikael Magnusson wrote on Mon, Nov 14, 2022 at 06:17:02 +0100: > On 11/14/22, Peter Grayson wrote: > > On Sat, Nov 12, 2022, at 11:30 PM, Daniel Shahaf wrote: > >> Peter Grayson wrote on Sat, Nov 12, 2022 at 09:46:02 -0500: > >>> On Fri, Nov 11, 2022, at 6:49 AM, Daniel Shahaf wrote: > >>> > [re #2]: It sounds like StGit 2.x support can be implemented at the > >>> > cost > >>> > of one fork(2) for those who don't use StGit and under a microsecond > >>> > for > >>> > those who do. That doesn't sound like a deal breaker at all. > >>> > >>> Running `stg series` with StGit 2.0 takes about 12ms in my environment. > >>> StGit 1.5 it is about 32ms. Not a microsecond, but perhaps acceptable > >>> nonetheless. > >>> > >> > >> To be clear, are these figures the duration of the «stg series > >> --noprefix --applied» invocation? > > > > Yes. > > > >> What's the impact on people who don't have stg(1) installed, or who have > >> stg(1) installed but are currently in a worktree that doesn't use StGit? > >> I.e., are those figures immediately after `git init`, or in a worktree > >> that has a StGit patch stack, or? > > > > Without stg(1) installed, the cost would be however long it takes zsh to > > determine that the executable is not available in $path, which is > > ostensibly very fast (microseconds?). > > > > If stg(1) is installed, but run in a repo with a branch that has not been > > initialized with `stg init`, it's still about 12ms. Almost all that time > > is taken just to initialize a libgit2 Repository structure, which is > > used to interrogate the object database to determine whether a StGit > > stack is initialized. > > fwiw, vcs_info lets you configure which vcs systems it looks for, > whether or not you have them installed. eg, I use: > zstyle ':vcs_info:*:*' enable git hg svn Right, but this just determines whether VCS_INFO_get_data_(git|hg|svn) may ever run at all. The situation we're talking about is that someone has «git» in the «enable» style but doesn't use StGit, so would want VCS_INFO_get_data_git to (1) run, but (2) not look for StGit patch stacks. There's no way to selectively disable just that one «elif» in the middle of VCS_INFO_get_data_git. > although these days i could surely set that to just git...