zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Cc: "Philippe Altherr" <philippe.altherr@gmail.com>,
	"Lawrence Velázquez" <larryv@zsh.org>
Subject: Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements)
Date: Wed, 23 Nov 2022 20:57:15 +0000	[thread overview]
Message-ID: <20221123205715.GQ27622@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7Z3diJrB4eACHuneKr1wFuqfA2pTm+M6PmsAytgH4oKMw@mail.gmail.com>

Bart Schaefer wrote on Wed, Nov 23, 2022 at 08:11:02 -0800:
> On Wed, Nov 23, 2022 at 1:44 AM Philippe Altherr
> <philippe.altherr@gmail.com> wrote:
> >> I'd also prefer to post all your patches at once because you attached
> >> them all to the same zsh-workers article.  Convention has been that a
> >> series of patches should be sent as a series of articles.

I don't think we should insist on this.

If someone has git-send-email(1) configured, sure, please send the
patches individually, and let email threading do its thing.  But if not…
I'd rather ask people to send one message with N attachments, numbered
as Philippe did in workers/51001, than ask people to send N separate
mails, in which case they might send nothing at all.

Besides, I'd like to enourage submitters to split their patches if in
doubt, since it's easier to combine patches ("42 + 43: foo") than to
split them ("42 (in part): foo").  So, I'd like to make it easier to
send multiple related diffs.  We can then commit them /en bloc/, or
squashed, or cherry-pick from them, as needed.

I did this myself a couple of times, e.g., in workers/48601.  Looking in
the archives, mhonarc (https://www.zsh.org/mla/workers/2021/msg00826.html)
doesn't render multiple text attachments sanely, but the official mbox
archives and public-inbox both do (https://inbox.vuxu.org/zsh-workers/20210416182141.GA15670@tarpaulin.shahaf.local2/T/#md006c516ad7f04f6d6225f213357839e4de03dcf).

Cheers,

Daniel

> > OK, then I will resend my patches in separate emails.
> 
> That's not necessary either, and I don't think any of the patches so
> far are controversial.
> 


  reply	other threads:[~2022-11-23 20:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 14:40 [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements Philippe Altherr
2022-11-19 13:39 ` Philippe Altherr
2022-11-21  0:43   ` Bart Schaefer
2022-11-21  7:22     ` Lawrence Velázquez
2022-11-22  2:52       ` Philippe Altherr
2022-11-22  4:51         ` Bart Schaefer
2022-11-22 10:17         ` Peter Stephenson
2022-11-23  8:11           ` Lawrence Velázquez
2022-11-23  6:59         ` Lawrence Velázquez
2022-11-23  9:43           ` Philippe Altherr
2022-11-23 16:11             ` Bart Schaefer
2022-11-23 20:57               ` Daniel Shahaf [this message]
2022-11-23 21:11                 ` Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements) Bart Schaefer
2022-11-23 21:22                   ` Bart Schaefer
2022-11-23 21:54                   ` Bart Schaefer
2022-11-24  2:21                     ` Philippe Altherr
2022-11-26  2:28                       ` Bart Schaefer
2022-11-26  4:02                         ` Philippe Altherr
2022-11-24  1:47               ` [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements Philippe Altherr
2022-11-24  4:28             ` Lawrence Velázquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123205715.GQ27622@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=larryv@zsh.org \
    --cc=philippe.altherr@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).