From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14102 invoked from network); 10 Dec 2022 11:38:31 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 10 Dec 2022 11:38:31 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670672311; b=a3X1o+lZQFChrdlfHgdm28OVf703oiP7QnBka5hhb+8SUJHFQ0vPierym1CCtnD9vvtMJ7bOCh uF5INQuaQh/EDnNzxzAnGnV7wTihOfPsmcXL9C/JYMbTtEekIqR2gfjqIkpKUO6gYiLcHid9Gt V+kc8KKqCn6gJDIco+43EoGclZne9p2y3ob6dlM90/umLxDW/uhiHFaIzzxSgfsfMtm5fnVb4U PfahSmV9ZpJNdNfWgKTiUU0gDZEmkGVE5iKByxbsGA3qPYlAh4nkkAsbW+H328S7CYftvuPqFq 1BTItc7JLNpE6UEtkqvtjsDpzjc6Sme54qaHeZSXS1DomQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670672311; bh=Nkc2y2NVc6IFoOnsftrl7QoizPkEnADXSsxQJr+mDw8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=Qw2EzIGyqwyatKZVuc1A//kXpNoUQBgm465tKps9DFKbtGqiWvyLRbf/qFs3s0sNVBgP1ADEf3 7wIg3w4TyEml/QUuEXJ6StCm46EhhjhuAN/M+4XdVq3oMpLt6agiWl32S/WsuK4p4Iz3M25jKT Hxo0lL7pAJg6NkEU7itiD9lKF3RdsOhfazreq6mRcdaiZICviq5Rnzbtn+MQVHarlb5QbTeBZ0 3XFEuq7Qs60qEETj9UYN0JyNBel2UcVyu64sdeotOJjApuABniUBRr/SU3Q1JRtSdQf+F+w+dC S/r3ZAt4dC5vFs874MjbSBIG30c+YKMNt3XsQyUqKuX2lQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=r/Za4CU+1QfiuxeBHELSYE93LLFx82nxXuGhklFlafc=; b=pRippm5ZXP2QdsgobYBtHEWSO8 EqF3EL/ITtrUjjiTC3C6X8IQK0tvpVj1OSbhV4OSfNUDFTkCur10XfvnrjW/etEB0IDT+GcVIj7uC T4nrH6gzfs+dnFrh9mtzPzFwt4LOHnmtpYWrJ1AIOXPQnbbzQQOO7bBWCi0CTL2Y5aTc1RB/kVBoO f1w0vakimuNAZs+H/u4cVxRPZfjD5EcWqxKxb1WNyEm2D72qx0a3hlXWb1f8hHqqtI1NpAfTxoTph 9Wr51lfujt28LzHfd1es8M8renwFP6UiPNySP4hzgfMa2x1YRAm+SiJySnI+Me9r2fqasG/xWJWZG 6wkF6/rg==; Received: by zero.zsh.org with local id 1p3yBa-000Nco-He; Sat, 10 Dec 2022 11:38:30 +0000 Authentication-Results: zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52157) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1p3yBM-000NKO-Gd; Sat, 10 Dec 2022 11:38:17 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B8AAB5C0116; Sat, 10 Dec 2022 06:38:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 10 Dec 2022 06:38:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670672295; x= 1670758695; bh=r/Za4CU+1QfiuxeBHELSYE93LLFx82nxXuGhklFlafc=; b=H e1gsYs2A+s9H2LkMmun1kA5o4+6qQaM9TYC1ZVgFjNWVkPRaSGx8qdf0riaguJI/ RUR7/LUAgOZSJM06ZLuko9zZ+AAf3badCBmdOx6hCxk0KSdtaYbYigPmXuScAeri 7pFpO5E7i1j2GQKX0VNORQ37v+wboMxrT8Yq/Mh7wWuvq1BjCOdSowjpCwmivyBJ cJ05l97S/kU7MCL+fPfhZRAY72oN+vSNMyk5bBOgYs7BSLJh8dwHfZwC0YwK++o7 UqSx24++0KOnarMrFIhU/BXhYGzTy2zKoolYgQ6p3v3wcf2eT/H7YyahzExfubLh 7QWA53jg7oCJXhLZwSQQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1670672295; x=1670758695; bh=r/Za4CU+1QfiuxeBHELSYE93LLFx 82nxXuGhklFlafc=; b=of1D8pZCIQaplIYWqFETYqfAGOkA9p3ODc7RmcxEslpO qSrMRv9h3/2Tmy4uvlYznYH26eC6BUX/SWQZsPSPh7kcE3VJ+mpOG8qFD3xuX7El pDm5hnpIDlZcDaq+rMTfON5MPucHt0DhSAPgdKbDYA8HhCxYlGOu9A9VpsRxFUPX xigTSUe1CywR1u5RdFxdtQNL4SL5MF1YcSn58VSZPGeq/eELMkVMiEIxLnRR9r5P TuEn1PW29b8FtL5iq5ZiIxDXRkqSULU14R8Z/SBDmmg9+vSzBl9lBcSE/EeTn+M4 NKGM5ROHR/2dECpFoYwvGzmBRJWtZDHeD8gu/QLMog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeggddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesthdttd dttdervdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgv lhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepueevkeefffeufeehfe fhgefffedviedthedtgeeljeelvdeihfevjeefteegvdeknecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhh grfhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i425e4195:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 10 Dec 2022 06:38:15 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4NTm9K5ctXz3BB; Sat, 10 Dec 2022 11:38:13 +0000 (UTC) Date: Sat, 10 Dec 2022 11:38:13 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: xtrace output sets ERRNO to 9 (EBADF) Message-ID: <20221210113813.GX27622@tarpaulin.shahaf.local2> References: <20221209141047.oyv3jsdvo5s3z6m6@chazelas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 51169 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Bart Schaefer wrote on Fri, Dec 09, 2022 at 18:57:37 -0800: > diff --git a/Src/exec.c b/Src/exec.c > index 1810fca5e..a1059af5e 100644 > --- a/Src/exec.c > +++ b/Src/exec.c > @@ -4336,10 +4336,13 @@ execcmd_exec(Estate state, Execcmd_params eparams, > } > } > if (newxtrerr) { > + int eno = errno; > fil = fileno(newxtrerr); > fclose(newxtrerr); > xtrerr = oxtrerr; > + /* Call zclose() to clean up internal tables, ignore EBADF */ > zclose(fil); > + errno = eno; This ignores any errors from the fileno() and fclose() calls as well, though? > } > > zsfree(STTYval); >