zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Shohei YOSHIDA <syohex@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 1/1] Update gnu make completion for version 4.4
Date: Thu, 19 Jan 2023 13:56:47 +0000	[thread overview]
Message-ID: <20230119135647.GA24327@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20230119015724.127515-2-syohex@gmail.com>

Shohei YOSHIDA wrote on Thu, Jan 19, 2023 at 10:57:24 +0900:
> +++ b/Completion/Unix/Command/_make
> @@ -165,6 +165,7 @@ _make() {
>    then
>      incl="(-|)include"
>      option_specs=(
> +      '(-b -m)'{-b,-m}'[ignored for compatibility]'

Should we add an «!» to this optspec, so these two options aren't shown
in the output?

> @@ -185,17 +187,18 @@ _make() {
>        '(-p --print-data-base)'{-p,--print-data-base}'[print makes internal database]'

Preëxisting issue: we should add the missing apostrophe.

Cheers,

Daniel


  reply	other threads:[~2023-01-19 13:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19  1:57 [PATCH 0/1] Update GNU " Shohei YOSHIDA
2023-01-19  1:57 ` [PATCH 1/1] Update gnu " Shohei YOSHIDA
2023-01-19 13:56   ` Daniel Shahaf [this message]
2023-01-20  2:53     ` Shohei Yoshida
2023-01-22 14:37       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119135647.GA24327@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=syohex@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).