From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9060 invoked from network); 7 Feb 2023 09:29:02 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Feb 2023 09:29:02 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1675762142; b=ZexXpZVKUv55UI25gabsbntK+eB5w6fFWbJEcA/u3y1oWSLiwQZtF1JPMKFMuw2IEi+hQla+Gm UW+AxF+x7LaCBgrekXI3eWOMFy0p69ababe7PpwqsnVB+nRPZW/ff0xxesAR+oVJ/DCM89hJDA /2VtJj/9/zSA2M6kQvfQgNC0F8aQZei0V5WkXbu7ChVOVsq/D2+/QCc5K1kw0F3CdtxG8VJvLg wtX1W+Zqrn/EyHM4Wqr2WgVLy6kdfDITTZ8mw59eV3FNHIf2Pw1ZA0Deg2COM4N92QRQMeQ3Yp cXne8J6Uw8j1L2ZOgk9u/bsb9fxePYxFXux5KPSbXL+Gbw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out3-smtp.messagingengine.com) smtp.remote-ip=66.111.4.27; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1675762142; bh=Z75feDe2N7LbkHs0q99ZpUT7KwIIuADKJ6HpUi44TS0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=chaXasxjCRbvGeLpYGDoXhZ5uKyKE4POmLHlKRBsF3dE+vcEZY0QP65KZdG04tABDGSPfAR5cN o4XvJptuiXs4hiaJS+CYwkIjjakWRuShu29FkYg3gd8flZboQTrQnmhn3DYMwvhVEbKN+B9ftO /qP6RVjN+DrL3q7GTVvWMIhk6wpqbqDoc/QccbnwvIhPXLI9Ghrq0jhMVWioead7qABeM0s6LP awnbD3jNkTPcTT/3KDDgYkA76vuApt/uC7bcbHI8ABUlxKapxn6z43jS2ovAdlhOdgppBT+PSF Q08D/7dDgOUzLgZQmlt3USVEx32j6T02fr7NSxSNqYinqA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=/XsIvuDiGkvdNP36kVj7HHl/t2Eg1M8SkKv99qT1NyE=; b=F2i4LeaUXDbtZPFGjwcEreAw+A g/8gnvBEtPUYtAmTSur/rAtcbDvoZxZO6pnLzv2fukerrwRpwJHrPAPiNZi5ACxOCUTkcVA4DxkVy EYnWz3JG3uQaB3dtYzr9etqMO0h8lIlHokXgVWIYRlzHZeUPzrIvy6fPMyrXCyvFFTua48nhCBjLS GJEMuyWD37U+Zoq/1MblYUMqSJSjXeoW5YAQVKimIPR61gfkIs4gjBb9FEucJhhW9nQLXM7JciIzr nntPbj37tNWOTXf1+STHcT2H0f64WKSYo+Hbgdh6Fj711nvshQGYjNhUfaCEat+5+uVGH1glwStFZ rn84FsuQ==; Received: by zero.zsh.org with local id 1pPKHc-000JVk-Aq; Tue, 07 Feb 2023 09:29:00 +0000 Authentication-Results: zsh.org; iprev=pass (out3-smtp.messagingengine.com) smtp.remote-ip=66.111.4.27; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33729) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1pPKH5-000J4B-0u; Tue, 07 Feb 2023 09:28:29 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D03DC5C01D4; Tue, 7 Feb 2023 04:28:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 07 Feb 2023 04:28:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm2; t=1675762104; x=1675848504; bh=/XsIvuDiGkvdNP36kVj7HHl/t 2Eg1M8SkKv99qT1NyE=; b=raS/3skyRTWbYpYPQNYCr6C3TKUHDgmzSwc+0nuEc 5xOrQouT/azNi1YUkPXDreWqjeZU3Gu+GlmiEr4gfEzuPtNezCw4ln18E+zeFk51 1lCm5vNuHKw1B7GoxyHFhcYKOhhsQyxJMS5PHsLirAz7jbPwMik3/JlWXXHuX2oH ++22VLU/SMZ7BkEGEahVnYTTrabMoD26tA/7xnc7MncD+yck5K66hoPQff2+DNPp KMCl6+rvXtsCGFElmoMaqh4rPELAYhm7z7aQ+sPdv1WDx77+QmmmopK/VwFaLvUv TowC4TJNw6FsK5eFRK79QabO7YzxC0RlOMFyUUU2jHO7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1675762104; x=1675848504; bh=/ XsIvuDiGkvdNP36kVj7HHl/t2Eg1M8SkKv99qT1NyE=; b=QLqtVHnsXsklzd7lz H3EIH43s4+bRf1JzVUGVhEfA1dgcC+3ZugSVAL4zCXNAR7t+ybwumL+avo7tqOmu OOStJ23XUElrQKF5/yGCINUBhUfBSuhdn5ghXlW6Nn4sLHa4G8G9o7/vB+HqBgZu LR9BnxwaCyfOxnb2XOT/Iz29FVA8VSj4dmx7q9UO2wqRp/k292uXz7l1ShpqcROp Bmy1FWlsblaDqMQvWRsQV6RKLseP3Yh2mw+Vx/SrNt1oXbcSA9dRRKr5yMjsjmyT WkdD6FL57ptAe3EXmc9704MeRGyqvbmjwixdk41a4NIjLxs3Yhl70hGFtVgCgoFv PTyyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegkedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderjeenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfekgfefjefgvd dvgfdutdelleekvdefteeitdduhfevveevudfhvdevfeefvdeunecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshh grhhgrfhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i425e4195:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 7 Feb 2023 04:28:24 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4P9yVD50m3zvD; Tue, 7 Feb 2023 09:28:20 +0000 (UTC) Date: Tue, 7 Feb 2023 09:28:20 +0000 From: Daniel Shahaf To: Zsh hackers list Subject: Re: [PATCH 2/3] Tests for named references Message-ID: <20230207092820.GA14216@tarpaulin.shahaf.local2> References: <20230207003355.GB4460@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 51371 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Bart Schaefer wrote on Mon, Feb 06, 2023 at 19:24:52 -0800: > On Mon, Feb 6, 2023 at 4:36 PM Daniel Shahaf wrote: > > Also, in 1/3 you wrote "attempting to add an attribute to a named > > reference generates a warning", but I don't see a single test expecting > > a non-empty stderr? > > Not sure what you mean here, there are lots of tests that expect a > zero exit status and check output only on stdout. The fifth test > specifically attempts adding the "tag" attribute to a named reference > and looks for the expected warning. Sorry, my bad. I grepped for lines that start with '?' forgot about the possibility to prepend a '*' to that. The fifth test is indeed what I was looking for (and didn't find). > In a number of cases I'm checking > that the state of variables has been restored to the expected state by > looking for both correct stdout of the earlier steps and "no such > variable" after the test is done, the intent being to catch any cases > where the nameref goes too far up the stack of scopes. 👍 Cheers, Daniel