From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 906 invoked from network); 1 May 2023 21:08:56 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 May 2023 21:08:56 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1682975336; b=k5JzYFOgdQK+12VrSTRoF8ArXakcB/02MGQ2SUMVkbbBbNAfhaDdjeLLH8jZpoDOAB6c5lcJLV arznwrKchYtbuaIM2FK6RmXtZjpQfj9ADC8MWqE3tYi4Wwh9INpHMuvOb3zSF1TDd3r4xZJgc6 kcsD5jc6QX4gx8zVZIpxCtfU1L0ckOKflfS1cfqj46W1CdI1Ko+83PNnTqNeWI6g2ybDV0g8mn q9Wof5263y+g3Z/oCsNiv6f315FH8/+z3YDSRKY2jIjgvONm0ZFLnFZAJCSjVEH3qw6c6fqhMg tXf8vxP/ccM4jXHFlLrxc9qFoooWgYofKj2TCm2SGHaTnw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=schrab.com header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=schrab.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1682975336; bh=FC+Z5Kck878d1ovlii3+jplAmpZ/RWcjFe379P5caLg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=fAuMjdG4u9p4MAts+/fP2RTCY9u8nx8BNJn0nDuwTG04AkAaWN7eF6gPj7+JbGKGr7Z/l+XAzt I/R5+IU0lZgVrguIbWteU4AA9gIqTKYmpWclsSR9rcIu5EXGsHKHo1jM+JkiI831Z8PY7HH24G 2Ma7XRHf7uzlkfNpDJgX4nWc6Pj+IRWIRhfsAH4eZnrMQQiBxhVZNgutyll+ey/bkgvc0sfWbB 3eIq4CO9Kfbn+eZyGIsvsg6m+VxZz8RJzLIAJEIeir+Paac7hbd1SmoM342H4Ic5xNOt5DWOiJ oc5O2wXoILkfRkVda5fnjJhIfSQ/F9Sz22qdJHBRvPTHRQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=BNrubLXMe3E2KqQAfJuIOT9cSV9HrwB8Y8y3sYJlGuA=; b=Kf/oY/BsC/CQv4v/q0R5CH9Gz/ PG8WV67ue5OPqpKrFhGLQ7KTEEGBU2vwma6CIflDQ5zQlW/SwXlQAhMQLoYoSvESNBwtHJw8/iTVU Cfz+qZF22tkuZA6BdWvjZ3BATW9DN8Tq1Z9uvDTRkLEBj5/f6f4GNBRtp1tjUUCHPH2BiipJ2oIQm 3Wk77Leon5vudpZgDP4/ZtCIhXOFdOick4NfWkylDcPFY8yicNRxQcgmeZegt6UpIc7AKns0SyEDm 5WwPFydzgPH1tkIU4EgyJrMFpgIHGDlcF2hPnQczRuiZBd2Y/SBHv/M908Zaob3pBnN/6/13xtLb5 NIpgqxnw==; Received: by zero.zsh.org with local id 1ptalR-000JWS-FM; Mon, 01 May 2023 21:08:53 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=schrab.com header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=schrab.com; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35219) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1ptakr-000JD4-5U; Mon, 01 May 2023 21:08:20 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 021D05C019D; Mon, 1 May 2023 17:08:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 May 2023 17:08:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schrab.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1682975294; x=1683061694; bh=BNrubLXMe3E2KqQAfJuIOT9cSV9HrwB8Y8y 3sYJlGuA=; b=QGPtxSmCmzjFd2NU2UQEh8B845YuZ0ero58soS1UuxLbcOfiTe8 27n/UtqGlRL2a/hbOOH+FGKsprn6eFBOLTR6IxK+QMGaFK6s9QJO1FGxSgn2xKCn 99skUtAQBrDDs5ztu5BeOgxYn8ECF1j7aXj5DawUHeJx6aNPu95mzTeVIGMctOw+ Y/wO/kkZpPLyYQl+8i37VL+xJbRzAVlp5KIpH7fMnkaH/mmKIWPJHXdqDMAyYXNt 8mZlhaAyOUKk1FAbma1PXDGQzMO0IjtV8Hj0US0o9L07QPB4Ff02n7Kz4I15CUC3 jjTVeMCGxcNqthVKes6ulZ2o1373N5C/mIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682975294; x=1683061694; bh=BNrubLXMe3E2KqQAfJuIOT9cSV9HrwB8Y8y 3sYJlGuA=; b=Xo6TDWLBXuioqVQU9F53o0+3PpGBmugO7cKJd6lGCURPlm0Hmli IaWrskJ5geFRXc47Hlcq6rsdYkuLkKMyP5sf4wuPep595DAyJPhe9BOA7allWfyO gTIsANzd5MfsaKak0uv9Ddg8AnaVnu+EiXSX78HkWbfUahpnMaYY2Ul5po2pKcM0 FWnmyULMyNsj02Dtq2ogNtK6z/EQoLicMZDHBp7SUOkd5EFnHlrhKhMQ9MQk3UGN fGMzKLMBcvkiovSgCoASmPQknVqlJmilTJ7noPbG1KKoWiPbottr0EE9Bn4iV1vc M39dNsdpMlcErB/PkQ0fuLaK7m1Tkve+AfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvgedgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomheptegr rhhonhcuufgthhhrrggsuceorggrrhhonhesshgthhhrrggsrdgtohhmqeenucggtffrrg htthgvrhhnpeejtdejueefteeliefgveevudeliefhleejieeiveevieefteefuefftddt jeehgfenucffohhmrghinhepiihshhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpegrrghrohhnsehstghhrhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1fd14616:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 May 2023 17:08:14 -0400 (EDT) Date: Mon, 1 May 2023 17:08:12 -0400 From: Aaron Schrab To: Marlon Richert Cc: Felipe Contreras , Zsh hackers list Subject: Re: Patch 1/3: Fix prefix insertion logic Message-ID: <20230501T210812Z.-CT1GOihZPID@pug.qqx.org> Mail-Followup-To: Marlon Richert , Felipe Contreras , Zsh hackers list References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Seq: 51693 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: At 22:02 +0300 29 Apr 2023, Marlon Richert wrote: >On Sat, Apr 29, 2023 at 9:58 PM Felipe Contreras > wrote: >> On Sat, Apr 29, 2023 at 1:09 PM Marlon Richert wrote: >> I don't know what's zsh's policy regarding sending patches, but >> personally I can't review zero content mails. > >Looks fine to me on the mailing list archives: >https://www.zsh.org/mla/workers/2023/msg00409.html > >Should I copy-paste the commit message into the email's body next time? >Would that help? For the 1/3 and 2/3 there wasn't really a commit message other than the subject, the only content other than the patch itself was the git pseudo-header and stats about the files modified. I certainly don't find "Fix prefix insertion logic" to be a very helpful commit message. It might be a decent subject, but I'd expect the full message to give at least *some* idea of what the problem is. The second patch in the series had a subject that I'd consider slightly more useful ("Make dynamic dir completion easier to implement"), but I'd generally expect the description to give some idea of how it makes implementation easier. The final patch of the series does appear to have a decent message, although I haven't attempted to check how it lines up with the actual patch.