From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23101 invoked from network); 2 Jun 2023 15:29:55 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Jun 2023 15:29:55 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1685719796; b=bYwdl6qiFacqgIhAFy5XtStX/zWhCnkZwbDNYSL5NOBiDAUb4Bz2CtLvcbrd6Qp7zyAQUoy0d/ HeD1NiyzNIdw2oUO0Ytvu0tRLZf6lGj2jWycbh3/T6mFqA8aLTh+Jp2d3OIznhLVj8rkwfA4av i2lWLf7YdXavjlJOKNjn7LY6RIpyR/cY6LpGy+0kvo8BemTiZrlWVm/7KndNY75bkkBR/Wi2nX /DoHSYs242Bla2mxRY9CVsXvUAnOYYgsQKiKUU3DE9WoLZocV3nnbi8tFSXhjwEV+SJMxTF9or s1lJkBaR9L7ohxYQNQEbEaWe6nLHya1hK/IRuJV54WbINA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (relay6-d.mail.gandi.net) smtp.remote-ip=217.70.183.198; dmarc=none header.from=chazelas.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1685719796; bh=efNqhPBsqJ+w1UANJEKcROaysVamXHpRJnXwgKesLLE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:DKIM-Signature; b=UUb3M+LLC4wcCx1CVLabzFwRSeg59I3ngTfAGFfYn5iM3KKoxYQ/QP6ipZNBXw+OKd/zxYnTdr 2CGAEFcor4JBGTlQWJVx2ASKkvOlrqwrULoOwXlVlKZPddE8zBA3fMzvy78pAxcNfYaCNQXVoy Hw/lr/yc8K2gamKBjndSCS2zjnR5XV2VRMWENgLRpt3yBhhNX5nSiQTjTfh5/GNJKsqli4Itz/ LQeKGEnXP+7lGWDL9TMPhM2BlD61DxdgHmVWRg6KLOoMJw2sV35SjnYrcq1WimiAdTu/ovHFBZ b7ITQGvq7w3ZlR+VmtzMN/KEHBDewowfvts/da+aDiz9Vw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=aq+ru3mbYSF/xWEy6I5r1ZTWU5Qp+TzgR/tb3VAzb7s=; b=TuzIglvDC0ouPENV4lpAKRBrkJ ZquY6NYEAUjVCN7ZDhDshVA6Oz0qlCaRjNEnApqBVFsy7/vQovfoIK48Q3W+hx+HpM5Ed68uEE0w6 0q0EX6UOdXdG8go3c0+qwlXvbMBllbgN0jcQg7RkQBJutY8apzFQHg5B4PPQF2AOKdHrqh1/ntb0E FL0RMjhQlD+wnnBEe/IHvCj9yM+2n4NVRr2lWBUzcm4OgipLVWM12uFSasGQn8bSJd0HMl0DyjW/V i9b+sVHKxqJ+1ZA4jj8Eq4lD8KFXHL1E93IQvlMfuA66FN1Q8ltck2H+sWTP4j/QX5iTwpOphtvqq ujfz7r1A==; Received: by zero.zsh.org with local id 1q56ix-000JSP-HB; Fri, 02 Jun 2023 15:29:55 +0000 Authentication-Results: zsh.org; iprev=pass (relay6-d.mail.gandi.net) smtp.remote-ip=217.70.183.198; dmarc=none header.from=chazelas.org; arc=none Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56991) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1q56ic-000J8E-8F; Fri, 02 Jun 2023 15:29:41 +0000 X-GND-Sasl: stephane@chazelas.org X-GND-Sasl: stephane@chazelas.org Received: by mail.gandi.net (Postfix) with ESMTPSA id 50854C000E; Fri, 2 Jun 2023 15:29:33 +0000 (UTC) Date: Fri, 2 Jun 2023 16:29:32 +0100 From: Stephane Chazelas To: Peter Stephenson , Zsh hackers list Subject: Re: histsubstpattern in zmv Message-ID: <20230602152932.ykoazfo5o6somi7w@chazelas.org> Mail-Followup-To: Peter Stephenson , Zsh hackers list References: <20230601183556.nl3zhv2kdxgj7x4d@chazelas.org> <1452348325.5131636.1685695219291@mail.virginmedia.com> <1068343689.5141130.1685701118603@mail.virginmedia.com> <20230602150953.xr6ukng3oxsv2jpv@chazelas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602150953.xr6ukng3oxsv2jpv@chazelas.org> X-Seq: 51818 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: 2023-06-02 16:09:53 +0100, Stephane Chazelas: [...] > May be worth applying the patch below today for future-proofing $ grep -rnP '\$[~^=#]?([$!#?*@]|\w+)(\[[^]]*\])?:(?![aAceghlpPqQrstux])\w' Completion Completion/Solaris/Command/_ipadm:139: proto_all_properties=( $^proto_all_properties:value:_ipadm_get_possible_values ) is more complete (accounts for the $# $!... special parameters and $~var, $^var...) and finds that extra one. I likely still forget some more. diff --git a/Completion/Solaris/Command/_ipadm b/Completion/Solaris/Command/_ipadm index 34d1eacba..c59fc8108 100644 --- a/Completion/Solaris/Command/_ipadm +++ b/Completion/Solaris/Command/_ipadm @@ -136,7 +136,7 @@ _ipadm() { proto_icmp_properties=( "max_buf" "recv_buf" "send_buf" ) proto_all_properties=( $proto_ipv4_properties $proto_ipv6_properties $proto_tcp_properties $proto_udp_properties $proto_sctp_properties $proto_icmp_properties ) - proto_all_properties=( $^proto_all_properties:value:_ipadm_get_possible_values ) + proto_all_properties=( ${^proto_all_properties}:value:_ipadm_get_possible_values ) proto_propproperties=( "proto" "property" "perm" "current" "persistent" "default" "possible" ) > and a note in the manual that it's unwise to leave a parameter > expansion un-braced if it's followed by a ":"? [...] unless the ksharrays option is enabled. -- Stephane