zsh-workers
 help / color / mirror / code / Atom feed
From: Stephane Chazelas <stephane@chazelas.org>
To: Bart Schaefer <schaefer@brasslantern.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Example / partial fix for printf with math expressions
Date: Sun, 25 Feb 2024 06:54:00 +0000	[thread overview]
Message-ID: <20240225065400.wrb3jxr7vub6t42v@chazelas.org> (raw)
In-Reply-To: <20240224144041.7huny3lmihsrokdm@chazelas.org>

2024-02-24 14:40:41 +0000, Stephane Chazelas:
[...]
> With the one below using curlen / len[argp-args]:
[...]
> +			zlongval = (curarg) ? mathevali(metafy(curarg, curlen, META_HEAPDUP)) : 0;
[...]

That incur a performance penalty:

$ time zsh -c 'repeat 1000 printf %d 123_456+{1..10000}' > /dev/null
zsh -c 'repeat 1000 printf %d 123_456+{1..10000}' > /dev/null  6.07s user 0.46s system 99% cpu 6.544 total
$ time ./Src/zsh -c 'repeat 1000 printf %d 123_456+{1..10000}' > /dev/null
./Src/zsh -c 'repeat 1000 printf %d 123_456+{1..10000}' > /dev/null  9.97s user 0.62s system 99% cpu 10.602 total

The numbers end up being metafied (earlier), unmetafied by
printf, metafied again by printf here and that metafication
processed by the math handler I guess.

Maybe the performance could be *improved* instead if the
unmetafication could be skipped altogether in printf in those
cases?

-- 
Stephane


  parent reply	other threads:[~2024-02-25  6:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 23:23 Bart Schaefer
2024-02-24 14:40 ` Stephane Chazelas
2024-02-24 15:10   ` Stephane Chazelas
2024-02-24 21:51   ` Bart Schaefer
2024-02-25  6:54   ` Stephane Chazelas [this message]
2024-02-26  0:04     ` Bart Schaefer
2024-02-26 17:12       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240225065400.wrb3jxr7vub6t42v@chazelas.org \
    --to=stephane@chazelas.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).