From: Stephane Chazelas <stephane@chazelas.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: Metafication in error messages (Was: [PATCH] unmetafy Re: $var not expanded in ${x?$var})
Date: Sun, 25 Feb 2024 07:29:51 +0000 [thread overview]
Message-ID: <20240225072951.sxzdzoydvgqxctdj@chazelas.org> (raw)
In-Reply-To: <CAH+w=7Z9EhH_caA-kioEjvFLXN06s82cAu-Mq9XyU4BwbVsktA@mail.gmail.com>
2024-02-24 22:05:26 -0800, Bart Schaefer:
> On Sat, Feb 24, 2024 at 6:17 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
> >
> > The actual tradeoff to make %l do the raw output is:
> > + fix the width calculation in math.c, then use %s *
> > + add one call to metafy() in parse.c, to use %s instead of %l **
> > + add one call to unmetafy() in subst.c, to use %l instead of %s
> > - remove metalen(), zhalloc(), memcpy(), and nicezputs() from utils.c
> > + add one call to fwrite() in place of the above
>
> Stephane, if you really still think it preferable to add %S (thus
> moving the unmetafy() from subst.c to utils.c) then I think we should
> just do away with %l entirely. Either way we're ending up with a
> branch in zerrmsg() that's used for exactly one special case.
I don't have a strong opinion on it. Either way, the internal
documentation should make it clear the metafy and nicezputs
expectations.
Like:
%s expects metafied string, prints it nicezputs'ed
%l expects non-metafied string and byte length, prints it raw.
it's the caller's responsibility to make sure the string is
not truncated in the middle of a character.
Note that there's truncating in between the bytes of a
character and there's truncating between the characters of a
grapheme cluster like decomposed Hangul syllables (or
$'Ste\u301phane'). I don't think we'd want to try and address
that.
Other option could be to have %s, %S and %*s %*S and let
nicezputs do the truncation and ellipsis in %*s case which might
be a cleaner interface if (likely) more cumbersome to implement.
--
Stephane
next prev parent reply other threads:[~2024-02-25 7:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 8:02 $var not expanded in ${x?$var} Stephane Chazelas
2023-01-16 8:35 ` Daniel Shahaf
2023-01-16 17:15 ` Peter Stephenson
2024-02-20 7:05 ` Stephane Chazelas
2024-02-20 17:45 ` Bart Schaefer
2024-02-20 19:39 ` Stephane Chazelas
2024-02-21 4:44 ` Bart Schaefer
2024-02-21 19:45 ` Stephane Chazelas
2024-02-21 19:52 ` Bart Schaefer
2024-02-21 20:21 ` Stephane Chazelas
2024-02-22 0:46 ` [PATCH] unmetafy " Bart Schaefer
2024-02-22 7:23 ` Stephane Chazelas
2024-02-22 7:55 ` Metafication in error messages (Was: [PATCH] unmetafy Re: $var not expanded in ${x?$var}) Stephane Chazelas
2024-02-22 17:02 ` Bart Schaefer
2024-02-22 22:31 ` Bart Schaefer
2024-02-23 0:49 ` Bart Schaefer
2024-02-23 19:27 ` Stephane Chazelas
2024-02-23 22:32 ` Bart Schaefer
2024-02-23 23:38 ` Bart Schaefer
2024-02-24 9:47 ` Stephane Chazelas
2024-02-24 10:36 ` Stephane Chazelas
2024-02-25 4:35 ` [PATCH] 'bad interpreter' error garbled Bart Schaefer
2024-02-25 5:26 ` Bart Schaefer
2024-02-25 2:17 ` Metafication in error messages (Was: [PATCH] unmetafy Re: $var not expanded in ${x?$var}) Bart Schaefer
2024-02-25 6:05 ` Bart Schaefer
2024-02-25 7:29 ` Stephane Chazelas [this message]
2024-02-25 8:28 ` typeset -<non-ASCII> (Was: metafication in error messages) Stephane Chazelas
2024-02-25 8:35 ` Stephane Chazelas
2024-02-25 21:02 ` Bart Schaefer
2024-02-23 0:33 ` Metafication in error messages (Was: [PATCH] unmetafy Re: $var not expanded in ${x?$var}) Bart Schaefer
2024-02-25 5:06 ` [PATCH] count multibyte and metafied characters correctly for math ops errors Bart Schaefer
2024-02-22 8:34 ` [PATCH] unmetafy Re: $var not expanded in ${x?$var} Roman Perepelitsa
2024-02-22 17:07 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240225072951.sxzdzoydvgqxctdj@chazelas.org \
--to=stephane@chazelas.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).