zsh-workers
 help / color / mirror / code / Atom feed
From: Christian Heusel <christian@heusel.eu>
To: zsh-workers@zsh.org
Cc: Christian Heusel <christian@heusel.eu>
Subject: [PATCH] github #119: fix completion for git bisect visualize
Date: Mon, 12 Aug 2024 20:11:42 +0200	[thread overview]
Message-ID: <20240812181141.73639-2-christian@heusel.eu> (raw)

When trying to use the completion for git bisect visualize one currently
is greeted with the curious error of something like this:

    git bisect visualize _git-bisect:89: command not found: arch

While in this case 'arch' is the name of the first folder in the
directory. The cause for this is a missing separation of switch cases
which we fix by inserting the needed ";;".

Signed-off-by: Christian Heusel <christian@heusel.eu>
---
This is a re-send of https://github.com/zsh-users/zsh/pull/119 which I
will close should this patch be accepted!

Thanks for your awesome work on zsh! <3
---
 Completion/Unix/Command/_git | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 22b945e38..6c6d59b24 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -278,6 +278,7 @@ _git-bisect () {
           _arguments -C -s \
             $log_options \
             $revision_options && ret=0
+          ;;
         (*)
           _nothing
           ;;
--
2.46.0



             reply	other threads:[~2024-08-12 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 18:11 Christian Heusel [this message]
2024-08-14  2:39 ` Eric Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812181141.73639-2-christian@heusel.eu \
    --to=christian@heusel.eu \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).