From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Johan Grande <nahoj@crans.org>, zsh-workers@zsh.org
Subject: Re: Pattern bug on (a*|)~^(*b)
Date: Tue, 1 Aug 2023 14:30:54 +0100 (BST) [thread overview]
Message-ID: <2034111748.1610065.1690896654728@mail.virginmedia.com> (raw)
In-Reply-To: <16673694-5299-cf1c-8553-c3d703d942d0@crans.org>
On 01/08/2023 14:19 Johan Grande <nahoj@crans.org> wrote:
> So I'm thinking I could filter for user-provided patterns that contain
> '|' and don't put them in the mega-pattern but filter for them
> post-globbing. Does that sound like a sound solution to you?
Yes, I think that would be OK. The only case I definitely know of where
you'd hit the problem would be branches using that specific syntax.
I'm not entirely sure if you'd get issues with approximation, which is
even more complicated, but so long as there are no (#a...)'s in your
patterns that's not a problem.
If you can guarantee that the first branch is a longer match than the
second, you'll also get a away with it. So (a*|) will work, because
the first branch must be at least 1 character, and the second can't
have any. Obviously, that's harder to check for automatically, though,
but you could do a limited check, say, that any | was followed by a
right parenthesis.
pws
next prev parent reply other threads:[~2023-08-01 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:19 Johan Grande
2023-07-25 18:35 ` Bart Schaefer
2023-07-25 18:47 ` Johan Grande
2023-07-28 1:02 ` Bart Schaefer
2023-07-28 6:41 ` Stephane Chazelas
2023-07-29 1:35 ` Bart Schaefer
2023-08-01 13:19 ` Johan Grande
2023-08-01 13:30 ` Peter Stephenson [this message]
2023-08-01 13:46 ` Johan Grande
2023-08-02 8:31 ` Johan Grande
2023-08-02 9:37 ` Peter Stephenson
2023-07-31 11:36 ` Peter Stephenson
2023-07-31 15:21 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2034111748.1610065.1690896654728@mail.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=nahoj@crans.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).