From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15017 invoked by alias); 12 May 2018 10:35:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42760 Received: (qmail 14827 invoked by uid 1010); 12 May 2018 10:35:28 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(-1.4/5.0):. Processed in 1.79547 secs); 12 May 2018 10:35:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=LgWs=H7=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1526120958; bh=6iJ/7jQnmicZu6w+zB0jnTapv8iX8ZfXlMJ7uhjsOyo=; h=From:References:To:Subject:Date:From:Subject; b=pQuloPhw4X8FXB/bDSrGkoFxnruPH/PLu02N9hNoBt+kUGsY70v+CSIljzhwB1n+2iG3kBFF0sPeR0Feh7b358jmJVITcg2b87TFrBIlDASaBvJhu7XTu7LUDl+MP9Qr8P+gjfMTyt848Z6UqnQ4nq6Mbd0dpynlQj72jmvSmkshFCF9+eqszurMWM60h/5BKo4AJyAIxBMRXAYZZEPmZZtF3FjJDImAxIlREVs496nRN3P00ykKdaKTYL3jSurh3CvwhcFiSw9XdyP9Ew5NZ+OpAYUV/a9VyybBYumXhtF9pvhz8utCZhaRCWIemCNZy55d3jf5PC5TeYfilOfFvA== X-YMail-OSG: qXHJW9sVM1kK_BN9t_KsXLxGcfbvlcYnLpojR4FMgx4ZfXz2y8pqnYcl8sSO52o n7McPapz.hwHrCwfkGHFDJWkMcEo0gQMBUpLlRMwBB_t715LjlmgiE.RKkhZlmHuj6zUi_LEzuFY zhgjOzumDNk.LmGM1zESDj.0Z_s7jiS4ietbKkuvTFys5EYvdtOjgI9tP5d5FFXoBk4ZYvWpVpch ke2ITnV.4wN9o8tzEOd5zYWnVJIggHyHBU9JykeE8Aot4PppWjFQf4.rgIxT4dh_TBVF8lMQP6Yi buI1XIoK68uXhV_nKEW8pNlk9pOZT0ktrs.ZWFLiAF1U5LGNb62Yfgq_.Rblo0ogfznkYwcouY6F XSyqJHjQSVfoxFfzRzxtphlyDULcXnb9RknBsdaQ6lWFmu7yzEz2KJfL6DcceuHAHn4HKLh_O6i9 pn.8uxWuCt54Bp_UXCO38IAxN7njM1s5DynEs5jpWwj0JU8BNgE6N0htOVAKl20LfdNBt2.YPjVD vvViyH5uyRXWR5kgqX8qdZewbDxd7TcCT.eIyDxOLfKj9Az_rM47dbmXeI7NuQtHIwRyVrk9SY84 qb4xBLIB_U.lwwThaEtI8bTPyHPzPSgY8Dz8- In-reply-to: <46F08EE7-DA1F-49E5-8E74-4D519E47ACBD@kba.biglobe.ne.jp> From: Oliver Kiddle References: <20180321101630.511442a9@camnpupstephen.cam.scsc.local> <46F08EE7-DA1F-49E5-8E74-4D519E47ACBD@kba.biglobe.ne.jp> To: zsh-workers@zsh.org Subject: Re: Warnings in compctl MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20532.1526120956.1@thecus> Date: Sat, 12 May 2018 12:29:16 +0200 Message-ID: <20533.1526120956@thecus> On 23 Mar, Jun T wrote: > Three more files (complete.c, computil.c, zle_thingy.c) have the same > "off the front" pointer assignments; these are detected by > "clang -Warray-bounds-pointer-arithmetic". One of these changes now triggers stack-use-after-scope in the address sanitizer because skip_this_arg is declared inside the while loop but is accessed in the while loop's condition. Oliver diff --git a/Src/Zle/zle_thingy.c b/Src/Zle/zle_thingy.c index 5601c1178..6b892b822 100644 --- a/Src/Zle/zle_thingy.c +++ b/Src/Zle/zle_thingy.c @@ -725,13 +725,13 @@ bin_zle_call(char *name, char **args, UNUSED(Options ops), UNUSED(char func)) remetafy = 0; while (*args && **args == '-') { + char skip_this_arg[2] = "x"; char *num; if (!args[0][1] || args[0][1] == '-') { args++; break; } while (*++(*args)) { - char skip_this_arg[2] = "x"; switch (**args) { case 'n': num = args[0][1] ? args[0]+1 : args[1];