From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.2
Received: (qmail 16487 invoked from network); 4 May 2020 15:31:23 -0000
Received-SPF:  pass (primenet.com.au: domain of zsh.org
  designates 203.24.36.2 as permitted sender)
  receiver=inbox.vuxu.org; client-ip=203.24.36.2
  envelope-from=<zsh-workers-return-45779-ml=inbox.vuxu.org@zsh.org>
Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with ESMTPUTF8; 4 May 2020 15:31:23 -0000
Received: (qmail 13598 invoked by alias); 4 May 2020 15:31:13 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45779
Received: (qmail 14409 invoked by uid 1010); 4 May 2020 15:31:12 -0000
X-Qmail-Scanner-Diagnostics: from smtpq4.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from <p.w.stephenson@ntlworld.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.2/25801. spamassassin: 3.4.4.  
 Clear:RC:0(212.54.57.99):SA:0(-2.7/5.0):. 
 Processed in 3.773837 secs); 04 May 2020 15:31:12 -0000
X-Envelope-From: p.w.stephenson@ntlworld.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.99 as permitted sender)
X-Env-Mailfrom: p.w.stephenson@ntlworld.com
X-Env-Rcptto: zsh-workers@zsh.org
X-SourceIP: 172.25.160.133
X-CNFS-Analysis: v=2.3 cv=FMeAO9gs c=1 sm=1 tr=0
 a=ShKnLeKYHz8gHcl3UCxcnw==:117 a=KEnZaF_ea6UA:10 a=IkcTkHD0fZMA:10
 a=DoY9bV0jb9AA:10 a=pGLkceISAAAA:8 a=yuhk36TwoL_T8bq8mr8A:9 a=QEXdDO2ut3YA:10
X-Authenticated-Sender: p.w.stephenson@ntlworld.com
Date: Mon, 4 May 2020 16:30:33 +0100 (BST)
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: xzfcpw@gmail.com, zsh-workers@zsh.org
Message-ID: <2074263909.167631.1588606233393@mail2.virginmedia.com>
In-Reply-To: <cef5c98b3d0fb920e93d90c7cd44ce0f2da3c68d.camel@gmail.com>
References: <cef5c98b3d0fb920e93d90c7cd44ce0f2da3c68d.camel@gmail.com>
Subject: Re: PATCH: readhistfile(): do not call ftell() in loop
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Medium
X-Mailer: Open-Xchange Mailer v7.8.4-Rev69
X-Originating-IP: 165.225.81.56
X-Originating-Client: open-xchange-appsuite
X-CMAE-Envelope: MS4wfPRsE2pNk9kK/lF7vI0fdtkD7phHT36Vu0Cm/Q5UJKAwar+gACKdnceJUCFcvR7NFJgNwBamXRctvhuPVTdGVqFwE3Bxn08cdeItwq4JujO737199+qG
 LlpRJN8dYNxYnOsvbCkD3Qk2UJLlLdUGwzsJcZ6Gq05Iy0jbs37uGwhmTsu7U0yJukDrLG3gnMDuyf/G47+u1ANbVJLN74kxkiun+02cJ21w4AdPp6EwV2PG

> On 03 May 2020 at 10:33 xzfcpw@gmail.com wrote:
> 
> 
> Prior to this patch, readhistfile() performed one lseek() syscall (inside ftell()) per each history entry.
> This is time-consuming on large histfiles.
> 
> This patch replaces this call to ftell() with manual tracking of bytes read.

Looks fine to me --- can't think of any gotchas with file position.  I'll commit if no one else
has any comments.

pws