zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG]: zle-line-pre-redraw breaks vi-repeat-change
Date: Wed, 7 Oct 2020 14:25:43 +0100 (BST)	[thread overview]
Message-ID: <2080752838.394973.1602077143639@mail2.virginmedia.com> (raw)
In-Reply-To: <CAN=4vMrW8jtzoAATn888q=rXpukYTt6V6HEdGGo-tVn=Vaoz-A@mail.gmail.com>

> On 07 October 2020 at 13:49 Roman Perepelitsa <roman.perepelitsa@gmail.com> wrote:
> 
> 
> If zle-line-pre-redraw is defined, vi-repeat-change behaves as if the
> numeric argument was always 1.

I wonder if we need to change zlecallhook().

pws

diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c
index 8c0534708..1622d8a6b 100644
--- a/Src/Zle/zle_main.c
+++ b/Src/Zle/zle_main.c
@@ -1067,6 +1067,7 @@ redrawhook(void)
 	int old_incompfunc = incompfunc;
 	char *args[2];
 	Thingy lbindk_save = lbindk, bindk_save = bindk;
+	struct modifier zmod_save = zmod;
 
 	refthingy(lbindk_save);
 	refthingy(bindk_save);
@@ -1094,6 +1095,7 @@ redrawhook(void)
 	 * restore lastcmd manually so that we don't mess up the global state
 	 */
 	lastcmd = lastcmd_prev;
+	zmod = zmod_save;
     }
 }


  reply	other threads:[~2020-10-07 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 12:49 Roman Perepelitsa
2020-10-07 13:25 ` Peter Stephenson [this message]
2020-10-07 14:49   ` Roman Perepelitsa
2020-12-16  8:33 ` Roman Perepelitsa
2021-01-26 20:55   ` Paul
2021-01-27 10:06     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2080752838.394973.1602077143639@mail2.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=roman.perepelitsa@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).