From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: tcp cleanup and breakage
Date: Thu, 04 Jul 2002 11:23:23 +0100 [thread overview]
Message-ID: <21114.1025778203@csr.com> (raw)
In-Reply-To: "Clint Adams"'s message of "Thu, 04 Jul 2002 05:46:10 EDT." <20020704094610.GA19804@dman.com>
Clint Adams wrote:
> Some other things may have been fixed or broken, and some inexplicable
> changes in whitespace occurred. I won't commit this.
No point sending a full patch at the moment (translation: I'm too lazy
to send a diff without CVS to make it for me), but desthost is being freed
twice in the final `else' of bin_ztcp. It should probably look like:
desthost = ztrdup(dargs[0]);
gai_errno = zsh_getaddrinfo(desthost, destservice, &zthints, &zthost);
zsfree(destservice);
if (gai_errno) {
/* gai_strerror could be more useful here */
zwarnnam(nam, "host/service resolution failure: %s: %d", desthost, gai_errno);
zsfree(desthost);
return 1;
}
zsfree(desthost);
and remove the zsfree(desthost) right at the end of that block. Unless
it doesn't need ztrdup'ing at all any more.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 392070
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
next prev parent reply other threads:[~2002-07-04 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-04 9:46 Clint Adams
2002-07-04 10:23 ` Peter Stephenson [this message]
2002-07-04 17:01 ` Clint Adams
2002-07-04 10:42 ` Borsenkow Andrej
2002-07-04 10:56 ` Peter Stephenson
2002-07-04 16:59 ` Clint Adams
2002-07-04 22:31 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21114.1025778203@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).