From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4692 invoked from network); 4 Jul 2002 10:23:59 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 4 Jul 2002 10:23:59 -0000 Received: (qmail 13890 invoked by alias); 4 Jul 2002 10:23:53 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 17406 Received: (qmail 13877 invoked from network); 4 Jul 2002 10:23:53 -0000 To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: Re: PATCH: tcp cleanup and breakage In-reply-to: "Clint Adams"'s message of "Thu, 04 Jul 2002 05:46:10 EDT." <20020704094610.GA19804@dman.com> Date: Thu, 04 Jul 2002 11:23:23 +0100 Message-ID: <21114.1025778203@csr.com> From: Peter Stephenson Clint Adams wrote: > Some other things may have been fixed or broken, and some inexplicable > changes in whitespace occurred. I won't commit this. No point sending a full patch at the moment (translation: I'm too lazy to send a diff without CVS to make it for me), but desthost is being freed twice in the final `else' of bin_ztcp. It should probably look like: desthost = ztrdup(dargs[0]); gai_errno = zsh_getaddrinfo(desthost, destservice, &zthints, &zthost); zsfree(destservice); if (gai_errno) { /* gai_strerror could be more useful here */ zwarnnam(nam, "host/service resolution failure: %s: %d", desthost, gai_errno); zsfree(desthost); return 1; } zsfree(desthost); and remove the zsfree(desthost) right at the end of that block. Unless it doesn't need ztrdup'ing at all any more. -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 392070 ********************************************************************** The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer. **********************************************************************