zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Mailing-list zsh-workers <zsh-workers@zsh.org>
Cc: Julien Nicoulaud <julien.nicoulaud@gmail.com>
Subject: Re: GH:zsh-users/zsh-completions.
Date: Wed, 18 Oct 2017 18:23:22 +0200	[thread overview]
Message-ID: <21335.1508343802@thecus.kiddle.eu> (raw)
In-Reply-To: <MtKUvyERJ4IZOwutyo30irHfL7z63FqUejhZnpXv6zrWYAt_C1-WxOCO_pafA4d3rZ5acQvFoQqrLDmwGsIvy5Y0YQbBirOxZs4xjVCAfRg=@protonmail.com>

Joey Pabalinas wrote:
> Git subtrees lend themselves better when developing both main project
> and sub-project within the same directory (a "system approach"). This, however,
> would be more akin to a "vendor branch": a branch which allows you to access

Thanks, having not used submodules and subtrees before I was
experimenting to see how they might be used and this has helped clarify
things.

I also concluded that we can't easily pull in a subdirectory of the
existing zsh-completions project: it is all or nothing. Maybe it is
somehow possible with a subtree merge (a different thing from git
subtree) but my attempts at that failed. However:

> I feel like a good compromise would be for there to be a seperate, isolated
> `zsh-completions` repository that both projects can submodule;

That might work. Not sure I like there then being three projects (plus
upstreams). The whole idea is to make it less confusing for someone
wanting to contribute. Maybe the "incubator" completions could be pulled
in to the zsh repository with the others but excluded from a zsh release
tarball. Or we could use a separate orphan git branch.

If we're to separate completions out of zsh, there's also the question
of how much to separate out. Different levels would be:
  * Separate away all of it, even including Base and compinit
  * Leave back only the core
  * Also leave completion of Zsh builtins
  * Also leave any functions that are called from these, i.e. a good chunk
    of Unix/Type, especially _files; separating just external commands
  * Start with an empty new repository leaving all the existing stuff

Unless we use the empty new repository, actually making the separation
is quite a bit of work given Makefile stuff aswell. And as mentioned
before, separating also creates the problem of needing to worry about
backward compatibility in functions.

What I would prefer is for us to leave zsh completions where they are but
optimise the workflow:

  * Encourage completion contributions in the form of github pull
    requests to the zsh-users/zsh mirror. This isn't hard to handle:
    add github as an additional remote, fetch refs/remotes/xxxx/pr/*,
    cherry-pick and push to the sourceforge master.
  * Require no mailing list message for basic completion updates.
  * Rethink the need to update ChangeLog on every commit.

We preserved the ChangeLog in its existing form when migrating from CVS
largely so that we were changing as little as possible. But we have git
log. All new ChangeLog entries can be autogenerated as a whole as part
of rolling a release for inclusion in the tarball. Even for the tarball
I'd argue that most users would prefer a well produced NEWS file update
to the detailed ChangeLog.

I realise that this doesn't solve the problems with how to hatch
completions from zsh-completions.

Oliver


  reply	other threads:[~2017-10-18 16:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7240.1507973844@thecus.kiddle.eu>
2017-10-14 14:44 ` GH:zsh-users/zsh-completions Julien Nicoulaud
2017-10-14 16:49   ` GH:zsh-users/zsh-completions Eric Cook
2017-10-16 14:29   ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-16 15:11     ` GH:zsh-users/zsh-completions Peter Stephenson
2017-10-16 15:24       ` GH:zsh-users/zsh-completions Bart Schaefer
2017-10-16 15:42         ` GH:zsh-users/zsh-completions Peter Stephenson
2017-10-16 17:49           ` GH:zsh-users/zsh-completions gi1242+zsh
2017-10-17 21:09             ` GH:zsh-users/zsh-completions Joey Pabalinas
2017-10-18 16:23               ` Oliver Kiddle [this message]
2017-10-19  1:09                 ` GH:zsh-users/zsh-completions Bart Schaefer
2017-10-19  4:03                   ` GH:zsh-users/zsh-completions Aaron Schrab
2017-10-19  5:24                     ` GH:zsh-users/zsh-completions Bart Schaefer
2017-11-01 23:33                   ` ChangeLogs (Re: GH:zsh-users/zsh-completions.) Oliver Kiddle
2017-11-01 23:46                     ` Bart Schaefer
2017-11-02 20:09                       ` Oliver Kiddle
2017-10-19  1:31                 ` GH:zsh-users/zsh-completions Joey Pabalinas
2017-10-19 14:37                 ` GH:zsh-users/zsh-completions Daniel Shahaf
2017-10-30 23:38                   ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-11-01 16:35                     ` GH:zsh-users/zsh-completions Daniel Shahaf
2017-11-01 22:58                       ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-16 23:00           ` GH:zsh-users/zsh-completions Bart Schaefer
2017-10-16 20:04       ` GH:zsh-users/zsh-completions Daniel Shahaf
2017-10-17  7:53       ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-17  8:41         ` GH:zsh-users/zsh-completions Peter Stephenson
2017-10-16 15:26     ` GH:zsh-users/zsh-completions gi1242+zsh
2017-10-17  9:35       ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-19 18:25         ` GH:zsh-users/zsh-completions Daniel Tameling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21335.1508343802@thecus.kiddle.eu \
    --to=okiddle@yahoo.co.uk \
    --cc=julien.nicoulaud@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).