From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36042-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 12533 invoked by alias); 10 Aug 2015 12:25:38 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36042
Received: (qmail 12116 invoked from network); 10 Aug 2015 12:25:35 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1439209140; bh=HxeN4CsJKaYMUQCqv3kkyBVt8my4QeY0HMTshZJnhys=; h=In-reply-to:From:References:To:cc:Subject:Date:From:Subject; b=ldKBM626ZDFbh65xTKRQ98xai7T7Q8W5gxbXxTGfaTl6NS91Gbj7GRhGChmRGcBPmay+7dqe31neuIN4j8OA/a4q/wzoZJeZj87kXVDNYin8HLTMfL4bnEef0po0uVrhlRX4dwlfv3sxSIAr1ZkEv2dByBAI1NQraaNoyxqsrGQZFVwlGtfciXQDkmi2speXE/+1GzIYeUYPp5Vj/CPTxjkG11ULENkPBbUwaoNIUVs2ym24M7rZZpo6uI2S2rYq6DG+NYqSHHbVi5wPj98NzlZPSkUewfB1j68RtEPhvQOV+tsY/w1zcjp6ZnXKKzo8ScBxWGHQn5eGUK2ki7GZiw==
X-Yahoo-Newman-Id: 497489.88164.bm@smtp123.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: U_rqaMcVM1m7F868JmxNfvadOeF07sNL6zP4C8zmZuLp5yf
 rMZY4eMOIO5qY4JoSMXTl53E6EISXVNBICmwy82vYuh4RWo.olyc.4zSorI.
 yt1HAGFlf4HBjQJZgHnewrMVCxjfZTQqrQr5Bqlr5OB1D66jd0lU9joszUXz
 dQ3tm4vsGfptNbX3uyoCm5NyY7l72tFxVVRPiWofN.Hy1OQeKW9wzGWuPkEM
 uy4aMziltE_dGj.2XrTpmd3v6e3j0gBJ7En4he5AfK6G9R4D3MGK5xlUz7Sa
 IiKvzl7sOQ_yP73MoBvS7jbfAs2d..40fLK1ERlMWcNJdEUFifoYM4wPaQaP
 GvF3aqwor_HNWsVLXfQs7RYzSXgvbjWa58czBg5.WT7Ub.xDVv1RzPgAiHIS
 ffTj8._hYKm.vBImSc6crSbHnNZiQSHIHaN.TPUPKZ1ciHoD.A1Ws4kbKHjN
 3Vt11mOO8fVyHGVdcHS3Up_GtoHhEiIt00CSmnhqrH8fgpuMqclX47LBdFT6
 F6UhTiGDddb8.bdaXooHW5gJ5UfVaOQ--
X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI-
In-reply-to: <20150810102212.GA45526@Qliphoth.local>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <20150810102212.GA45526@Qliphoth.local>
To: Joshua Krusell <js.shirin@gmail.com>
cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: ignore EINTR in ztcp/zsocket accept()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21554.1439209139.1@thecus.kiddle.eu>
Date: Mon, 10 Aug 2015 14:18:59 +0200
Message-ID: <21555.1439209139@thecus.kiddle.eu>

Joshua Krusell wrote:
> -	{
> +	do {
> +	    rfd = accept(lfd, (struct sockaddr *)&soun, &len);
> +	} while (errno == EINTR && !errflag);

On success, errno is not set to zero. So if it happens to have a stray
value of EINTR before the loop, this could loop despite accept having
succeeded. Shouldn't rfd == -1 also be included in the condition?

Oliver