From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=FREEMAIL_FROM,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no
	version=3.4.4
Received: (qmail 15861 invoked from network); 22 May 2020 19:03:38 -0000
Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with ESMTPUTF8; 22 May 2020 19:03:38 -0000
Received: (qmail 6939 invoked by alias); 22 May 2020 19:03:31 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45895
Received: (qmail 4837 invoked by uid 1010); 22 May 2020 19:03:31 -0000
X-Qmail-Scanner-Diagnostics: from forward500j.mail.yandex.net by f.primenet.com.au (envelope-from <oxiedi@yandex.ru>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.3/25814. spamassassin: 3.4.4.  
 Clear:RC:0(5.45.198.250):SA:0(-2.7/5.0):. 
 Processed in 2.972669 secs); 22 May 2020 19:03:31 -0000
X-Envelope-From: oxiedi@yandex.ru
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf-ipv4.yandex.ru designates 5.45.198.250 as permitted sender)
Authentication-Results: mxback28j.mail.yandex.net; dkim=pass header.i=@yandex.ru
From: oxiedi <oxiedi@yandex.ru>
Envelope-From: oxiedi@yandex.ru
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh-workers@zsh.org
In-Reply-To: <57004-1590065025.229907@6d4A.1jvX.h7ap>
References: <3932941583753550@myt2-a7d7570d35ff.qloud-c.yandex.net> <57004-1590065025.229907@6d4A.1jvX.h7ap>
Subject: Re: [PATCH] Merge ignore and deduplication patterns in _sequence
MIME-Version: 1.0
X-Mailer: Yamail [ http://yandex.ru ] 5.0
Date: Sat, 23 May 2020 00:02:47 +0500
Message-Id: <22052201590174167@iva5-64778ce1ba26.qloud-c.yandex.net>
Content-Type: multipart/mixed;
	boundary="----==--bound.2205221.iva5-64778ce1ba26.qloud-c.yandex.net"

------==--bound.2205221.iva5-64778ce1ba26.qloud-c.yandex.net
Content-Transfer-Encoding: 7bit
Content-Type: text/plain

Thank you for the review.

I believe there is one more issue. In the following example:

  compdef '_sequence _wanted tag expl desc compadd - 1 2 3' foo

the `tag` is not known to _sequence yet. So a user can't ignore matches
using e.g.

  zstyle ':completion:*:foo:*:tag' ignored-patterns 2 '2,*' '*,2,*' '*,2'

which is a bit inconsistent. I'd have fixed it by merging _sequence
patterns with _comp_ignore in _description, but that would be too much
code changes for a small gain.

For now, I suggest to ignore -F and its argument in order to fix the
`command not found: -F` error (patch attached).
------==--bound.2205221.iva5-64778ce1ba26.qloud-c.yandex.net
Content-Disposition: attachment;
	filename="ignore--F-in-_sequence.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
	name="ignore--F-in-_sequence.patch"

ZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vQmFzZS9VdGlsaXR5L19zZXF1ZW5jZSBiL0NvbXBsZXRp
b24vQmFzZS9VdGlsaXR5L19zZXF1ZW5jZQppbmRleCBjMWZmMzIxODQuLjFhODdjMTc1MyAxMDA2
NDQKLS0tIGEvQ29tcGxldGlvbi9CYXNlL1V0aWxpdHkvX3NlcXVlbmNlCisrKyBiL0NvbXBsZXRp
b24vQmFzZS9VdGlsaXR5L19zZXF1ZW5jZQpAQCAtOCwxMCArOCwxMCBAQAogIyAtZCAgICAgOiBk
dXBsaWNhdGUgdmFsdWVzIGFsbG93ZWQKIAogbG9jYWwgY3VyY29udGV4dD0iJGN1cmNvbnRleHQi
IG5tPSIkY29tcHN0YXRlW25tYXRjaGVzXSIgcHJlIHFzZXAgbm9zZXAgbWludXMKLWxvY2FsIC1h
IG9wdHMgc2VwIG51bSBwcmVmIHN1ZiBjb250IGVuZCB1bmlxIGRlZHVwCitsb2NhbCAtYSBvcHRz
IHNlcCBudW0gcHJlZiBzdWYgY29udCBlbmQgdW5pcSBkZWR1cCBnYXJiYWdlCiAKIHpwYXJzZW9w
dHMgLUQgLWEgb3B0cyBzOj1zZXAgbjo9bnVtIHA6PXByZWYgaTo9cHJlZiBQOj1wcmVmIEk6PXN1
ZiBTOj1zdWYgXAotICAgIHE9c3VmIHI6PXN1ZiBSOj1zdWYgQzo9Y29udCBkPXVuaXEgTSs6IEor
OiBWKzogMSAyIG8rOiBYKzogeCs6CisgICAgcT1zdWYgcjo9c3VmIFI6PXN1ZiBDOj1jb250IEY6
PWdhcmJhZ2UgZD11bmlxIE0rOiBKKzogVis6IDEgMiBvKzogWCs6IHgrOgogKCggJCNjb250ICkp
ICYmIGN1cmNvbnRleHQ9IiR7Y3VyY29udGV4dCU6Kn06JGNvbnRbMl0iCiAoKCAkI3NlcCApKSB8
fCBzZXBbMl09LAogCmRpZmYgLS1naXQgYS9UZXN0L1kwMWNvbXBsZXRpb24uenRzdCBiL1Rlc3Qv
WTAxY29tcGxldGlvbi56dHN0CmluZGV4IDUxZjYwNGJjZi4uYTAwMTAzOTQ2IDEwMDY0NAotLS0g
YS9UZXN0L1kwMWNvbXBsZXRpb24uenRzdAorKysgYi9UZXN0L1kwMWNvbXBsZXRpb24uenRzdApA
QCAtMjE2LDYgKzIxNiwxNiBAQCBGOnJlZ3Jlc3Npb24gdGVzdCB3b3JrZXJzLzMxNjExCiA+Tk86
ezNwbX0KID5OTzp7MTBwbX0KIAorICBjb21wdGVzdGV2YWwgIl90c3QoKSB7IF9hcmd1bWVudHMg
JzpkZXNjOl9zZXF1ZW5jZSBjb21wYWRkIC0gMSAyIDMnIH0iCisgIGNvbXB0ZXN0ZXZhbCAienN0
eWxlICc6Y29tcGxldGlvbjoqOnRzdDoqJyBpZ25vcmVkLXBhdHRlcm5zIDIiCisgIGNvbXB0ZXN0
ICQndHN0IDEsXHQnCisgIGNvbXB0ZXN0ZXZhbCAienN0eWxlIC1kICc6Y29tcGxldGlvbjoqOnRz
dDoqJyBpZ25vcmVkLXBhdHRlcm5zIgorMDotRiBkb2Vzbid0IGJyZWFrIF9zZXF1ZW5jZQorPmxp
bmU6IHt0c3QgMSx9e30KKz5ERVNDUklQVElPTjp7ZGVzY30KKz5OTzp7Mn0KKz5OTzp7M30KKwog
IGNvbXB0ZXN0ICQnYT0oKSBiPShcdCcKIDA6bXVsdGlwbGUgZW52YXJyYXlzCiA+bGluZToge2E9
KCkgYj0ofXt9Cg==
------==--bound.2205221.iva5-64778ce1ba26.qloud-c.yandex.net--