From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id c350340f for ; Wed, 26 Feb 2020 15:52:33 +0000 (UTC) Received: (qmail 7722 invoked by alias); 26 Feb 2020 15:52:23 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45492 Received: (qmail 19205 invoked by uid 1010); 26 Feb 2020 15:52:22 -0000 X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25731. spamassassin: 3.4.2. Clear:RC:0(133.208.98.4):SA:0(-2.6/5.0):. Processed in 3.223659 secs); 26 Feb 2020 15:52:22 -0000 X-Envelope-From: takimoto-j@kba.biglobe.ne.jp X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.98.4 as permitted sender) X-Biglobe-Sender: From: "Jun. T" Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: Unreadable directories aren't included in glob expansion Date: Thu, 27 Feb 2020 00:51:44 +0900 References: <20200109154145.rqksfenozx6745rn@tarpaulin.shahaf.local2> <1578585101.6028.13.camel__24021.2781982095$1578585228$gmane$org@samsung.com> <20200109172222.uwgyjouab45zk2gf__13897.4118557357$1578604026$gmane$org@chaz.gmail.com> <20200110072753.yh7qms4w2gb44zcf@chaz.gmail.com> <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2> To: zsh-workers@zsh.org In-Reply-To: <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2> Message-Id: <228AACAF-6A76-417F-929A-0CC48A9AB1D0@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3445.104.11) X-Biglobe-Spnum: 12796 (moved from users/24633=E2=81=A9) > 2020/01/11 2:09, Daniel Shahaf wrote: >=20 > diff --git a/Test/D02glob.ztst b/Test/D02glob.ztst (snip) > + mkdir -m 000 glob.tmp/secret-d000 > + mkdir -m 111 glob.tmp/secret-d111 > + mkdir -m 444 glob.tmp/secret-d444 > + for 1 in 000 111 444 ; do ln -s secret-d$1 glob.tmp/secret-s$1; done > + print -rC 2 -- glob.tmp/secret-*/ glob.tmp/secret-*(-/) > +-f:unreadable directories can be globbed (users/24619, users/24626) (snip) This test fails on Cygwin, i.e., does not fail as expected. This is because stat("glob.tmp/secret-d000/.") succeeds on Cygwin. I asked about this in the cygwin mailing list and learned that this is the default behavior of Windows and it is not easy for Cygwin to override it. I think just skipping this test on Cygwin is enough for now. diff --git a/Test/D02glob.ztst b/Test/D02glob.ztst index b0650c8c8..973dc2207 100644 --- a/Test/D02glob.ztst +++ b/Test/D02glob.ztst @@ -729,11 +729,15 @@ >not/exist >exist =20 - mkdir -m 000 glob.tmp/secret-d000 - mkdir -m 111 glob.tmp/secret-d111 - mkdir -m 444 glob.tmp/secret-d444 - for 1 in 000 111 444 ; do ln -s secret-d$1 glob.tmp/secret-s$1; done - print -rC 2 -- glob.tmp/secret-*/ glob.tmp/secret-*(-/) + if [[ $OSTYPE =3D cygwin* ]]; then + ZTST_skip=3D'Cygwin ignores search permission of directories' + else + mkdir -m 000 glob.tmp/secret-d000 + mkdir -m 111 glob.tmp/secret-d111 + mkdir -m 444 glob.tmp/secret-d444 + for 1 in 000 111 444 ; do ln -s secret-d$1 glob.tmp/secret-s$1; done + print -rC 2 -- glob.tmp/secret-*/ glob.tmp/secret-*(-/) + fi -f:unreadable directories can be globbed (users/24619, users/24626) >glob.tmp/secret-d000/ glob.tmp/secret-d000 >glob.tmp/secret-d111/ glob.tmp/secret-d111