Re: _libvirt, $opt_args, and noglob

[Marko Myllynen <myllynen@redhat.com>]

Hi,

On 2016-09-07 02:46, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Sun, Sep 04, 2016 at 18:26:22 +0000:
>> In the special case of _libvirt, simply adding noglob to the
>> _call_program arguments would probably fix this.
> 
> Done, but the last line touches the sudo invocation from Oliver's
> gain-privileges patch.  Oliver: shall I wait with committing this until
> you've committed gain-privileges?
> 
> @@ -224,7 +224,7 @@ case $state in
>        local srv ; (( ${(k)words[(I)--server]} > 0 )) && srv=${words[1+${(k)words[(I)--server]}]}
>        [[ -z $srv ]] && return 1
>        [[ -n ${srv//[[:alnum:]]} ]] && return 1
> -      _wanted clients expl client compadd ${=${${(f):-"$(sudo virt-admin ${(Q)conn_opt} srv-clients-list --server $srv 2>/dev/null)"}/ [a-z]*}//[^0-9]} && return 0
> +      _wanted clients expl client compadd ${=${${(f):-"$(noglob sudo virt-admin ${(Q)conn_opt} srv-clients-list --server $srv 2>/dev/null)"}/ [a-z]*}//[^0-9]} && return 0
>      fi
>      [[ -z $_cache_virt_admin_cmd_opts[$cmd] ]] && \
>        _cache_virt_admin_cmd_opts[$cmd]=${(M)${${${${=${(f)"$(_call_program virt-admin virt-admin help $cmd 2>&1)"}}/\[}/\]}/\;}:#-[-0-9A-Za-z]*}
> ]]]

Do we need any of (Q)'s there any more after your addition of:

  uri=${uri//(#m)\\([\\:])/${MATCH[2]}} # opt_args elements are colon-escaped

Based on a quick test looks like they could be dropped (or
perhaps even changed to (q))?

Thanks,

-- 
Marko Myllynen