From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d7b6d9b3 for ; Tue, 2 Apr 2019 17:46:52 +0000 (UTC) Received: (qmail 21822 invoked by alias); 2 Apr 2019 17:46:34 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44203 Received: (qmail 14528 invoked by uid 1010); 2 Apr 2019 17:46:34 -0000 X-Qmail-Scanner-Diagnostics: from mail-io1-f54.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.1/25405. spamassassin: 3.4.2. Clear:RC:0(209.85.166.54):SA:0(-1.9/5.0):. Processed in 1.808583 secs); 02 Apr 2019 17:46:34 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.54 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Jb2DcKzcEcNpuQ/9kDfoHOBZ4dT5HZBu7Dqw2YFX3Hc=; b=wiwcgOqfoUc/Brbo9r8WBpwL4CVZVMomXWR3mKDXJl/zZDTylU5/tcrQm03hAnSRVn LLNOt42egUMbbQcfJsWpOPbi4pGDRgN4mwL5H+7fWOYSeu5TMWppGmI815K8XfEIXgBH wogMm/WxQrELmtk4xkGzsUZEaGkyrPhCDl/rkruLkVyfIejpUukyLmVQbbBIrKNeZiRD fbYK+ogETWpVXcfPcGnk7agJH+LqcicZhhbmeVtjIllzLolCm9s3WuMFwsMHe9VBSZSr Fs6FVmNspj82AkliRPQ8iG5wxrKbynq4H8DBSZGdERxY2TOn87cF+wUuHuI5X/BIs7fQ e+eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Jb2DcKzcEcNpuQ/9kDfoHOBZ4dT5HZBu7Dqw2YFX3Hc=; b=mm4M4iErCQO557GIPT1IKNv7DzGQMeuDzUwLRFRw3IuW+NFlEs26u1Nh56DPt7SlNz sRjRS7NEQL3evknKkiAFYqhL3+kDy9NMG5ib5RU02BLDNrRpH1L5/skBRxsitDTh7eim dO3agv+9gLvAdNezfyiBzqg7jGzviWc2mvdtSpu5ABK7QPv6LofIxUAPq/TIemhE4uyJ 6KlH2OyidO3kAiPBhNMVYQysNitycJxVclQT1Gu4ysXSdDWR3rZVjdRxHpmxeyrIrfj4 oykO/DjHJSS6Cag4ow/lFbH7Mqh7oC4mo+xwKHYD5YijMLaQFJrbY02Vo1xjZJ+rj2RJ xlKQ== X-Gm-Message-State: APjAAAVLvqc/Wl9CEBUy4+X+KkkCUJuZD+48ePH5fsvzqAtUf3H0uadb zOMWCGGFgmhLwRF2oRHCu0opQg== X-Google-Smtp-Source: APXvYqzzspuKoHayq9rMeNt1dvuqOnh/3IHRR4HrCYo8FeQcvy4vmF+aPu+lvS4BQTLPeWbgXZaNWw== X-Received: by 2002:a5e:981a:: with SMTP id s26mr31526463ioj.90.1554227158278; Tue, 02 Apr 2019 10:45:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH 4/4] _normal: Add -P to reset precommands From: dana In-Reply-To: <20190402031310.GA60178@CptOrmolo.darkstar> Date: Tue, 2 Apr 2019 12:45:56 -0500 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: <233414EF-D68C-4829-B2CC-A9841DCFCF2B@dana.is> References: <20190402031310.GA60178@CptOrmolo.darkstar> To: Matthew Martin X-Mailer: Apple Mail (2.3445.9.1) On 1 Apr 2019, at 22:13, Matthew Martin wrote: >Add the ability to reset the precommands array to empty. Will be useful >for zsh -c and perhaps some other situations. Again the texi is >cargo-culted. I like it. The documentation looks mostly OK to me, but: >+xitem(tt(_normal) [ tt(-P) | tt(-p) var(precommand) ])( I know it wasn't your fault, but i think this should be item()(), not xitem()(). I don't fully understand the distinction, but xitem() seems = to be used only when there are multiple headings (describing different ways to = use the command); left here, it breaks the man-page formatting for the = paragraphs you added. > completes after pre-command specifiers such as tt(nohup), removes the Also not your fault, but this is the only place in the documentation (including your changes) where 'pre-command' is hyphenated. Maybe fix = that? >+Append var(precommand) to the list of precommands. Should be used in >+Reset the list of precommands. Should be used if completing a command This clipped style (ommitting the subject of the sentence) isn't used = anywhere else in the documentation that i can see. >+ '*::arguments: _normal -p $service' The 'arguments' here is superfluous. idk if you planned to do another pass, but i noticed several = straight-forward examples of other functions that could make use of `_normal -p`: _env, _fakeroot, _nice, _stdbuf, _timeout, &c. _env is kind of a special case, though, in that it (ab)uses _normal's standard behaviour to provide variable-assignment completion too. Maybe there's a general solution for = that dana