PATCH: remove support for autoconf before 2.50

PATCH: remove support for autoconf before 2.50

[Peter Stephenson]

Can someone confirm this is a suitable patch for removing support for
old versions of autoconf, together with deleting configure.in which I
will commit at the same time?

Index: zshconfig.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/zshconfig.ac,v
retrieving revision 1.42
diff -u -r1.42 zshconfig.ac
--- zshconfig.ac	13 Nov 2003 14:34:34 -0000	1.42
+++ zshconfig.ac	6 Jan 2004 12:08:52 -0000
@@ -2085,9 +2085,6 @@
 done) >${CONFIG_MODULES}
 rm -f ${CONFIG_MODULES}.old
 EOM
-AC_OUTPUT_COMMANDS(,[if test -z "\$CONFIG_FILES\$CONFIG_HEADERS"; then
-`cat ./${CONFIG_MODULES}.sh && rm -f ./${CONFIG_MODULES}.sh`
-fi])
 . ./${CONFIG_MODULES}.sh
 
 CLEAN_MK="${srcdir}/Config/clean.mk"
Index: Etc/zsh-development-guide
===================================================================
RCS file: /cvsroot/zsh/zsh/Etc/zsh-development-guide,v
retrieving revision 1.9
diff -u -r1.9 zsh-development-guide
--- Etc/zsh-development-guide	28 Jun 2001 11:25:41 -0000	1.9
+++ Etc/zsh-development-guide	6 Jan 2004 12:08:52 -0000
@@ -18,10 +18,9 @@
 To develop (as opposed to just build) zsh, you'll need a few specialised
 tools:
 
-* GNU autoconf, version 2.12 or later.  (Earlier versions mostly work,
-  but part of the configuration system now relies on part of the format
-  of the config.status files that get generated.  See the comments in
-  configure.in and at the end of Src/mkmakemod.sh for an explanation.)
+* GNU autoconf, version 2.50 or later.  This version contained
+  significant enhancements and arlier versions will no
+  longer work.
 
 * GNU m4.  (Required by autoconf.)
 

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************

Re: PATCH: remove support for autoconf before 2.50

[Bart Schaefer]

On Jan 6, 12:13pm, Peter Stephenson wrote:
} Subject: PATCH: remove support for autoconf before 2.50
}
} Can someone confirm this is a suitable patch for removing support for
} old versions of autoconf, together with deleting configure.in which I
} will commit at the same time?

I'm not sure why you think these three lines have anything to do with
autoconf 2.13 specifically.

} -AC_OUTPUT_COMMANDS(,[if test -z "\$CONFIG_FILES\$CONFIG_HEADERS"; then
} -`cat ./${CONFIG_MODULES}.sh && rm -f ./${CONFIG_MODULES}.sh`
} -fi])

IIRC those lines are there so that the commands in ./${CONFIG_MODULES}.sh
get re-run when config.status is run.  That was not *intended* as a fix
only for autoconf 2.13; why is it not needed in 2.50?

Re: PATCH: remove support for autoconf before 2.50

[Peter Stephenson]

Bart Schaefer wrote:
> } -AC_OUTPUT_COMMANDS(,[if test -z "\$CONFIG_FILES\$CONFIG_HEADERS"; then
> } -`cat ./${CONFIG_MODULES}.sh && rm -f ./${CONFIG_MODULES}.sh`
> } -fi])
> 
> IIRC those lines are there so that the commands in ./${CONFIG_MODULES}.sh
> get re-run when config.status is run.  That was not *intended* as a fix
> only for autoconf 2.13; why is it not needed in 2.50?

I'm now more confused by Andrej's message.  I thought he was saying that
a test wasn't needed for 2.50, but it looks like he was actually saying
we need a test anyway, and it's not available in 2.50.  In that case, we
can't get rid of the lines but it still won't always work.

(The subtext is `whoever understands this, please fix it'.)

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited. 
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************