zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: dana <dana@dana.is>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: completion option updates
Date: Wed, 22 May 2019 11:21:25 +0200	[thread overview]
Message-ID: <23738-1558516885.502890@dUBD.ayrU.IndH> (raw)
In-Reply-To: <BC226C34-1623-491C-97CD-2841D8E46894@dana.is>

dana wrote:
> > openssh 8.0p1 - this was already done but args to -T were missed
>
> Correct me if i've missed something, but i don't think this is right.
> ssh-add's help output does say that -T takes an argument, but the actual
> source indicates that it doesn't ??? the flag's effect is applied to the tool's
> normal operands (which are identity files).

That is correct but note that the patch uses the :*: _arguments
form to handle all arguments following -T. The man page for ssh-add,
indicates that -T can't be used in combination with any other options.
So following -T, the only thing that is valid is public key files. So
_files with a *.pub glob is slightly more specific than the full _files
that is otherwise used. If, contrary to the man page, you can usefully
do things like ssh-add -T -v pubkey then it is probably better left as
you had it.

Oliver

  reply	other threads:[~2019-05-22  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  0:01 Oliver Kiddle
2019-05-22  1:54 ` dana
2019-05-22  9:21   ` Oliver Kiddle [this message]
2019-05-22 10:23     ` dana
  -- strict thread matches above, loose matches on Subject: below --
2019-10-01 18:26 Oliver Kiddle
2019-07-30  9:44 Oliver Kiddle
2018-04-16 14:28 Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23738-1558516885.502890@dUBD.ayrU.IndH \
    --to=okiddle@yahoo.co.uk \
    --cc=dana@dana.is \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).