zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: fix configure good and proper.
Date: Wed, 18 Feb 2004 14:09:57 +0100	[thread overview]
Message-ID: <23791.1077109797@trentino.logica.co.uk> (raw)
In-Reply-To: <20040214184324.9D336865B@pwstephenson.fsnet.co.uk>

On 14 Feb, Peter wrote:
> I've spent my afternoon updating configure to fit better with the latest
> features.  I will commit the changes immediately --- it's only been
> tried on Debian and Mandrake, so expect a certain amount of pain
> elsewhere.  However, the changes went a lot smoother than I expected.

This looks great.

Only one minor issue:

  config.status: executing config.modules commands
  ./config.status[1515]: config.modules.sh:  not found

That's because the dot command in /bin/sh on Solaris searches the path
for config.modules.sh. It seems bash will look in the current directory
anyway which is probably why it works on Linux. I've put the fix below.

> I have not reapplied the changes to attempt to improve terminfo
> configuration.  That will need rewriting; also, we need to avoid a
> problem with checking term.h before we know it compiles.

Yes, I still need the previous terminfo patch at home but it seems to
have solved the config.modules problems I had - thanks. I also get this
on Solaris 8. Is that what you're talking about with term.h:

  checking term.h usability... no
  checking term.h presence... yes
  configure: WARNING: term.h: present but cannot be compiled
  configure: WARNING: term.h:     check for missing prerequisite headers?
  configure: WARNING: term.h: see the Autoconf documentation
  configure: WARNING: term.h:     section "Present But Cannot Be Compiled"
  configure: WARNING: term.h: proceeding with the preprocessor's result
  configure: WARNING: term.h: in the future, the compiler will take precedence
  configure: WARNING:     ## ------------------------------------------ ##
  configure: WARNING:     ## Report this to the AC_PACKAGE_NAME lists.  ##
  configure: WARNING:     ## ------------------------------------------ ##
  checking for term.h... yes

Should we be defining something so that it says `zsh' instead of
AC_PACKAGE_NAME?

Doesn't seem to matter though - it builds and `make test' passes.

Oliver

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.6
diff -u -r1.6 configure.ac
--- configure.ac	17 Feb 2004 13:53:36 -0000	1.6
+++ configure.ac	18 Feb 2004 13:14:40 -0000
@@ -2341,7 +2341,7 @@
 
 AC_CONFIG_FILES(Config/defs.mk Makefile Doc/Makefile Etc/Makefile \
 Src/Makefile Test/Makefile)
-AC_CONFIG_COMMANDS([config.modules], [. config.modules.sh])
+AC_CONFIG_COMMANDS([config.modules], [. ./config.modules.sh])
 
 AC_OUTPUT
 


  parent reply	other threads:[~2004-02-18 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-14 18:43 Peter Stephenson
2004-02-14 19:50 ` Bart Schaefer
2004-02-18 13:09 ` Oliver Kiddle [this message]
2004-02-18 14:03   ` Peter Stephenson
2004-02-18 17:27     ` Dan Nelson
2004-02-18 17:45       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23791.1077109797@trentino.logica.co.uk \
    --to=okiddle@yahoo.co.uk \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).