zsh-workers
 help / color / mirror / code / Atom feed
From: "Mikael Magnusson" <mikachu@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: _git (large)
Date: Thu, 27 Sep 2007 01:16:00 +0200	[thread overview]
Message-ID: <237967ef0709261616q39d1f76al9e34b8b5fb6603a7@mail.gmail.com> (raw)
In-Reply-To: <20070925190011.GA26894@scowler.net>

Found another issue, with fix
There is a reference to __git_tag_ids on line 2677 but i'm not sure
what it's supposed to do exactly.

(( $+functions[__git_tag_ids] )) ||
__git_tag_ids () {
}

It should possibly just be removed?

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 62b2361..d98498b 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -1833,7 +1833,7 @@ __git_zstyle_default
':completion::complete:git-status:argument-rest:*' ignore-l
 (( $+functions[_git-verify-tag] )) ||
 _git-verify-tag () {
   _arguments \
-    ':tag:__git_tag_ids' && ret=0
+    ':tag:__git_tags' && ret=0
 }

 # TODO: This should take those arguments that git-diff-tree can take, as well.


-- 
Mikael Magnusson


  reply	other threads:[~2007-09-26 23:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 15:59 Clint Adams
2007-09-25 17:34 ` Mikael Magnusson
2007-09-25 17:54   ` Clint Adams
2007-09-25 18:44     ` Mikael Magnusson
2007-09-25 19:00       ` Clint Adams
2007-09-26 23:16         ` Mikael Magnusson [this message]
2007-09-27 11:25           ` Nikolai Weibull
2007-09-27 11:43             ` Clint Adams
2007-09-27 11:57               ` Nikolai Weibull
2007-09-27 12:34                 ` Clint Adams
2007-09-27 11:32           ` Clint Adams
2007-09-27 11:57             ` Nikolai Weibull
2007-09-27 12:38           ` Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237967ef0709261616q39d1f76al9e34b8b5fb6603a7@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).