From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-23838-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 23022 invoked from network); 26 Sep 2007 23:16:17 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.2.3
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 26 Sep 2007 23:16:17 -0000
Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 2764 invoked from network); 26 Sep 2007 23:16:11 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 26 Sep 2007 23:16:11 -0000
Received: (qmail 23753 invoked by alias); 26 Sep 2007 23:16:08 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 23838
Received: (qmail 23734 invoked from network); 26 Sep 2007 23:16:07 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by sunsite.dk with SMTP; 26 Sep 2007 23:16:07 -0000
Received: (qmail 2418 invoked from network); 26 Sep 2007 23:16:07 -0000
Received: from wa-out-1112.google.com (209.85.146.183)
  by a.mx.sunsite.dk with SMTP; 26 Sep 2007 23:16:02 -0000
Received: by wa-out-1112.google.com with SMTP id j4so3143771wah
        for <zsh-workers@sunsite.dk>; Wed, 26 Sep 2007 16:16:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        bh=NFRBgZqjebBfSuawMVzHfLwUcguRjPpZt4HL31FavQI=;
        b=ufANXQxmjJStiI/JLcXpLQJBQTcJdCKHaBlPQHvZ48W5MmQEjWRE6Vd8l4ifFcrJFBvzHW6ACL4I2b4ZpVJEs8roHRMjjuXMbP6DuBjP08+A/sOx+Ju2sEt/mF4Ck9XKJq68fAt+HP5UvBVnjX9GLF66NJI96M7hSsOMh7IsBRI=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=bAcWEj7SKjdSuXtj55RXlATABv8kvoos6O4Z9YhsU2yZ2y2y8F3OPyew9t3gf6uZV9UnGAZQkWesLp7L1t3ZCKpiwCqMNk5OvGN44DgI+c6WccpGCRuy/80n59H0llKmIvaMgN50OyRiF4VYjdv6ljRAMKZYEnoLpFa5d+vZpHo=
Received: by 10.114.161.11 with SMTP id j11mr1703704wae.1190848560055;
        Wed, 26 Sep 2007 16:16:00 -0700 (PDT)
Received: by 10.142.86.21 with HTTP; Wed, 26 Sep 2007 16:16:00 -0700 (PDT)
Message-ID: <237967ef0709261616q39d1f76al9e34b8b5fb6603a7@mail.gmail.com>
Date: Thu, 27 Sep 2007 01:16:00 +0200
From: "Mikael Magnusson" <mikachu@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: _git (large)
In-Reply-To: <20070925190011.GA26894@scowler.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070925155927.GA22272@scowler.net>
	 <237967ef0709251034u4f1edc29i4ecadbed57bee1d4@mail.gmail.com>
	 <20070925175434.GA25244@scowler.net>
	 <237967ef0709251144t4b553b5dla9ff570de41bbed4@mail.gmail.com>
	 <20070925190011.GA26894@scowler.net>

Found another issue, with fix
There is a reference to __git_tag_ids on line 2677 but i'm not sure
what it's supposed to do exactly.

(( $+functions[__git_tag_ids] )) ||
__git_tag_ids () {
}

It should possibly just be removed?

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 62b2361..d98498b 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -1833,7 +1833,7 @@ __git_zstyle_default
':completion::complete:git-status:argument-rest:*' ignore-l
 (( $+functions[_git-verify-tag] )) ||
 _git-verify-tag () {
   _arguments \
-    ':tag:__git_tag_ids' && ret=0
+    ':tag:__git_tags' && ret=0
 }

 # TODO: This should take those arguments that git-diff-tree can take, as well.


-- 
Mikael Magnusson