zsh-workers
 help / color / mirror / code / Atom feed
From: "Mikael Magnusson" <mikachu@gmail.com>
To: zsh-workers <zsh-workers@sunsite.dk>
Cc: "Clint Adams" <clint@zsh.org>
Subject: Re: Fix a typo in _git.
Date: Mon, 18 Aug 2008 01:30:13 +0200	[thread overview]
Message-ID: <237967ef0808171630y5605457exe8b35d2fc5ef5c76@mail.gmail.com> (raw)
In-Reply-To: <237967ef0808171623rcedc156jc9c191af34862b8d@mail.gmail.com>

Apparently sometimes fixing typos breaks more than it fixes :). Sorry
about gmail line-wrapping too...
Here's the direct link to the patch since i can't make gmail not suck.
http://git.mika.l3ib.org/?p=zsh-cvs.git;a=commitdiff_plain;h=362b127e23341ab17988ef6ef2bf45dece5cbe8e

commit 362b127e23341ab17988ef6ef2bf45dece5cbe8e
Author: Mikael Magnusson <mikachu@gmail.com>
Date:   Mon Aug 18 01:21:04 2008 +0200

    _git: Fix a typo that looks like it should break more than it does.

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 52c2b41..047e666 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -2573,7 +2573,8 @@ _git-svn () {
           arguments+=('--stdin[read list of commits to commit from stdin]')
           ;;
         (show-ignore)
-          arguments+=('-r
--revision)'{-r,--revision)'[undocumented]:revision:->__git_svn_revisions'
+          arguments+=('-r
--revision)'{-r,--revision}'[undocumented]:revision:->__git_svn_revisions')
+          ;;
         (dcommit)
           arguments+=(
             '(-n --dry-run)'{-n,--dry-run}'[output git-commands that
would show diffs that would be committed]')


2008/8/18 Mikael Magnusson <mikachu@gmail.com>:
> % in vim just found this for me.
>
> commit 67345b5a05c7660933a73c7a458704c6df4b7411
> Author: Mikael Magnusson <mikachu@gmail.com>
> Date:   Mon Aug 18 01:21:04 2008 +0200
>
>    _git: Fix a typo that looks like it should break more than it does.
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index 52c2b41..0345f7e 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -2573,7 +2573,7 @@ _git-svn () {
>           arguments+=('--stdin[read list of commits to commit from stdin]')
>           ;;
>         (show-ignore)
> -          arguments+=('-r
> --revision)'{-r,--revision)'[undocumented]:revision:->__git_svn_revisions'
> +          arguments+=('-r
> --revision)'{-r,--revision}'[undocumented]:revision:->__git_svn_revisions'
>         (dcommit)
>           arguments+=(
>             '(-n --dry-run)'{-n,--dry-run}'[output git-commands that
> would show diffs that would be committed]')
>
>
> --
> Mikael Magnusson
>



-- 
Mikael Magnusson


  reply	other threads:[~2008-08-17 23:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 23:56 Mikael Magnusson
2008-08-16  0:45 ` Clint Adams
2008-08-16 12:56 ` Clint Adams
2008-08-16 13:25 ` Clint Adams
2008-08-16 13:55 ` Clint Adams
2008-08-16 16:15 ` Clint Adams
2008-08-16 17:59 ` Clint Adams
2008-08-16 18:29 ` Clint Adams
2008-08-17 14:03 ` Clint Adams
2008-08-17 17:13 ` Clint Adams
2008-08-17 17:27   ` Mikael Magnusson
2008-08-18  1:46     ` Clint Adams
2008-08-18  9:47       ` Mikael Magnusson
2008-08-18 20:10         ` Mikael Magnusson
2008-08-18 22:45           ` Clint Adams
2008-08-19  0:09             ` Mikael Magnusson
2008-08-19  0:25               ` Clint Adams
2008-08-19  0:37                 ` Mikael Magnusson
2008-08-19  0:39                   ` Mikael Magnusson
2008-08-19  0:58                   ` Clint Adams
2008-08-19  1:05                   ` Clint Adams
2008-08-17 23:23 ` Mikael Magnusson
2008-08-17 23:30   ` Mikael Magnusson [this message]
2008-08-18  0:08     ` Phil Pennock
2008-08-19  1:08 ` Clint Adams
2008-08-19  1:41 ` Clint Adams
  -- strict thread matches above, loose matches on Subject: below --
2007-10-18 21:23 Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237967ef0808171630y5605457exe8b35d2fc5ef5c76@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=clint@zsh.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).